Skip to content

fix typo #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open

fix typo #67

wants to merge 59 commits into from

Conversation

@bmuenzenmeyer
Copy link
Owner

@bmuenzenmeyer bmuenzenmeyer commented Oct 26, 2023

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@bmuenzenmeyer
add lighthouse preview
a32af21
@bmuenzenmeyer
Merge pull request #47 from bmuenzenmeyer/lighthouse
1e5cb9a 
add lighthouse preview
@bmuenzenmeyer
add more than one url
b634add
@bmuenzenmeyer
remove unneeded step
67723fa
@bmuenzenmeyer
use other vercel action
8c09fc3
@bmuenzenmeyer
Merge pull request #48 from bmuenzenmeyer/lighthouse-test
e3d86b5 
add more than one url
@bmuenzenmeyer
remove unnecessary condition
34f6231
@bmuenzenmeyer
checkout forked branch again
7cce200
@bmuenzenmeyer
Merge pull request #49 from bmuenzenmeyer/lighthouse-test2
1207084 
remove unnecessary condition
@bmuenzenmeyer
increase vercel timeout
a26dc58
@bmuenzenmeyer
use correct filename
8a53510
@bmuenzenmeyer
Merge pull request #50 from bmuenzenmeyer/lighthouse-test2
7120f0c 
increase vercel timeout
@bmuenzenmeyer
update pull-request comment
5432a7f
@bmuenzenmeyer
tun assertions
a03f8ba
@bmuenzenmeyer
Merge pull request #51 from bmuenzenmeyer/lighthouse-test2
f24bc63 
update pull-request comment
@bmuenzenmeyer
add more than one url a different way
e450844
@bmuenzenmeyer
format lighthouse output
d81847c
@bmuenzenmeyer
Merge pull request #52 from bmuenzenmeyer/lighthouse-test2
4af0813 
add more than one url a different way
@bmuenzenmeyer
fix typo
885e46c
@bmuenzenmeyer
set locale in urls
369c73a
@bmuenzenmeyer
Merge pull request #53 from bmuenzenmeyer/lighthouse-test2
0839bd2 
fix typo
@bmuenzenmeyer
remove unused config
4a1647e
@bmuenzenmeyer
format result
f1e9033
@bmuenzenmeyer
Merge pull request #54 from bmuenzenmeyer/lighthouse-test2
8a6b0b6 
remove unused config
@bmuenzenmeyer
use same comment on final result
4e8549e
@bmuenzenmeyer
make valid cjs module
ee3c0da
@bmuenzenmeyer
Merge pull request #55 from bmuenzenmeyer/lighthouse-test2
3a28ae9 
use same comment on final result
@bmuenzenmeyer
comment todo
4b232d3
@bmuenzenmeyer
formatting scores
dda14db
@bmuenzenmeyer
Merge pull request #56 from bmuenzenmeyer/lighthouse-test2
0a3cae8 
comment todo
@bmuenzenmeyer
Merge pull request #58 from bmuenzenmeyer/lighthouse-test2
a59de9b 
Lighthouse Test Results
@bmuenzenmeyer
add /en/about page
4928135
@bmuenzenmeyer
Revert "change to ESM"
aaa56c9 
This reverts commit db8b02a.
@bmuenzenmeyer
Merge pull request #59 from bmuenzenmeyer/lighthouse-test2
2eae555 
add /en/about page
@bmuenzenmeyer
add previous releases page
9ae78a9
@bmuenzenmeyer
condensed output
25e7533
@bmuenzenmeyer
Merge pull request #60 from bmuenzenmeyer/lighthouse-test2
7d27e72 
add previous releases page
@bmuenzenmeyer
add blog
31cd8b5
@bmuenzenmeyer
cleanup
128c688
@bmuenzenmeyer
Merge branch 'nodejs:main' into main
cca36bf
@bmuenzenmeyer
Merge pull request #61 from bmuenzenmeyer/lighthouse-test2
8f1e9f6 
add blog
@bmuenzenmeyer
do not run on push
dd57898
@bmuenzenmeyer
Merge pull request #62 from bmuenzenmeyer/lighthouse-test2
4976e3f 
do not run on push
@bmuenzenmeyer
simplify comment, trigger change
7312973
@bmuenzenmeyer
troubleshoot why links output is empty
354764a
@bmuenzenmeyer
Merge pull request #63 from bmuenzenmeyer/lighthouse-verification
8edd969 
simplify comment, trigger change
@bmuenzenmeyer
testing lighthouse
544cc7e
@bmuenzenmeyer
Merge pull request #64 from bmuenzenmeyer/lh-test
0f01d7b 
testing lighthouse
@bmuenzenmeyer
chore: simplify code, add tests
41f9cd3
@bmuenzenmeyer
Merge pull request #65 from bmuenzenmeyer/lh-test
3e48178 
chore: simplify code, add tests
@bmuenzenmeyer
Merge branch 'nodejs:main' into main
4a84d2d
@bmuenzenmeyer
use renamed function
2d31e59
@bmuenzenmeyer
fix typo
389fc11
@vercel
Copy link

vercel bot commented Oct 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 11:58pm

@github-actions
Copy link

github-actions bot commented Oct 26, 2023 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 85 🟢 95 🟠 83 🟢 92 🔗
/en/about 🟢 99 🟢 93 🟠 83 🟢 92 🔗
/en/about/previous-releases 🟢 98 🟢 91 🟠 83 🟢 92 🔗
/en/download 🟢 100 🟢 93 🟠 83 🟢 92 🔗
/en/blog 🟢 100 🟢 93 🟠 83 🟢 92 🔗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bmuenzenmeyer