Skip to content

Commit 312f7a7

Browse files
authored
Changed default value of verify_ssl to True (#527)
1 parent c76dfb4 commit 312f7a7

File tree

6 files changed

+11
-3
lines changed

6 files changed

+11
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
- Connection timeout errors now include the URL and suggest increasing timeout parameter
1616
- Connection errors provide actionable steps like checking internet connection and increasing retries
1717
- Network errors include clear failure reasons and suggested actions
18-
- HTTP response errors now include status code and reason.
18+
- HTTP response errors now include status code and reason
19+
- Changed default value of `verify_ssl` to `True`
1920

2021
* `lobster-python`:
2122
- Added system test infrastructure and Bazel targets under `tests_system/lobster_python`.

lobster/tools/codebeamer/codebeamer.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,9 @@ def query_cb_single(cb_config: Config, url: str):
157157
f"Reason: {ex}\n"
158158
"\nPossible actions:\n"
159159
"• Check internet connection\n"
160-
"• Increase retries using 'num_request_retry'"
160+
"• Increase retries using 'num_request_retry'\n"
161+
"• Check SSL certificates or disable verification by setting "
162+
f"'{SupportedConfigKeys.VERIFY_SSL.value}' to false"
161163
) from ex
162164

163165
except RequestException as ex:
@@ -507,7 +509,7 @@ def parse_config_data(data: dict) -> Config:
507509
references=ensure_list(data.get(SupportedConfigKeys.REFS.value, [])),
508510
import_tagged=data.get(SupportedConfigKeys.IMPORT_TAGGED.value),
509511
import_query=data.get(SupportedConfigKeys.IMPORT_QUERY.value),
510-
verify_ssl=data.get(SupportedConfigKeys.VERIFY_SSL.value, False),
512+
verify_ssl=data.get(SupportedConfigKeys.VERIFY_SSL.value, True),
511513
page_size=data.get(SupportedConfigKeys.PAGE_SIZE.value, 100),
512514
schema=data.get(SupportedConfigKeys.SCHEMA.value, "Requirement"),
513515
timeout=data.get(SupportedConfigKeys.TIMEOUT.value, 30),

tests_system/lobster_codebeamer/lobster_codebeamer_test_runner.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ class ConfigFileData:
1717
page_size: Optional[int] = None
1818
num_request_retry: Optional[int] = None
1919
retry_error_codes: Optional[List[int]] = None
20+
verify_ssl: Optional[bool] = None
2021

2122
def set_default_root_token_out(self):
2223
self.root = f"https://localhost:{PORT}"
@@ -38,6 +39,7 @@ def append_if_not_none(key, value):
3839
append_if_not_none("page_size", self.page_size)
3940
append_if_not_none("num_request_retry", self.num_request_retry)
4041
append_if_not_none("retry_error_codes", self.retry_error_codes)
42+
append_if_not_none("verify_ssl", self.verify_ssl)
4143

4244
with open(filename, mode='w', encoding="UTF-8") as file:
4345
yaml.dump(data, file)

tests_system/lobster_codebeamer/test_extract_requirements.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ def setUpClass(cls):
2020
def setUp(self):
2121
super().setUp()
2222
self._test_runner = self.create_test_runner()
23+
self._test_runner.config_file_data.verify_ssl = False
2324

2425
def extract_requirements(self,
2526
cfg: ConfigFileData,

tests_system/lobster_codebeamer/test_lobster_codebeamer.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ def setUp(self):
2020
super().setUp()
2121
self.codebeamer_flask.reset()
2222
self._test_runner = self.create_test_runner()
23+
self._test_runner.config_file_data.verify_ssl = False
2324

2425
def test_retry_if_configured(self):
2526
"""Ensure the tool retries and exits after exhausting

tests_system/lobster_codebeamer/test_valid_flow.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ def setUp(self):
2020
super().setUp()
2121
self.codebeamer_flask.reset()
2222
self._test_runner = self.create_test_runner()
23+
self._test_runner.config_file_data.verify_ssl = False
2324

2425
def test_valid_query_id(self):
2526
# lobster-trace: codebeamer_req.Query_Id_Parameter

0 commit comments

Comments
 (0)