Skip to content

Commit fcb38e5

Browse files
authored
Delete github-release target (#493)
Delete the `make` target `github-release`, because we are using `.github/workflows/package.yml` to package releases. The `make` target is not needed.
1 parent c7c025d commit fcb38e5

File tree

4 files changed

+11
-104
lines changed

4 files changed

+11
-104
lines changed

BUILD.bazel

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -56,19 +56,6 @@ load("//:requirements.bzl", "requirement")
5656
# requirements_windows = "requirements_windows_3_9.txt",
5757
# )
5858

59-
py_binary(
60-
name = "github_release",
61-
srcs = ["util/github_release.py"],
62-
visibility = [
63-
"//visibility:public",
64-
],
65-
deps = [
66-
":lobster",
67-
"//lobster/common",
68-
requirement("requests"),
69-
],
70-
)
71-
7259
py_library(
7360
name = "lobster",
7461
srcs = [

Makefile

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -131,26 +131,23 @@ unit-tests:
131131
--source=lobster \
132132
-m unittest discover -s tests_unit -v
133133

134-
upload-main: packages
135-
python3 -m twine upload --repository pypi packages/*/dist/*
136-
python3 -m twine upload --repository pypi packages/*/meta_dist/*
137-
138134
remove-dev:
139135
python3 -m util.release
140136

141-
github-release:
142-
git push
143-
python3 -m util.github_release
144-
145137
bump:
146138
python3 -m util.bump_version_post_release
147139

148-
full-release:
149-
make remove-dev
150-
git push
151-
make github-release
152-
make bump
153-
git push
140+
141+
# steps for a release:
142+
# - create new branch
143+
# - make remove-dev
144+
# - review CHANGELOG.md (is it complete, or is something missing?)
145+
# - git push + create pull request
146+
#
147+
# - create new branch
148+
# - make bump
149+
# - git push + create pull request
150+
154151

155152
# --- Coverage Execution Targets ---
156153
coverage-unit:
@@ -175,11 +172,9 @@ clean-coverage:
175172
# --- Convenience Test Targets ---
176173
test-system: clean-coverage system-tests
177174
make coverage-system
178-
util/check_local_modifications.sh
179175

180176
test-unit: clean-coverage unit-tests
181177
make coverage-unit
182-
util/check_local_modifications.sh
183178

184179
docs:
185180
mkdir -p docs

util/check_local_modifications.sh

Lines changed: 0 additions & 11 deletions
This file was deleted.

util/github_release.py

Lines changed: 0 additions & 64 deletions
This file was deleted.

0 commit comments

Comments
 (0)