Skip to content

Commit fdebf21

Browse files
committed
Use Invoke-Program for the Windows build command
Windows does not stop scripts when native commands exit with non-zero. Instead, their exit status has to be checked manually. This can be done through an `Invoke-Program` function that is added to the script running `windows_build_command`, which also previously prefixed the given command. This is changing in swiftlang/github-workflows#154 since it doesn't help with multi-line commands - update our modified `windows_build_command` to use `Invoke-Program` instead.
1 parent a74f2e9 commit fdebf21

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/nightly.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ jobs:
6868
VSCODE_SWIFT_VSIX_ID=${{needs.package.outputs.artifact-id}}
6969
GITHUB_REPOSITORY=${{github.repository}}
7070
windows_pre_build_command: . .github\workflows\scripts\windows\setup.ps1
71-
windows_build_command: scripts\test_windows.ps1
71+
windows_build_command: Invoke-Program scripts\test_windows.ps1
7272
enable_windows_docker: false
7373

7474
tests_insiders:
@@ -99,5 +99,5 @@ jobs:
9999
VSCODE_SWIFT_VSIX_PRERELEASE=1
100100
GITHUB_REPOSITORY=${{github.repository}}
101101
windows_pre_build_command: . .github\workflows\scripts\windows\setup.ps1
102-
windows_build_command: scripts\test_windows.ps1
102+
windows_build_command: .github/workflows/nightly.yml scripts\test_windows.ps1
103103
enable_windows_docker: false

0 commit comments

Comments
 (0)