Merge pull request #6959 from chrisrueger/close-jar

chrisrueger · web-flow · commit 851b4f65bfec · 2025-11-24T05:45:39.000+01:00
fix resource leak
diff --git a/biz.aQute.bndlib/src/aQute/bnd/build/ProjectBuilder.java b/biz.aQute.bndlib/src/aQute/bnd/build/ProjectBuilder.java
@@ -224,10 +224,11 @@ public void init() {
 						if ((c.getType() == TYPE.PROJECT) && !file.exists()) {
 							continue;
 						}
-						Jar jar = new Jar(file);
 						Map<String, String> containerAttributes = c.getAttributes();
 						if (!Boolean.parseBoolean(containerAttributes.getOrDefault("maven-optional", "false"))) {
-							fillDependencies(dependencies, jar, containerAttributes);
+							try (Jar jar = new Jar(file)) {
+								fillDependencies(dependencies, jar, containerAttributes);
+							}
 						}
 					}
 				}

Original file line number	Diff line number	Diff line change
`@@ -224,10 +224,11 @@ public void init() {`
`224`	`224`	`if ((c.getType() == TYPE.PROJECT) && !file.exists()) {`
`225`	`225`	`continue;`
`226`	`226`	`}`
`227`		`- Jar jar = new Jar(file);`
`228`	`227`	`Map<String, String> containerAttributes = c.getAttributes();`
`229`	`228`	`if (!Boolean.parseBoolean(containerAttributes.getOrDefault("maven-optional", "false"))) {`
`230`		`- fillDependencies(dependencies, jar, containerAttributes);`
	`229`	`+ try (Jar jar = new Jar(file)) {`
	`230`	`+ fillDependencies(dependencies, jar, containerAttributes);`
	`231`	`+ }`
`231`	`232`	`}`
`232`	`233`	`}`
`233`	`234`	`}`