Skip to content

Commit bc1a003

Browse files
committed
Do no longer consider distribution management repos by default
This often leads to errors which break the build. Therefore this feature should be opt-in This closes #6945 Signed-off-by: Konrad Windszus <[email protected]>
1 parent b0ab961 commit bc1a003

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

maven-plugins/bnd-baseline-maven-plugin/README.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,14 +125,16 @@ be disabled as follows:
125125

126126
#### Include Distribution Management
127127

128-
By default the `bnd-baseline-maven-plugin` will include repositories
128+
By default the `bnd-baseline-maven-plugin` will not include repositories
129129
listed in the Distribution Management section of the POM when
130-
searching for the baseline. This is usually the right choice as the
131-
distribution repository does not normally change between releases.
132-
This behaviour can be disabled as follows:
130+
searching for the baseline because this is very often only suitable
131+
for uploading (but not necessary downloading).
132+
If however your distribution management URL can also be used to download
133+
old versions of your bundles you can explicitly use that as (additional)
134+
source for old versions via:
133135

134136
<configuration>
135-
<includeDistributionManagement>false</includeDistributionManagement>
137+
<includeDistributionManagement>true</includeDistributionManagement>
136138
</configuration>
137139

138140
#### Continue on Error

maven-plugins/bnd-baseline-maven-plugin/src/main/java/aQute/bnd/maven/baseline/plugin/BaselineMojo.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,15 @@ public class BaselineMojo extends AbstractMojo {
6363
@Parameter(property = "bnd.baseline.fail.on.missing", defaultValue = "true")
6464
private boolean failOnMissing;
6565

66-
@Parameter(property = "bnd.baseline.include.distribution.management", defaultValue = "true")
66+
/**
67+
* Also use the remote repository given via
68+
* {@code project.distributionManagement.repository.url} for retrieving the
69+
* base artifact.
70+
*
71+
* @see <a href="https://maven.apache.org/pom.html#Repository">POM
72+
* Reference: Distribution Management -> Repository</a>
73+
*/
74+
@Parameter(property = "bnd.baseline.include.distribution.management", defaultValue = "false")
6775
private boolean includeDistributionManagement;
6876

6977
@Parameter(property = "bnd.baseline.full.report", defaultValue = "false")

0 commit comments

Comments
 (0)