P2 exporter for RC1 creates different version/qualifiers for features and bundles

[peterkir]

[chrisrueger]

Reopened until we really see it fixed in RC2

[chrisrueger]

I have investigated. There were 2 problems:

1. the P2Export did not handle the snapshot logic for feature .jar files, so that -SNAPSHOT is never replaced even though e.g. -snapshot: RC1 is set

2. The other problem looks related , and is for the bundles.

The problem happens here:

When the bundles are collected (somewhere in P2Export Run.getRunbundles() is called.
This ends up here:

As you can see the RC1 is correctly in this version. ....

....but then it goes into Project.getDeliverable(String, Map<String,String>) line: 2912 aQute.bnd.build.Project.getDeliverable(String, Map<String, String>)

and there it gets the incorrect version with the -SNAPSHOT suffix.

In https://github.com/bndtools/bnd/pull/6973/files#diff-a01878046dba7ceb8f43d338872d8b16e659f050c099b70671419d4b778a9a93R2911 I fixed that by getting the the version from 'Project#getVersion(bsn).toString()since I noticed that thisversionsMapcontains the correct version (-SNAPTSHOT replaced by -RC1). This is becauseProjectBuilder.doneBuild()` updates this map after the build is done.
So in order to get the correct version also used by the built artifact, we need to look into this versionsMap.

PR #6973 tries to address this.(Note: the qualifiers will not be the same as for 7.1.0, because the P2Exporter does not support this structure - it needs proper OSGi versions. But the -SNAPSHOT will be replaced by the RC1 and later in the release removed completely)

[chrisrueger]

I just build RC3 (next branch) and now it looks as as expected:
We are going to make RC3 available.

Closing this issue as solved.