test: improve cov for PaletteData

Author: bnussbau

src/Data/PaletteData.php

@@ -23,13 +23,14 @@ public function __construct(
     /**
      * Load palette data from JSON file
      *
+     * @param  string|null  $jsonPath  Optional path to JSON file (defaults to palettes.json in package)
      * @return array<string, PaletteData>
      *
      * @throws ProcessingException
      */
-    public static function loadFromJson(): array
+    public static function loadFromJson(?string $jsonPath = null): array
     {
-        $jsonPath = __DIR__.'/palettes.json';
+        $jsonPath = $jsonPath ?? __DIR__.'/palettes.json';
 
         if (! file_exists($jsonPath)) {
             throw new ProcessingException("Palettes JSON file not found at: {$jsonPath}");

tests/PaletteDataTest.php

@@ -3,6 +3,7 @@
 declare(strict_types=1);
 
 use Bnussbau\TrmnlPipeline\Data\PaletteData;
+use Bnussbau\TrmnlPipeline\Exceptions\ProcessingException;
 
 describe('PaletteData', function (): void {
     it('can load palettes from JSON', function (): void {
@@ -76,4 +77,82 @@
         ]);
         expect($palette->frameworkClass)->toBe('');
     });
+
+    it('throws when palettes JSON file does not exist', function (): void {
+        $missingPath = sys_get_temp_dir().'/palettes-nonexistent-'.uniqid().'.json';
+
+        expect(fn () => PaletteData::loadFromJson($missingPath))
+            ->toThrow(ProcessingException::class, 'Palettes JSON file not found at: '.$missingPath);
+    });
+
+    it('throws when palettes JSON file cannot be read', function (): void {
+        $tmpFile = tempnam(sys_get_temp_dir(), 'palettes');
+        if ($tmpFile === false) {
+            throw new \RuntimeException('Failed to create temp file');
+        }
+        chmod($tmpFile, 0000);
+        try {
+            expect(fn () => PaletteData::loadFromJson($tmpFile))
+                ->toThrow(ProcessingException::class, 'Failed to read palettes JSON file');
+        } finally {
+            chmod($tmpFile, 0600);
+            unlink($tmpFile);
+        }
+    });
+
+    it('throws when palettes JSON is invalid', function (): void {
+        $tmpFile = tempnam(sys_get_temp_dir(), 'palettes');
+        if ($tmpFile === false) {
+            throw new \RuntimeException('Failed to create temp file');
+        }
+        try {
+            file_put_contents($tmpFile, '{ invalid json }');
+            expect(fn () => PaletteData::loadFromJson($tmpFile))
+                ->toThrow(ProcessingException::class, 'Invalid JSON in palettes file:');
+        } finally {
+            unlink($tmpFile);
+        }
+    });
+
+    it('throws when palettes JSON does not decode to array', function (): void {
+        $tmpFile = tempnam(sys_get_temp_dir(), 'palettes');
+        if ($tmpFile === false) {
+            throw new \RuntimeException('Failed to create temp file');
+        }
+        try {
+            file_put_contents($tmpFile, '123');
+            expect(fn () => PaletteData::loadFromJson($tmpFile))
+                ->toThrow(ProcessingException::class, 'Invalid JSON structure: expected array');
+        } finally {
+            unlink($tmpFile);
+        }
+    });
+
+    it('throws when palettes JSON is missing data array', function (): void {
+        $tmpFile = tempnam(sys_get_temp_dir(), 'palettes');
+        if ($tmpFile === false) {
+            throw new \RuntimeException('Failed to create temp file');
+        }
+        try {
+            file_put_contents($tmpFile, '{}');
+            expect(fn () => PaletteData::loadFromJson($tmpFile))
+                ->toThrow(ProcessingException::class, "Invalid palettes JSON structure: missing 'data' array");
+        } finally {
+            unlink($tmpFile);
+        }
+    });
+
+    it('throws when palette entry is missing id field', function (): void {
+        $tmpFile = tempnam(sys_get_temp_dir(), 'palettes');
+        if ($tmpFile === false) {
+            throw new \RuntimeException('Failed to create temp file');
+        }
+        try {
+            file_put_contents($tmpFile, '{"data":[{"name":"no-id"}]}');
+            expect(fn () => PaletteData::loadFromJson($tmpFile))
+                ->toThrow(ProcessingException::class, "Palette data missing required 'id' field");
+        } finally {
+            unlink($tmpFile);
+        }
+    });
 });