Updates to PlainYearMonth and PlainMonthDay based on review (#567)

Changes made:

- month_day.rs and year_month.rs to plain_month_day.rs and
plain_year_month.rs
- Remove padded_iso_year_string from PlainYearMonth

Author: nekevss

src/builtins/core/mod.rs

@@ -11,11 +11,11 @@ pub mod duration;
 pub mod timezone;
 
 mod instant;
-mod month_day;
 mod plain_date;
 mod plain_date_time;
+mod plain_month_day;
 mod plain_time;
-mod year_month;
+mod plain_year_month;
 pub(crate) mod zoned_date_time;
 
 mod now;
@@ -28,14 +28,14 @@ pub use duration::{DateDuration, Duration, PartialDuration};
 #[doc(inline)]
 pub use instant::Instant;
 #[doc(inline)]
-pub use month_day::PlainMonthDay;
-#[doc(inline)]
 pub use plain_date::{PartialDate, PlainDate};
 #[doc(inline)]
 pub use plain_date_time::{DateTimeFields, PartialDateTime, PlainDateTime};
 #[doc(inline)]
+pub use plain_month_day::PlainMonthDay;
+#[doc(inline)]
 pub use plain_time::{PartialTime, PlainTime};
 #[doc(inline)]
-pub use year_month::{PartialYearMonth, PlainYearMonth};
+pub use plain_year_month::{PartialYearMonth, PlainYearMonth};
 #[doc(inline)]
 pub use zoned_date_time::{PartialZonedDateTime, ZonedDateTime, ZonedDateTimeFields};

src/builtins/core/month_day.rs renamed to src/builtins/core/plain_month_day.rs

@@ -370,6 +370,7 @@ impl PlainMonthDay {
             .into()
     }
 
+    /// Creates a RFC9557 IXDTF [`Writeable`].
     pub fn to_ixdtf_writeable(&self, display_calendar: DisplayCalendar) -> impl Writeable + '_ {
         let ixdtf = FormattableMonthDay {
             date: FormattableDate(self.iso_year(), self.iso_month(), self.iso.day),

src/builtins/core/year_month.rs renamed to src/builtins/core/plain_year_month.rs

@@ -17,7 +17,6 @@ use crate::{
     provider::{NeverProvider, TimeZoneProvider},
     temporal_assert,
     unix_time::EpochNanoseconds,
-    utils::pad_iso_year,
     Calendar, MonthCode, TemporalError, TemporalResult, TemporalUnwrap, TimeZone,
 };
 
@@ -391,14 +390,14 @@ impl PlainYearMonth {
     /// Creates a new `PlainYearMonth` with an ISO 8601 calendar, rejecting any date that may be invalid.
     #[inline]
     pub fn try_new_iso(year: i32, month: u8, reference_day: Option<u8>) -> TemporalResult<Self> {
-        Self::try_new(year, month, reference_day, Calendar::default())
+        Self::try_new(year, month, reference_day, Calendar::ISO)
     }
 
     /// Creates a new `PlainYearMonth` with an ISO 8601 calendar, constraining any arguments
     /// that are invalid into a valid range.
     #[inline]
     pub fn new_iso(year: i32, month: u8, reference_day: Option<u8>) -> TemporalResult<Self> {
-        Self::new(year, month, reference_day, Calendar::default())
+        Self::new(year, month, reference_day, Calendar::ISO)
     }
 
     /// Creates a new valid `YearMonth` with provided [`Overflow`] option.
@@ -462,13 +461,6 @@ impl PlainYearMonth {
             .year_month_from_fields(fields, Overflow::Constrain)
     }
 
-    /// Returns the padded ISO year string
-    #[inline]
-    #[must_use]
-    pub fn padded_iso_year_string(&self) -> String {
-        pad_iso_year(self.iso.year)
-    }
-
     /// Returns the calendar era of the current `PlainYearMonth`
     pub fn era(&self) -> Option<TinyAsciiStr<16>> {
         self.calendar().era(&self.iso)

src/utils.rs

@@ -1,8 +1,5 @@
 //! Utility date and time equations for Temporal
 
-use alloc::format;
-use alloc::string::String;
-
 pub(crate) use timezone_provider::utils::epoch_days_from_gregorian_date;
 
 // NOTE: Potentially add more of tests.
@@ -16,16 +13,4 @@ pub(crate) use timezone_provider::utils::{
     epoch_days_to_epoch_ms, iso_days_in_month, ymd_from_epoch_milliseconds,
 };
 
-/// 3.5.11 PadISOYear ( y )
-///
-/// returns a String representation of y suitable for inclusion in an ISO 8601 string
-pub(crate) fn pad_iso_year(year: i32) -> String {
-    if (0..9999).contains(&year) {
-        return format!("{year:04}");
-    }
-    let year_sign = if year > 0 { "+" } else { "-" };
-    let year_string = format!("{:06}", year.abs());
-    format!("{year_sign}{year_string}",)
-}
-
 // ==== End Calendar Equations ====

temporal_capi/bindings/c/PlainYearMonth.h

@@ -83,13 +83,6 @@ pub mod ffi {
                 .map_err(Into::into)
         }
 
-        pub fn padded_iso_year_string(&self, write: &mut DiplomatWrite) {
-            // TODO this double-allocates, an API returning a Writeable or impl Write would be better
-            let string = self.0.padded_iso_year_string();
-            // throw away the error, the write itself should always succeed
-            let _ = write.write_str(&string);
-        }
-
         pub fn year(&self) -> i32 {
             self.0.year()
         }