Make ISO getters crate private (#568)

Closes #566

This PR removes the ISO getters from the public facing API.

I did end up keeping them for crate private because they are nice short
hand for dt.iso.date.year, etc.

Per the issue, removing these from the public API will open a question
about debug printing over FFI that we should probably have a plan for
prior to merging.

Author: nekevss

src/builtins/core/month_day.rs

@@ -177,6 +177,22 @@ impl PlainMonthDay {
         Self { iso, calendar }
     }
 
+    /// Returns the ISO month value of `PlainMonthDay`.
+    #[inline]
+    #[must_use]
+    pub(crate) fn iso_month(&self) -> u8 {
+        self.iso.month
+    }
+
+    /// Returns the ISO year value of `PlainMonthDay`.
+    #[inline]
+    #[must_use]
+    pub(crate) fn iso_year(&self) -> i32 {
+        self.iso.year
+    }
+}
+
+impl PlainMonthDay {
     /// Creates a new valid `PlainMonthDay`.
     #[inline]
     pub fn new_with_overflow(
@@ -272,27 +288,6 @@ impl PlainMonthDay {
             .month_day_from_fields(merged, overflow.unwrap_or(Overflow::Constrain))
     }
 
-    /// Returns the ISO day value of `PlainMonthDay`.
-    #[inline]
-    #[must_use]
-    pub fn iso_day(&self) -> u8 {
-        self.iso.day
-    }
-
-    // Returns the ISO month value of `PlainMonthDay`.
-    #[inline]
-    #[must_use]
-    pub fn iso_month(&self) -> u8 {
-        self.iso.month
-    }
-
-    // Returns the ISO year value of `PlainMonthDay`.
-    #[inline]
-    #[must_use]
-    pub fn iso_year(&self) -> i32 {
-        self.iso.year
-    }
-
     /// Returns the string identifier for the current `Calendar`.
     #[inline]
     #[must_use]

src/builtins/core/plain_date.rs

@@ -310,6 +310,27 @@ impl PlainDate {
     fn days_until(&self, other: &Self) -> i32 {
         other.iso.to_epoch_days() - self.iso.to_epoch_days()
     }
+
+    /// Returns this `PlainDate`'s ISO year value.
+    #[inline]
+    #[must_use]
+    pub(crate) const fn iso_year(&self) -> i32 {
+        self.iso.year
+    }
+
+    /// Returns this `PlainDate`'s ISO month value.
+    #[inline]
+    #[must_use]
+    pub(crate) const fn iso_month(&self) -> u8 {
+        self.iso.month
+    }
+
+    /// Returns this `PlainDate`'s ISO day value.
+    #[inline]
+    #[must_use]
+    pub(crate) const fn iso_day(&self) -> u8 {
+        self.iso.day
+    }
 }
 
 // ==== Public API ====
@@ -432,27 +453,6 @@ impl PlainDate {
         Self::new_unchecked(self.iso, calendar)
     }
 
-    #[inline]
-    #[must_use]
-    /// Returns this `PlainDate`'s ISO year value.
-    pub const fn iso_year(&self) -> i32 {
-        self.iso.year
-    }
-
-    #[inline]
-    #[must_use]
-    /// Returns this `PlainDate`'s ISO month value.
-    pub const fn iso_month(&self) -> u8 {
-        self.iso.month
-    }
-
-    #[inline]
-    #[must_use]
-    /// Returns this `PlainDate`'s ISO day value.
-    pub const fn iso_day(&self) -> u8 {
-        self.iso.day
-    }
-
     #[inline]
     #[must_use]
     /// Returns a reference to this `PlainDate`'s calendar slot.

src/builtins/core/plain_date_time.rs

@@ -345,6 +345,27 @@ impl PlainDateTime {
             unit,
         )
     }
+
+    /// Returns this `PlainDateTime`'s ISO year value.
+    #[inline]
+    #[must_use]
+    pub const fn iso_year(&self) -> i32 {
+        self.iso.date.year
+    }
+
+    /// Returns this `PlainDateTime`'s ISO month value.
+    #[inline]
+    #[must_use]
+    pub const fn iso_month(&self) -> u8 {
+        self.iso.date.month
+    }
+
+    /// Returns this `PlainDateTime`'s ISO day value.
+    #[inline]
+    #[must_use]
+    pub const fn iso_day(&self) -> u8 {
+        self.iso.date.day
+    }
 }
 
 // ==== Public PlainDateTime API ====
@@ -664,27 +685,6 @@ impl PlainDateTime {
         Self::new_unchecked(self.iso, calendar)
     }
 
-    /// Returns this `PlainDateTime`'s ISO year value.
-    #[inline]
-    #[must_use]
-    pub const fn iso_year(&self) -> i32 {
-        self.iso.date.year
-    }
-
-    /// Returns this `PlainDateTime`'s ISO month value.
-    #[inline]
-    #[must_use]
-    pub const fn iso_month(&self) -> u8 {
-        self.iso.date.month
-    }
-
-    /// Returns this `PlainDateTime`'s ISO day value.
-    #[inline]
-    #[must_use]
-    pub const fn iso_day(&self) -> u8 {
-        self.iso.date.day
-    }
-
     /// Returns the hour value
     #[inline]
     #[must_use]

src/builtins/core/year_month.rs

@@ -347,6 +347,20 @@ impl PlainYearMonth {
             DifferenceOperation::Until => Ok(result),
         }
     }
+
+    /// Returns the iso month value for this `YearMonth`.
+    #[inline]
+    #[must_use]
+    pub(crate) fn iso_month(&self) -> u8 {
+        self.iso.month
+    }
+
+    /// Returns the iso year value for this `YearMonth`.
+    #[inline]
+    #[must_use]
+    pub(crate) fn iso_year(&self) -> i32 {
+        self.iso.year
+    }
 }
 
 // ==== Public method implementations ====
@@ -448,34 +462,13 @@ impl PlainYearMonth {
             .year_month_from_fields(fields, Overflow::Constrain)
     }
 
-    /// Returns the iso year value for this `YearMonth`.
-    #[inline]
-    #[must_use]
-    pub fn iso_year(&self) -> i32 {
-        self.iso.year
-    }
-
     /// Returns the padded ISO year string
     #[inline]
     #[must_use]
     pub fn padded_iso_year_string(&self) -> String {
         pad_iso_year(self.iso.year)
     }
 
-    /// Returns the iso month value for this `YearMonth`.
-    #[inline]
-    #[must_use]
-    pub fn iso_month(&self) -> u8 {
-        self.iso.month
-    }
-
-    /// Returns the internal ISO day for this `YearMonth`.
-    #[inline]
-    #[must_use]
-    pub fn iso_reference_day(&self) -> u8 {
-        self.iso.day
-    }
-
     /// Returns the calendar era of the current `PlainYearMonth`
     pub fn era(&self) -> Option<TinyAsciiStr<16>> {
         self.calendar().era(&self.iso)