A bunch of required types are private

[Manishearth]

While working on FFI (#163) I discovered that a bunch of types, like CalendarDateLike and TzProvider and TimeDuration are all private but exposed in various APIs.

This makes it tricky to build FFI wrappers around them, and probably isn't great API design. These should probably be public, with TzProvider potentially being sealed to prevent external implementations (if that's the goal).

[nekevss]

Yeah, agreed. This is sort of related to #165.

I'll look into cleaning up some of the visibility on these ASAP.

[Manishearth]

Ah if the intent is that these be public I'm also happy to do that while in process of adding FFI! I didn't want to break things otherwise.

[nekevss]

TzProvider/TimeZoneProvider is definitely intended to be public; meanwhile others (TimeDuration and DateDuration) can be public but the benefits of them being public are not entirely clear to me. As a result, I was going back and forth on their visibility, which resulted in them being excluded in #97.

Honestly some of these are hold overs from very early versions of temporal_rs, so this issue gives me a good reason to begin the cleanup 😄

[nekevss]

Has the visibility on all the the types been addressed? Or are there still some types with incorrect visibility?

[Manishearth]

I don't know for sure, I think I made many of them public in my FFI PRs. Just knowing that they should not be private and can be changed is enough.

[nekevss]

Sounds good. I'm closing out this issue then.