Found the bug... or A bug...

Author: boazsegev

ext/iodine/fio-stl.h

@@ -13626,6 +13626,24 @@ Copyright and License: see header file (000 copyright.h) or top of file
 #endif
 
 #include <signal.h>
+/* ****************************************************************************
+Portable signal aliases (abstract OS differences)
+***************************************************************************** */
+
+#if FIO_OS_POSIX
+#define FIO_SIGNAL_USER1             SIGUSR1
+#define FIO_SIGNAL_USER2             SIGUSR2
+#define FIO_SIGNAL_USER_UNREGISTERED SIGUSR2
+#elif FIO_OS_WIN
+/* Windows has no SIGUSR1/SIGUSR2; map to safe, distinct signals. */
+#define FIO_SIGNAL_USER1             SIGBREAK
+#define FIO_SIGNAL_USER2             SIGABRT
+/*
+ * Use SIGBREAK for unregistered-signal tests to avoid clobbering SIGINT/SIGTERM
+ * handlers that a test harness might rely on.
+ */
+#define FIO_SIGNAL_USER_UNREGISTERED SIGBREAK
+#endif
 /* *****************************************************************************
 Signal Monitoring API
 ***************************************************************************** */
@@ -13767,7 +13785,6 @@ SFUNC int fio_signal_forget(int sig) {
     }
     return 0;
   }
-  sigaction(sig, &act, NULL);
   return -1;
 }
 
@@ -13869,7 +13886,6 @@ SFUNC int fio_signal_forget(int sig) {
     fio___signal_watchers[i].old = SIG_DFL;
     return 0;
   }
-  signal(sig, SIG_DFL);
   return -1;
 sig_error:
   fio___signal_watchers[i].old = SIG_DFL;
@@ -13902,60 +13918,6 @@ SFUNC int fio_signal_review(void) {
   return c;
 }
 
-/* *****************************************************************************
-Signal Monitoring Testing?
-***************************************************************************** */
-#ifdef FIO_TEST_ALL
-FIO_SFUNC void FIO_NAME_TEST(stl, signal)(void) {
-
-#define FIO___SIGNAL_MEMBER(a)                                                 \
-  { (int)a, #a }
-  struct {
-    int sig;
-    const char *name;
-  } t[] = {
-    FIO___SIGNAL_MEMBER(SIGINT),
-    FIO___SIGNAL_MEMBER(SIGILL),
-    FIO___SIGNAL_MEMBER(SIGABRT),
-    FIO___SIGNAL_MEMBER(SIGSEGV),
-    FIO___SIGNAL_MEMBER(SIGTERM),
-#if FIO_OS_POSIX
-    FIO___SIGNAL_MEMBER(SIGQUIT),
-    FIO___SIGNAL_MEMBER(SIGHUP),
-    FIO___SIGNAL_MEMBER(SIGTRAP),
-    FIO___SIGNAL_MEMBER(SIGBUS),
-    FIO___SIGNAL_MEMBER(SIGFPE),
-    FIO___SIGNAL_MEMBER(SIGUSR1),
-    FIO___SIGNAL_MEMBER(SIGUSR2),
-    FIO___SIGNAL_MEMBER(SIGPIPE),
-    FIO___SIGNAL_MEMBER(SIGALRM),
-    FIO___SIGNAL_MEMBER(SIGCHLD),
-    FIO___SIGNAL_MEMBER(SIGCONT),
-#endif
-  };
-#undef FIO___SIGNAL_MEMBER
-  size_t e = 0;
-  fprintf(stderr, "* testing signal monitoring (setup / cleanup only).\n");
-  for (size_t i = 0; i < sizeof(t) / sizeof(t[0]); ++i) {
-    if (fio_signal_monitor(t[i].sig, NULL, NULL, 1)) {
-      FIO_LOG_ERROR("couldn't set signal monitoring for %s (%d)",
-                    t[i].name,
-                    t[i].sig);
-      e = 1;
-    }
-  }
-  for (size_t i = 0; i < sizeof(t) / sizeof(t[0]); ++i) {
-    if (fio_signal_forget(t[i].sig)) {
-      FIO_LOG_ERROR("couldn't stop signal monitoring for %s (%d)",
-                    t[i].name,
-                    t[i].sig);
-      e = 1;
-    }
-  }
-  FIO_ASSERT(!e, "signal monitoring error");
-}
-
-#endif /* FIO_TEST_ALL */
 /* *****************************************************************************
 Module Cleanup
 ***************************************************************************** */
@@ -19939,12 +19901,16 @@ SFUNC short fio_sock_wait_io(fio_socket_i fd, short events, int timeout) {
 /** Attempts to maximize the allowed open file limits. returns known limit */
 SFUNC size_t fio_sock_maximize_limits(size_t max_limit) {
   ssize_t capa = 0;
+#if FIO_OS_POSIX
   if (!max_limit)
     max_limit = FIO_SOCK_DEFAULT_MAXIMIZE_LIMIT;
-#if FIO_OS_POSIX
 
 #ifdef _SC_OPEN_MAX
-  capa = sysconf(_SC_OPEN_MAX);
+  {
+    const long sys_max = sysconf(_SC_OPEN_MAX);
+    if (sys_max >= 0)
+      capa = (ssize_t)sys_max;
+  }
 #elif defined(FOPEN_MAX)
   capa = FOPEN_MAX;
 #endif
@@ -19976,11 +19942,13 @@ SFUNC size_t fio_sock_maximize_limits(size_t max_limit) {
   getrlimit(RLIMIT_NOFILE, &rlim);
   capa = rlim.rlim_cur;
 #elif FIO_OS_WIN
-  capa = 1ULL << 10;
-  while (_setmaxstdio(capa) > 0)
-    capa <<= 1;
-  capa >>= 1;
-  FIO_LOG_DEBUG("new open file limit: %zd", (ssize_t)capa);
+  if (!max_limit)
+    max_limit = FIO_SOCK_DEFAULT_MAXIMIZE_LIMIT;
+  capa = (ssize_t)max_limit;
+  FIO_LOG_DEBUG2(
+      "Windows has no RLIMIT_NOFILE-equivalent for sockets; using advisory "
+      "per-process cap %zu",
+      max_limit);
 #else
   FIO_LOG_ERROR("No OS detected, couldn't maximize open file limit.");
 #endif
@@ -97116,6 +97084,8 @@ SFUNC void fio_io_start(int workers) {
   if (workers) {
     FIO___IO.to_spawn = workers;
     fio___io_spawn_workers_task(NULL, NULL);
+    FIO_LOG_DEBUG2("(%d) starting facil.io IO reactor in single process mode.",
+                   fio_io_root_pid());
   } else {
     FIO_LOG_DEBUG2("(%d) starting facil.io IO reactor in single process mode.",
                    fio_io_root_pid());
@@ -98984,6 +98954,8 @@ FIO_SFUNC void fio___ipc_listen(void *ignr_) {
         FIO___IPC.ipc_url);
   }
 
+  FIO_LOG_DDEBUG2("(%d) Opening IPC listening socket @ %s", FIO___IPC.ipc_url);
+
   fio_socket_i fd =
       fio_sock_open2(FIO___IPC.ipc_url,
                      FIO_SOCK_SERVER | FIO_SOCK_TCP | FIO_SOCK_NONBLOCK);