Fixed prompter for new nested ELEM arguments on the CALL/PARM on IBM i V7R4+ also updated the settings for case-conversion of the command/parm names

Author: bobcozzi

CHANGELOG.md

@@ -2,6 +2,25 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.0.50] - 2026-02-21
+### Fixed
+- **CALL PARM parameter rendering**: Fixed CALL command PARM parameter only showing first value instead of all values
+  - V7R4+ PARM has nested ELEM structure with Type/Length/Decimal specifications
+  - Added `fieldset.appendChild(elemDiv)` to render nested ELEM sub-elements properly
+  - Fixed CSS layout for nested elements to display on separate lines
+  - Fixed value preservation for unchanged nested ELEM values
+- **Tokenizer bounds checking**: Fixed "invalid string length" runtime error when prompting commands with positional parameters
+  - Added bounds checks (`i < input.length`) to the tokenizeCL.ts file which Prevents infinite loops when reaching end of input string
+### Changed
+- **Settings renamed for clarity**: Renamed case conversion settings to better describe their purpose
+  - `convertToUpperCase` → `convertParmValueToUpperCase`: Only affects &variables, *operators, and %functions in parameters
+  - `formatCase` → `convertCmdAndParmNameCase`: Affects command names and parameter keyword names (CHGVAR/chgvar, VAR/var)
+- **Architecture simplification**: Unified case conversion logic in formatter pipeline
+  - Removed duplicate case conversion from `buildCLCommand()` function
+  - Added case conversion to `formatCLCmd()` unified formatter
+  - Exported `translateCase()` helper function from formatCL.ts
+  - Proper separation: `buildCLCommand` builds raw command, `formatCLCmd` applies formatting
+
 ## [0.0.49] - 2026-02-21
 ### Fixed
 - **Public API: Export correction**: Fixed `activate()` function to properly return API exports for external extensions

media/prompter.js

@@ -2,7 +2,7 @@
   "name": "clprompter",
   "displayName": "Bob Cozzi's CL Prompter for IBM i",
   "description": "Bob Cozzi's CL Prompter for IBM i CL commands",
-  "version": "0.0.49",
+  "version": "0.0.50",
   "author": {
     "name": "Bob Cozzi",
     "url": "https://github.com/bobcozzi"
@@ -104,20 +104,20 @@
           "default": "${tmpdir}",
           "description": "Directory where clPrompt-<cmdName>.html file is written. Use ${tmpdir} for system temp, ${userHome} for home directory, or an absolute path."
         },
-        "clPrompter.convertToUpperCase": {
+        "clPrompter.convertParmValueToUpperCase": {
           "type": "boolean",
           "default": true,
-          "description": "Convert CL variables, operators (*BCAT, *TCAT, etc.), and built-in functions (%SUBST, %TRIM, etc.) to uppercase. When true, text like '&pickles *bcat %trim(x)' becomes '&PICKLES *BCAT %TRIM(x)'. When false, preserves original case. Applies to both the prompter display and final command output."
+          "description": "Convert CL variables, operators (*BCAT, *TCAT, etc.), and built-in functions (%SUBST, %TRIM, etc.) within parameter values to uppercase. When true, text like '&pickles *bcat %trim(x)' becomes '&PICKLES *BCAT %TRIM(x)'. When false, preserves original case. Applies when returning from the prompter."
         },
-        "clPrompter.formatCase": {
+        "clPrompter.convertCmdAndParmNameCase": {
           "type": "string",
           "default": "*UPPER",
           "enum": [
             "*UPPER",
             "*LOWER",
             "*NONE"
           ],
-          "description": "Case conversion for CL source. *UPPER = uppercase, *LOWER = lowercase, *NONE = no change."
+          "description": "Case conversion for CL command names and parameter keywords. *UPPER = uppercase (CHGVAR VAR(...)), *LOWER = lowercase (chgvar var(...)), *NONE = no change. Applies when returning from the prompter and when formatting CL source."
         },
         "clPrompter.formatIndentComments": {
           "type": "string",

media/prompter.js.map

@@ -0,0 +1,49 @@
+// This file can be used to diagnose issues with CALL command parsing
+// To use this, add diagnostic logging to extension.ts to see what XML is actually being received
+
+import { extractParmMetas } from './parseCL';
+
+export function debugCALLCommandXML(xml: string): void {
+  console.log('=== CALL Command XML Diagnostics ===');
+
+  // Extract PARM parameter metas
+  const metas = extractParmMetas(xml);
+  const parmMeta = metas.find(m => m.Kwd === 'PARM');
+
+  if (!parmMeta) {
+    console.log('ERROR: PARM parameter not found in XML');
+    return;
+  }
+
+  console.log('PARM parameter details:');
+  console.log('  Kwd:', parmMeta.Kwd);
+  console.log('  Type:', parmMeta.Type);
+  console.log('  Max:', parmMeta.Max);
+  console.log('  Has Elems:', parmMeta.Elems?.length || 0);
+  console.log('  Has Quals:', parmMeta.Quals?.length || 0);
+
+  if (parmMeta.Elems && parmMeta.Elems.length > 0) {
+    console.log('  Child Elem[0]:');
+    console.log('    Type:', parmMeta.Elems[0].Type);
+    console.log('    MaxLen:', (parmMeta.Elems[0] as any).MaxLen);
+  }
+
+  // Check if Max > 1 (multi-instance)
+  if (parmMeta.Max && parmMeta.Max > 1) {
+    console.log('  ✓ PARM is multi-instance (Max > 1)');
+    console.log('  ✓ Parser will split space-separated values into multiple instances');
+  } else {
+    console.log('  ✗ PARM is NOT multi-instance (Max =', parmMeta.Max, ')');
+    console.log('  ✗ Parser will treat entire value as single instance');
+    console.log('  ✗ This indicates V7R3 or earlier XML structure');
+  }
+
+  // Extract the raw PARM tag from XML
+  const parmTagMatch = xml.match(/<Parm[^>]*\bKwd="PARM"[^>]*>/i);
+  if (parmTagMatch) {
+    console.log('\nRaw PARM tag from XML:');
+    console.log(parmTagMatch[0]);
+  }
+
+  console.log('=== End Diagnostics ===\n');
+}

package.json

@@ -90,7 +90,7 @@ export async function activate(context: vscode.ExtensionContext) {
                 // Get format options from configuration
                 const config = vscode.workspace.getConfiguration('clPrompter');
                 const formatOptions: FormatOptions = {
-                    cvtcase: config.get('formatCase', '*UPPER') as '*UPPER' | '*LOWER' | '*NONE',
+                    cvtcase: config.get('convertCmdAndParmNameCase', '*UPPER') as '*UPPER' | '*LOWER' | '*NONE',
                     indrmks: config.get('formatIndentComments', '*YES') as '*NO' | '*YES',
                     labelpos: config.get('formatLabelPosition', 2),
                     bgncol: config.get('formatCmdPosition', 14),
@@ -141,7 +141,7 @@ export async function activate(context: vscode.ExtensionContext) {
                 // Get format options from configuration
                 const config = vscode.workspace.getConfiguration('clPrompter');
                 const formatOptions: FormatOptions = {
-                    cvtcase: config.get('formatCase', '*UPPER') as '*UPPER' | '*LOWER' | '*NONE',
+                    cvtcase: config.get('convertCmdAndParmNameCase', '*UPPER') as '*UPPER' | '*LOWER' | '*NONE',
                     indrmks: config.get('formatIndentComments', '*YES') as '*NO' | '*YES',
                     labelpos: config.get('formatLabelPosition', 2),
                     bgncol: config.get('formatCmdPosition', 14),
@@ -503,6 +503,11 @@ export class ClPromptPanel {
             try {
                 this._parmMap = parseCLParms(cmdWithKeywords, this._parmMetas);
                 console.log('[clPrompter] parseCLParms keys:', Object.keys(this._parmMap));
+                // Debug PARM specifically for CALL command
+                if (this._parmMap['PARM']) {
+                    console.log('[clPrompter] PARM immediately after parseCLParms:', JSON.stringify(this._parmMap['PARM']));
+                    console.log('[clPrompter] PARM length:', this._parmMap['PARM'].length);
+                }
                 // Debug RMTFILE specifically
                 if (this._parmMap['RMTFILE']) {
                     console.log('[clPrompter] RMTFILE immediately after parseCLParms:', JSON.stringify(this._parmMap['RMTFILE']));
@@ -579,7 +584,7 @@ export class ClPromptPanel {
                 const keywordColor = config.get('kwdColor');
                 const valueColor = config.get('kwdValueColor');
                 const autoAdjust = config.get('kwdColorAutoAdjust');
-                const convertToUpperCase = config.get('convertToUpperCase', true);
+                const convertParmValueToUpperCase = config.get('convertParmValueToUpperCase', true);
 
                 panel.webview.postMessage({
                     type: 'formData',
@@ -590,7 +595,7 @@ export class ClPromptPanel {
                     paramMap: this._parmMap,
                     parmMap: this._parmMap,
                     parmMetas: this._parmMetas,
-                    config: { keywordColor, valueColor, autoAdjust, convertToUpperCase }
+                    config: { keywordColor, valueColor, autoAdjust, convertParmValueToUpperCase }
                 });
                 panel.webview.postMessage({ type: "setLabel", label: cmdLabel, comment: cmdComment });
                 this._sentFormData = true;
@@ -747,9 +752,9 @@ export class ClPromptPanel {
                         const submittedComment = message.values['comment'] as string | undefined;
                         const normalizedComment = submittedComment ? submittedComment.replace(/\r\n|\n|\r/g, ' ') : submittedComment;
 
-                        // Get the convertToUpperCase setting
+                        // Get the case conversion setting for parameter values
                         const config = vscode.workspace.getConfiguration('clPrompter');
-                        const convertToUpperCase = config.get('convertToUpperCase', true);
+                        const convertParmValueToUpperCase = config.get('convertParmValueToUpperCase', true);
 
                         let cmd = buildCLCommand(
                             this._cmdName,
@@ -760,7 +765,7 @@ export class ClPromptPanel {
                             this._parmMetas,
                             this._presentParms,
                             undefined,
-                            convertToUpperCase
+                            convertParmValueToUpperCase
                         );
 
                         // Append comment if present (use normalized comment)