Merge branch 'main' into dependabot/github_actions/actions/download-artifact-4.3.0

Author: bobthecow

src/CodeCleaner/ImplicitReturnPass.php

@@ -80,7 +80,7 @@ private function addImplicitReturn(array $nodes): array
                 'startLine' => $last->getStartLine(),
                 'endLine'   => $last->getEndLine(),
             ]);
-        // @codeCoverageIgnoreEnd
+            // @codeCoverageIgnoreEnd
         } elseif ($last instanceof Expression && !($last->expr instanceof Exit_)) {
             $nodes[\count($nodes) - 1] = new Return_($last->expr, [
                 'startLine' => $last->getStartLine(),

src/Output/ProcOutputPager.php

@@ -56,9 +56,13 @@ public function doWrite($message, $newline): void
         $pipe = $this->getPipe();
         if (false === @\fwrite($pipe, $message.($newline ? \PHP_EOL : ''))) {
             // @codeCoverageIgnoreStart
-            // should never happen
+            // When the message is sufficiently long, writing to the pipe fails
+            // if the pager process is closed before the entire message is read.
+            //
+            // This is a normal condition, so we just close the pipe and return.
             $this->close();
-            throw new \RuntimeException('Unable to write output');
+
+            return;
             // @codeCoverageIgnoreEnd
         }
 

test/fixtures/config.php

@@ -10,7 +10,7 @@
  */
 
 if (!isset($config)) {
-    throw new \Exception('$config not found');
+    throw new Exception('$config not found');
 }
 
 $config->setRuntimeDir(\sys_get_temp_dir().'/psysh_test/withconfig/temp');