Added a workaround to allow ClientHttpHandler to run on JVMs >= 12, albeit without PATCH support (see https://bugs.openjdk.java.net/browse/JDK-8210522)

Author: jshiell

src/com/googlecode/utterlyidle/Java.java

@@ -0,0 +1,11 @@
+package com.googlecode.utterlyidle;
+
+public class Java {
+
+    private Java() {}
+
+    public static int majorVersion() {
+        return Integer.parseInt(System.getProperty("java.version").split("[.-]")[0]);
+    }
+
+}

src/com/googlecode/utterlyidle/handlers/ClientHttpHandler.java

@@ -17,6 +17,7 @@
 import com.googlecode.totallylazy.time.Dates;
 import com.googlecode.utterlyidle.ClientConfiguration;
 import com.googlecode.utterlyidle.Entity;
+import com.googlecode.utterlyidle.Java;
 import com.googlecode.utterlyidle.MediaType;
 import com.googlecode.utterlyidle.Request;
 import com.googlecode.utterlyidle.Response;
@@ -41,6 +42,7 @@
 import java.util.Date;
 
 import static com.googlecode.totallylazy.Closeables.using;
+import static com.googlecode.totallylazy.Debug.debugging;
 import static com.googlecode.totallylazy.Maps.pairs;
 import static com.googlecode.totallylazy.Option.option;
 import static com.googlecode.totallylazy.Pair.pair;
@@ -91,7 +93,13 @@ public static void allowHttpMethods(String... newMethods) {
             String[] combined = sequence(existingMethods).join(sequence(newMethods)).unique().toArray(String.class);
             methods.set(null, combined);
         } catch (Exception e) {
-            throw new RuntimeException(e);
+            if (Java.majorVersion() >= 12) {
+                if (debugging()) {
+                    System.err.println("Failed to modify HttpURLConnection to allow PATCH method - this will not work on JVMs >= 12");
+                }
+            } else {
+                throw new RuntimeException(e);
+            }
         }
     }
 

test/com/googlecode/utterlyidle/handlers/ClientHttpHandlerTest.java

@@ -15,6 +15,7 @@
 import com.googlecode.utterlyidle.HttpHandler;
 import com.googlecode.utterlyidle.HttpHeaders;
 import com.googlecode.utterlyidle.HttpMessage;
+import com.googlecode.utterlyidle.Java;
 import com.googlecode.utterlyidle.Protocol;
 import com.googlecode.utterlyidle.Request;
 import com.googlecode.utterlyidle.Response;
@@ -45,6 +46,7 @@
 import static com.googlecode.totallylazy.functions.Functions.modify;
 import static com.googlecode.totallylazy.io.Uri.uri;
 import static com.googlecode.totallylazy.matchers.NumberMatcher.greaterThan;
+import static com.googlecode.totallylazy.matchers.NumberMatcher.lessThanOrEqualTo;
 import static com.googlecode.utterlyidle.ApplicationBuilder.application;
 import static com.googlecode.utterlyidle.ClientConfiguration.Builder.clientConfiguration;
 import static com.googlecode.utterlyidle.Entities.inputStreamOf;
@@ -64,6 +66,7 @@
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.junit.Assert.fail;
+import static org.junit.Assume.assumeThat;
 
 public class ClientHttpHandlerTest {
     @Test(expected = UnsupportedOperationException.class)
@@ -79,6 +82,8 @@ public void doesNotThrowNullPointerExceptionWhenNoSchema() throws Exception {
 
     @Test
     public void supportsPatch() throws Exception {
+        assumeThat(Java.majorVersion(), lessThanOrEqualTo(11));
+
         Server server = application().addAnnotated(RestTest.PatchContent.class).start();
         Response response = new ClientHttpHandler().handle(patch(server.uri().mergePath("path/bar")).entity("input"));
 
@@ -89,6 +94,8 @@ public void supportsPatch() throws Exception {
 
     @Test
     public void supportsPatchOverHttps() throws Exception {
+        assumeThat(Java.majorVersion(), lessThanOrEqualTo(11));
+
         try (InputStream resource = SecureStringTest.class.getResourceAsStream("localhost.jks");
              SecureString password = secureString('p', 'a', 's', 's', 'w', 'o', 'r', 'd')) {
             SSLContext context = sslContext(keyStore(password, resource), password);