Skip to content

Commit f5b8ab4

Browse files
sahil1105IsaacWarren
authored andcommitted
Fix a bug in CastingGenerator for skipped cols
Fix typo again Fix file name
1 parent af123a4 commit f5b8ab4

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

recipe/patches/0004-Bodo-Changes.patch

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
diff --git a/cpp/src/arrow/dataset/file_parquet.cc b/cpp/src/arrow/dataset/file_parquet.cc
2-
index 1f8b6cc488..586a5122a5 100644
2+
index 1f8b6cc488..6ac6642fdb 100644
33
--- a/cpp/src/arrow/dataset/file_parquet.cc
44
+++ b/cpp/src/arrow/dataset/file_parquet.cc
55
@@ -26,16 +26,23 @@
@@ -55,9 +55,9 @@ index 1f8b6cc488..586a5122a5 100644
5555
+ field_ref.GetOneOrNone(*next));
5656
+ if (column) {
5757
+ if (this->cols_to_skip_.count(field->name())) {
58-
+ out_cols.emplace_back(std::move(column));
5958
+ // Maintain the original input type.
6059
+ out_schema_fields.emplace_back(field->WithType(column->type()));
60+
+ out_cols.emplace_back(std::move(column));
6161
+ continue;
6262
+ }
6363
+ if (!column->type()->Equals(field->type())) {
@@ -69,8 +69,8 @@ index 1f8b6cc488..586a5122a5 100644
6969
+ column = converted.make_array();
7070
+ changed = true;
7171
+ }
72-
+ out_cols.emplace_back(std::move(column));
7372
+ out_schema_fields.emplace_back(field->Copy());
73+
+ out_cols.emplace_back(std::move(column));
7474
+ // XXX Do we need to handle the else case? What happens when the column
7575
+ // doesn't exist, e.g. all null or all the same value?
7676
+ }

0 commit comments

Comments
 (0)