Skip to content

Commit 4206fb8

Browse files
committed
update cran-comments before the new release
1 parent b408e83 commit 4206fb8

File tree

1 file changed

+16
-118
lines changed

1 file changed

+16
-118
lines changed

cran-comments.md

Lines changed: 16 additions & 118 deletions
Original file line numberDiff line numberDiff line change
@@ -1,127 +1,25 @@
11
## Test environments
2-
* Ubuntu 18.04 LTS with gcc 10.1.0
3-
R version 3.6.3
4-
* Ubuntu 18.04 LTS with clang-6.0.0
5-
R devel 2021-02-03 r79933 with ASAN and UBSAN
6-
* Ubuntu 16.04 LTS (on travis-ci)
7-
R version 4.0.0
8-
* win-builder (devel and release)
2+
* Ubuntu 20.04 LTS with gcc 10.1.0
3+
R version 4.1.1
4+
* Ubuntu 20.04 LTS with gcc 10.1.0
5+
R devel 2021-09-06 r80861 with LTO checks
6+
* Ubuntu 20.04 LTS with gcc 10.1.0
7+
R version 4.1.1 with valgrind
8+
* Ubuntu 20.04 LTS with gcc 10.1.0
9+
R devel 2021-09-05 r80859 with ASAN and UBSAN
10+
* Github actions on windows-latest (release), macOS-latest (release),
11+
ubuntu-20.04 (release), and ubuntu-20.04 (devel)
12+
* win-builder (devel, oldrelease, and release)
913
* `rhub::check_for_cran()`
10-
* `rhub::check(platform = c("debian-gcc-devel", "debian-clang-devel", "fedora-clang-devel", "fedora-clang-devel"))`
14+
* `rhub::check(platform = c("fedora-clang-devel", "macos-highsierra-release-cran"))`
1115

1216
## R CMD check results
13-
The issue with the test which caused the package to be removed from CRAN has
14-
been fixed.
15-
1617
There were no WARNINGs or ERRORs.
1718

1819
There is a NOTE about the package size in some cases.
1920

20-
## Resubmission
21-
This is a resubmission. I have addressed the issues stated below.
22-
23-
> Please write TRUE and FALSE instead of T and F. (Please don't use 'T' or
24-
> 'F' as vector names.)
25-
26-
T and F is no longer used. Instead TRUE and FALSE is used. Also, T and F
27-
are no longer used for vector names.
28-
29-
> Please add \value to .Rd files regarding exported methods and explain
30-
> the functions results in the documentation. Please write about the
31-
> structure of the output (class) and also what the output means. (If a
32-
> function does not return a value, please document that too, e.g.
33-
> \value{No return value, called for side effects} or similar)
34-
> Missing Rd-tags:
35-
> ddFixed.Rd: \value
36-
> ddhazard_app.Rd: \value
37-
> logLik.ddhazard.Rd: \value
38-
> plot.ddhazard_space_errors.Rd: \value
39-
> plot.ddhazard.Rd: \value
40-
> predict.ddhazard.Rd: \value
41-
> print.ddhazard_boot.Rd: \value
42-
> residuals.ddhazard.Rd: \value
43-
44-
There is a \value section for all of the above now.
45-
46-
> \dontrun{} should only be used if the example really cannot be executed
47-
> (e.g. because of missing additional software, missing API keys, ...) by
48-
> the user. That's why wrapping examples in \dontrun{} adds the comment
49-
> ("# Not run:") as a warning for the user.
50-
> Does not seem necessary in every case.
51-
>
52-
> Please unwrap the examples if they are executable in < 5 sec, or replace
53-
> \dontrun{} with \donttest{}.
54-
55-
\donttest is used instead of \dontrun. The exception is `ddhazard_app` where
56-
the example launches a Shiny app. Thus, `R CMD CHECK` runs forever on Github
57-
actions and with rhub if this example is in \donttest.
58-
59-
> You are setting options(warn=-1) in your function. This is not allowed.
60-
> Please rather use suppressWarnings() if really needed.
61-
62-
I removed options(warn=-1).
63-
64-
> Please make sure that you do not change the user's options, par or
65-
> working directory. If you really have to do so within functions, please
66-
> ensure with an *immediate* call of on.exit() that the settings are reset
67-
> when the function is exited. e.g.:
68-
> ...
69-
> oldpar <- par(no.readonly = TRUE) # code line i
70-
> on.exit(par(oldpar)) # code line i + 1
71-
> ...
72-
> par(mfrow=c(2,2)) # somewhere after
73-
> ...
74-
>
75-
> e.g.: inst/doc.. files
76-
77-
Par is always reset now (also in the vignettes).
78-
79-
> Please always make sure to reset to user's options(), working directory
80-
> or par() after you changed it in examples and vignettes and demos.
81-
> e.g.: ddsurvcurve.Rd
82-
> oldpar <- par(mfrow = c(1,2))
83-
> ...
84-
> par(oldpar)
85-
>
86-
> old <- options(digits = 3)
87-
> ...
88-
> options(old)
89-
90-
Options are always reset now.
91-
92-
> Please do not modify the .GlobalEnv. This is not allowed by the CRAN
93-
> policies.
94-
95-
I have discussed this before with a submission of my SimSurvNMarker package to
96-
CRAN . I do like `getS3method("simulate", "lm")` (set the random seed in a
97-
similar way).
98-
99-
Gregor Seyer wrote the following on the 4th of September 2020:
100-
101-
> Thanks for the explanation.
102-
> In this case it should not be a problem.
103-
104-
> Please do not modify the global environment (e.g. by using <<-) in your
105-
> functions. This is not allowed by the CRAN policies.
106-
107-
There are no ways that there will be assignments to the global environment with
108-
<<- as far as I can see except for an assignment of `.Random.seed` in a test
109-
that is not run on CRAN.
110-
111-
> Please ensure that you do not use more than 2 cores in your examples,
112-
> vignettes, etc.
113-
114-
There should not be used more than 2 cores anywhere.
115-
116-
> Additionally:
117-
> Have the issues why your package was archived been fixed?
118-
> Please explain this in the submission comments.
119-
120-
Yes, as I wrote in my last submission:
121-
122-
> The issue with the test which caused the package to be removed from CRAN has
123-
> been fixed.
21+
There is a NOTE about a 404 error for one of the DOIs in the description. This
22+
is for a Journal of Statistical Software paper that will be published soon.
23+
The paper is the reason for this update.
12424

125-
There has been changes in speedglm which seems to have caused a bug with the
126-
weights argument when speedglm::speedglm is called in a function. I found a
127-
workaround and thus submitted a new version of my package.
25+
There is NOTE that Christoffersen is possibly misspelled. It is not.

0 commit comments

Comments
 (0)