Skip to content

Commit a58f91d

Browse files
committed
update cran-comments
change name og test reference file
1 parent 65cb02a commit a58f91d

File tree

3 files changed

+9
-15
lines changed

3 files changed

+9
-15
lines changed

cran-comments.md

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,21 @@
11
## Test environments
2-
* Platform: x86_64-w64-mingw32/x64 (64-bit)
3-
Running under: Windows >= 8 x64 (build 9200)
4-
R version 3.5.0
2+
* Ubuntu 18.04 LTS
3+
R version 3.5.2
54
* Ubuntu 14.04.5 LTS (on travis-ci with codename: trusty)
6-
R version 3.5.1
5+
R version 3.5.2
76
* win-builder (devel and release)
8-
* Local Ubuntu 17.04 (64-bit) with R devel and with clang 6.0.0 with ASAN and
7+
* Local Ubuntu 18.04 with R 3.5.2 and with clang 6.0.0 with ASAN and
98
UBSAN checks
109
* The following rhub platforms:
11-
debian-gcc-devel
1210
fedora-clang-devel
1311
fedora-gcc-devel
1412
debian-gcc-patched
13+
debian-gcc-devel
1514
debian-gcc-release
1615
linux-x86_64-rocker-gcc-san
1716

1817
I use the build with codename trusty for the GCC 4.8.4 which has C++11 support.
1918

20-
I am sorry for submitting so shortly after my previous release. I found two
21-
major bugs in a new feature I have added. I hope you will accept this
22-
submission and I understand if you do not.
23-
24-
I have seen the Solaris issue and I think I have fixed it. I do not have access
25-
to a Solaris machine and the `solaris-x86-patched` platform on rhub fails with
26-
"Build timed out".
27-
2819
## R CMD check results
2920
All platforms have a note about the package size except the win-builder with
3021
the devel version.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
Predicted survival curve from call:
2+
ddsurvcurve(object = h1, new_data = data.frame(group = factor(2,
3+
levels = 1:2)))

tests/testthat/test_print.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,5 +135,5 @@ test_that("print print.ddsurvcurve gives correct result", {
135135
ddcurve <- ddsurvcurve(h1, new_data = data.frame(
136136
group = factor(2, levels = 1:2)))
137137

138-
expect_known_output(ddcurve, file = "print-ddsurvcurve.txt", print = TRUE)
138+
expect_known_output(ddcurve, file = "print-ddsurvcurve", print = TRUE)
139139
})

0 commit comments

Comments
 (0)