Add error handling for missing column/filter in before/after options

- Raise `Datagrid::ConfigurationError` when a column or filter name specified in the `before` or `after` option is not found.
- Update `Datagrid::Utils.extract_position_from_options` to handle cases where the specified column/filter does not exist.
- Add tests to ensure proper error handling and functionality for `before` and `after` options in both columns and filters.

Author: bogdan

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+* Raise `Datagrid::ConfigurationError` when column or filter name 
+  specified in `before` or `after` option not found.
+
 ## [2.0.6]
 
 * Validate dummy filter can not accept block

lib/datagrid/columns.rb

@@ -378,6 +378,9 @@ def define_column(columns, name, query = nil, **options, &block)
         end
 
         position = Datagrid::Utils.extract_position_from_options(columns, options)
+        unless position
+          raise Datagrid::ConfigurationError, "#{self}##{options[:before] || options[:after]} column not found"
+        end
         column = Datagrid::Columns::Column.new(
           self, name, query, options, &block
         )

lib/datagrid/filters.rb

@@ -244,6 +244,9 @@ def filter(name, type = :default, **options, &block)
         raise ConfigurationError, "filter class #{type.inspect} not found" unless klass
 
         position = Datagrid::Utils.extract_position_from_options(filters_array, options)
+        unless position
+          raise Datagrid::ConfigurationError, "#{self}##{options[:before] || options[:after]} filter not found"
+        end
         filter = klass.new(self, name, **options, &block)
         filters_array.insert(position, filter)
 

lib/datagrid/utils.rb

@@ -68,7 +68,9 @@ def extract_position_from_options(array, options)
           array.index { |c| c.name.to_sym == before }
         elsif after
           after = after.to_sym
-          array.index { |c| c.name.to_sym == after } + 1
+          if index = array.index { |c| c.name.to_sym == after }
+            index + 1
+          end
         else
           -1
         end

spec/datagrid/columns_spec.rb

@@ -267,13 +267,43 @@ def show?
     end.to raise_error(Datagrid::ConfigurationError)
   end
 
-  it "raises when :before and :after used together" do
-    expect do
-      test_grid do
+  describe "before and after options" do
+
+    it "can't be used together" do
+      expect do
+        test_grid do
+          scope { Entry }
+          column(:id)
+          column(:name, before: :id, after: :name)
+        end
+      end.to raise_error(Datagrid::ConfigurationError)
+    end
+
+    it "used to control columns order" do
+      grid = test_grid do
+        scope { Entry }
         column(:id)
-        column(:name, before: :id, after: :name)
+        column(:name, before: :id)
+        column(:group, after: :name)
       end
-    end.to raise_error(Datagrid::ConfigurationError)
+
+      expect(grid.columns.map(&:name)).to eq([:name, :group, :id])
+    end
+
+    it "raises exception when column not found" do
+      expect do
+        test_grid do
+          scope { Entry }
+          column(:name, before: :id)
+        end
+      end.to raise_error(Datagrid::ConfigurationError)
+      expect do
+        test_grid do
+          scope { Entry }
+          column(:name, after: :id)
+        end
+      end.to raise_error(Datagrid::ConfigurationError)
+    end
   end
 
   describe ".column_names attributes" do

spec/datagrid/filters_spec.rb

@@ -112,7 +112,7 @@ def check_performed(value, result, **options)
     end
   end
 
-  describe "positioning filter before another" do
+  describe "positioning filter" do
     it "inserts the filter before the specified element" do
       grid = test_grid do
         scope { Entry }
@@ -121,9 +121,7 @@ def check_performed(value, result, **options)
       end
       expect(grid.filters.index { |f| f.name == :name }).to eq(0)
     end
-  end
 
-  describe "positioning filter after another" do
     it "inserts the filter before the specified element" do
       grid = test_grid do
         scope { Entry }
@@ -133,6 +131,21 @@ def check_performed(value, result, **options)
       end
       expect(grid.filters.index { |f| f.name == :group_id }).to eq(1)
     end
+
+    it "raises if filter not found" do
+      expect do
+        test_grid do
+          scope { Entry }
+          filter(:name, before: :id)
+        end
+      end.to raise_error(Datagrid::ConfigurationError)
+      expect do
+        test_grid do
+          scope { Entry }
+          filter(:name, after: :id)
+        end
+      end.to raise_error(Datagrid::ConfigurationError)
+    end
   end
 
   describe "#filter_by" do