Remove outdated tests

Author: bogdan

lib/datagrid/form_builder.rb

@@ -47,7 +47,7 @@ def datagrid_label(filter_or_attribute, text = nil, **options, &block)
     #   * `type` - special attribute the determines an input tag to be made.
     #     Examples: `text`, `select`, `textarea`, `number`, `date` etc.
     # @return [String] an input tag for the corresponding filter name
-    def datagrid_filter_input(attribute_or_filter, **options, &block)
+    def datagrid_filter_input(attribute_or_filter, select_choices: nil, select_options: nil, **options, &block)
       filter = datagrid_get_filter(attribute_or_filter)
       options = add_filter_options(filter, **options)
       type = options.delete(:type)&.to_sym
@@ -73,12 +73,12 @@ def datagrid_filter_input(attribute_or_filter, **options, &block)
       when :select
         select(
           filter.name,
-          options.delete(:select_choices) || object.select_choices(filter) || [],
+          select_choices || object.select_choices(filter) || [],
           {
             include_blank: filter.include_blank,
             prompt: filter.prompt,
             include_hidden: false,
-            **options.delete(:select_options),
+            **select_options,
           },
           multiple: filter.multiple?,
           **options,
@@ -157,6 +157,7 @@ def datagrid_dynamic_field_options(options:, field:, filter:)
       options.merge(
         {
           type: :select,
+          select_choices: object.select_choices(filter),
           select_options: {
             selected: field,
           },

spec/datagrid/form_builder_spec.rb

@@ -783,33 +783,6 @@ class MyTemplate
 
         it { is_expected.to equal_to_dom(expected_html) }
       end
-
-      context "when the field is predefined" do
-        let(:filter_options) do
-          { operations: %w[>= <=], select: [:id] }
-        end
-        let(:expected_html) do
-          <<-HTML
-          <input class="datagrid-dynamic-field" name="report[condition][field]" value="id" autocomplete="off" type="hidden" id="report_condition"><select class="datagrid-dynamic-operation" name="report[condition][operation]" id="report_condition"><option value="&gt;=">≥</option>
-       <option value="&lt;=">≤</option></select><input class="datagrid-dynamic-value" name="report[condition][value]" type="text" id="report_condition">
-          HTML
-        end
-
-        it { is_expected.to equal_to_dom(expected_html) }
-      end
-
-      context "when operation is predefined" do
-        let(:filter_options) do
-          { operations: %w[=], select: %i[id name] }
-        end
-        let(:expected_html) do
-          <<-HTML
-          <select class="datagrid-dynamic-field" name="report[condition][field]" id="report_condition"><option value="id">id</option><option value="name">name</option></select><input class="datagrid-dynamic-operation" name="report[condition][operation]" value="=" autocomplete="off" type="hidden" id="report_condition"><input class="datagrid-dynamic-value" name="report[condition][value]" type="text" id="report_condition">
-          HTML
-        end
-
-        it { is_expected.to equal_to_dom(expected_html) }
-      end
     end
   end