Skip to content

Commit 090e344

Browse files
authored
Update after serialization redesign (#156)
* Update after serialization redesign * Use nodejs 16.x in CI
1 parent 70ed247 commit 090e344

File tree

2 files changed

+9
-52
lines changed

2 files changed

+9
-52
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
- name: Install node
1616
uses: actions/setup-node@v1
1717
with:
18-
node-version: '12.x'
18+
node-version: '16.x'
1919
- name: Install Python
2020
uses: actions/setup-python@v2
2121
with:
@@ -41,7 +41,7 @@ jobs:
4141
key: yarn-${{ hashFiles('**/yarn.lock') }}
4242
restore-keys: |
4343
yarn-
44-
44+
4545
- name: Install dependencies
4646
run: python -m pip install -U jupyterlab~=3.0 jupyter_packaging~=0.7.9
4747
- name: Build the extension

src/widgets.ts

Lines changed: 7 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ type DocumentChangedEvent = any
1717
type Receiver = any
1818
type Fragment = any
1919

20-
const { keys, values } = Object as any
20+
const { keys, values } = Object
2121

2222
const version_range = `^${version}`
2323

@@ -38,8 +38,6 @@ export interface ModelChanged extends DocumentChanged {
3838
id: string
3939
new: unknown
4040
attr: string
41-
old: unknown
42-
hint: unknown
4341
}
4442

4543
export interface MessageSent extends DocumentChanged {
@@ -56,7 +54,7 @@ export interface MessageSent extends DocumentChanged {
5654
}
5755

5856
export class BokehModel extends DOMWidgetModel {
59-
defaults() {
57+
defaults(): any {
6058
return {
6159
...super.defaults(),
6260

@@ -200,52 +198,11 @@ export class BokehView extends DOMWidgetView {
200198
if (this._blocked) {
201199
return
202200
}
203-
const { ModelChangedEvent, MessageSentEvent } = bk_require(
204-
'document/events'
205-
)
206-
if (event instanceof ModelChangedEvent) {
207-
const js_msg: ModelChanged = {
208-
event: 'jsevent',
209-
kind: 'ModelChanged',
210-
id: event.model.id,
211-
attr: event.attr,
212-
new: event.new_,
213-
old: event.old,
214-
hint: null
215-
}
216-
if (event.hint != null) {
217-
if (event.hint.patches != null) {
218-
js_msg['hint'] = {
219-
column_source: event.hint.column_source,
220-
patches: event.hint.patches
221-
}
222-
} else if (event.hint.data != null) {
223-
js_msg['hint'] = {
224-
column_source: event.hint.column_source,
225-
data: event.hint.data,
226-
rollover: event.hint.rollover
227-
}
228-
}
229-
}
230-
this._send(js_msg)
231-
} else if (
232-
event instanceof MessageSentEvent &&
233-
event.msg_type == 'bokeh_event'
234-
) {
235-
const msg_data = { ...event.msg_data }
236-
const event_values = { ...msg_data.event_values }
237-
if (event_values.model != null) {
238-
event_values['model'] = { id: event_values.model.id }
239-
}
240-
msg_data['event_values'] = event_values
241-
const js_msg: MessageSent = {
242-
event: 'jsevent',
243-
kind: 'MessageSent',
244-
msg_type: event.msg_type,
245-
msg_data: msg_data
246-
}
247-
this._send(js_msg)
248-
}
201+
const { Serializer } = bk_require('core/serialization')
202+
const serializer = new Serializer()
203+
const event_rep = serializer.encode(event)
204+
event_rep.event = 'jsevent'
205+
this._send(event_rep)
249206
}
250207

251208
protected _consume_patch(

0 commit comments

Comments
 (0)