Fix linting

Author: philippjfr

.eslintrc.js

@@ -13,7 +13,7 @@ module.exports = {
   plugins: ['@typescript-eslint'],
   rules: {
     '@typescript-eslint/naming-convention': [
-      'error',
+      'warn',
       {
         'selector': 'interface',
         'format': ['PascalCase'],
@@ -33,7 +33,8 @@ module.exports = {
       { avoidEscape: true, allowTemplateLiterals: false }
     ],
     curly: ['error', 'all'],
-    eqeqeq: 'error',
+    semi: ['warn', 'never'],
+    eqeqeq: 'warn',
     'prefer-arrow-callback': 'error'
   }
 };

.prettierignore

@@ -3,3 +3,4 @@ node_modules
 **/lib
 **/package.json
 jupyter_bokeh
+src/extension.ts

.prettierrc

@@ -1,5 +1,6 @@
 {
   "singleQuote": true,
   "trailingComma": "none",
-  "arrowParens": "avoid"
+  "arrowParens": "avoid",
+  "semi": false
 }

src/index.ts

@@ -1,4 +1,4 @@
-import {extension} from "./plugin"
+import { extension } from './plugin'
 export default extension
 
-export * from "./widgets"
+export * from './widgets'

src/manager.ts

@@ -1,5 +1,5 @@
-import {IDisposable} from "@lumino/disposable"
-import {DocumentRegistry} from "@jupyterlab/docregistry"
+import { IDisposable } from '@lumino/disposable'
+import { DocumentRegistry } from '@jupyterlab/docregistry'
 
 /**
  * A micro manager that contains the document context
@@ -16,19 +16,21 @@ export class ContextManager implements IDisposable {
   }
 
   get context(): Context {
-    if (this._context != null)
+    if (this._context != null) {
       return this._context
-    else
-      throw new Error("context was already disposed")
+    } else {
+      throw new Error('context was already disposed')
+    }
   }
 
   get isDisposed(): boolean {
     return this._context == null
   }
 
   dispose(): void {
-    if (this.isDisposed)
+    if (this.isDisposed) {
       return
+    }
     this._context = null
   }
 }

src/plugin.ts

@@ -1,35 +1,48 @@
-import {DocumentRegistry} from "@jupyterlab/docregistry"
-import {INotebookModel, NotebookPanel} from "@jupyterlab/notebook"
-import {JupyterFrontEndPlugin, JupyterFrontEnd} from "@jupyterlab/application"
-import {IJupyterWidgetRegistry} from "@jupyter-widgets/base"
-import {IDisposable, DisposableDelegate} from "@lumino/disposable"
+import { DocumentRegistry } from '@jupyterlab/docregistry'
+import { INotebookModel, NotebookPanel } from '@jupyterlab/notebook'
+import { JupyterFrontEndPlugin, JupyterFrontEnd } from '@jupyterlab/application'
+import { IJupyterWidgetRegistry } from '@jupyter-widgets/base'
+import { IDisposable, DisposableDelegate } from '@lumino/disposable'
 
-import {ContextManager} from "./manager"
+import { ContextManager } from './manager'
 import {
   BokehJSExec,
   BokehJSLoad,
   BOKEHJS_EXEC_MIME_TYPE,
-  BOKEHJS_LOAD_MIME_TYPE} from "./renderer"
+  BOKEHJS_LOAD_MIME_TYPE
+} from './renderer'
 
-export type INBWidgetExtension = DocumentRegistry.IWidgetExtension<NotebookPanel, INotebookModel>
+export type INBWidgetExtension = DocumentRegistry.IWidgetExtension<
+  NotebookPanel,
+  INotebookModel
+>
 
 export class NBWidgetExtension implements INBWidgetExtension {
-  createNew(nb: NotebookPanel, context: DocumentRegistry.IContext<INotebookModel>): IDisposable {
+  createNew(
+    nb: NotebookPanel,
+    context: DocumentRegistry.IContext<INotebookModel>
+  ): IDisposable {
     const manager = new ContextManager(context)
 
-    nb.content.rendermime.addFactory({
-      safe: false,
-      mimeTypes: [BOKEHJS_LOAD_MIME_TYPE],
-      createRenderer: (options) => new BokehJSLoad(options),
-    }, 0)
+    nb.content.rendermime.addFactory(
+      {
+        safe: false,
+        mimeTypes: [BOKEHJS_LOAD_MIME_TYPE],
+        createRenderer: options => new BokehJSLoad(options)
+      },
+      0
+    )
 
     // the rank has to be -1, so that the priority is higher than the
     // default javascript mime extension (rank=0)
-    nb.content.rendermime.addFactory({
-      safe: false,
-      mimeTypes: [BOKEHJS_EXEC_MIME_TYPE],
-      createRenderer: (options) => new BokehJSExec(options, manager),
-    }, -1)
+    nb.content.rendermime.addFactory(
+      {
+        safe: false,
+        mimeTypes: [BOKEHJS_EXEC_MIME_TYPE],
+        createRenderer: options => new BokehJSExec(options, manager)
+      },
+      -1
+    )
 
     return new DisposableDelegate(() => {
       if (nb.content.rendermime) {
@@ -40,24 +53,24 @@ export class NBWidgetExtension implements INBWidgetExtension {
   }
 }
 
-import {name, version} from "./metadata"
-import {BokehModel, BokehView} from "./widgets"
+import { name, version } from './metadata'
+import { BokehModel, BokehView } from './widgets'
 
 export const extension: JupyterFrontEndPlugin<void> = {
   id: name,
   requires: [IJupyterWidgetRegistry],
   activate: (app: JupyterFrontEnd, widgets: IJupyterWidgetRegistry) => {
     // this adds the Bokeh widget extension onto Notebooks specifically
-    app.docRegistry.addWidgetExtension("Notebook", new NBWidgetExtension())
+    app.docRegistry.addWidgetExtension('Notebook', new NBWidgetExtension())
 
     widgets.registerWidget({
       name,
       version,
       exports: {
         BokehModel: BokehModel as any,
-        BokehView: BokehView as any,
-      },
+        BokehView: BokehView as any
+      }
     })
   },
-  autoStart: true,
+  autoStart: true
 }

src/renderer.ts

@@ -1,17 +1,20 @@
-import {IRenderMime} from "@jupyterlab/rendermime-interfaces"
-import {KernelMessage, Kernel} from "@jupyterlab/services"
-import {ReadonlyJSONObject} from "@lumino/coreutils"
-import {Widget} from "@lumino/widgets"
-import {ContextManager} from "./manager"
+import { IRenderMime } from '@jupyterlab/rendermime-interfaces'
+import { KernelMessage, Kernel } from '@jupyterlab/services'
+import { ReadonlyJSONObject } from '@lumino/coreutils'
+import { Widget } from '@lumino/widgets'
+import { ContextManager } from './manager'
 
 export declare interface KernelProxy {
   // copied from https://github.com/jupyterlab/jupyterlab/blob/master/packages/services/src/kernel/default.ts#L605
-  registerCommTarget(targetName: string, callback: (comm: Kernel.IComm, msg: KernelMessage.ICommOpenMsg) => void): void
+  registerCommTarget(
+    targetName: string,
+    callback: (comm: Kernel.IComm, msg: KernelMessage.ICommOpenMsg) => void
+  ): void
 }
 
 declare const Bokeh: any
 
-function poll(fn: () => boolean, wait: number = 1000, interval: number = 100): Promise<void> {
+function poll(fn: () => boolean, wait = 1000, interval = 100): Promise<void> {
   return new Promise((resolve, reject) => {
     if (fn()) {
       resolve()
@@ -24,7 +27,7 @@ function poll(fn: () => boolean, wait: number = 1000, interval: number = 100): P
         wait -= interval
         if (wait <= 0) {
           clearInterval(id)
-          reject(new Error("timeout"))
+          reject(new Error('timeout'))
         }
       }, interval)
     }
@@ -34,10 +37,10 @@ function poll(fn: () => boolean, wait: number = 1000, interval: number = 100): P
 /**
  * The MIME types for BokehJS.
  */
-const HTML_MIME_TYPE = "text/html"
-const JS_MIME_TYPE = "application/javascript"
-export const BOKEHJS_LOAD_MIME_TYPE = "application/vnd.bokehjs_load.v0+json"
-export const BOKEHJS_EXEC_MIME_TYPE = "application/vnd.bokehjs_exec.v0+json"
+const HTML_MIME_TYPE = 'text/html'
+const JS_MIME_TYPE = 'application/javascript'
+export const BOKEHJS_LOAD_MIME_TYPE = 'application/vnd.bokehjs_load.v0+json'
+export const BOKEHJS_EXEC_MIME_TYPE = 'application/vnd.bokehjs_exec.v0+json'
 
 /**
  * Load BokehJS and CSS into the DOM
@@ -48,7 +51,7 @@ export class BokehJSLoad extends Widget implements IRenderMime.IRenderer {
 
   constructor(_options: IRenderMime.IRendererOptions) {
     super()
-    this._script_element = document.createElement("script")
+    this._script_element = document.createElement('script')
   }
 
   renderModel(model: IRenderMime.IMimeModel): Promise<void> {
@@ -76,7 +79,7 @@ export class BokehJSExec extends Widget implements IRenderMime.IRenderer {
 
   constructor(_options: IRenderMime.IRendererOptions, manager: ContextManager) {
     super()
-    this._script_element = document.createElement("script")
+    this._script_element = document.createElement('script')
     this._manager = manager
   }
 
@@ -87,31 +90,38 @@ export class BokehJSExec extends Widget implements IRenderMime.IRenderer {
       // I'm a static document
       const data = model.data[this._js_mimetype] as string
       this._script_element.textContent = data
-      await poll(() => typeof Bokeh !== "undefined")
+      await poll(() => typeof Bokeh !== 'undefined')
       this._document_id = metadata.id as string
-      const {_manager} = this
+      const { _manager } = this
       const kernel_proxy: KernelProxy = {
         registerCommTarget(targetName, callback) {
           const kernel = _manager!.context.sessionContext.session?.kernel
-          if (kernel != null)
+          if (kernel != null) {
             kernel.registerCommTarget(targetName, callback)
-        },
+          }
+        }
       }
       Bokeh.embed.kernels[this._document_id] = kernel_proxy
-      _manager!.context.sessionContext.statusChanged.connect((_session, status) => {
-        if (status == "restarting" || status === "dead") {
-          delete Bokeh.embed.kernels[this._document_id!]
-        }
-      }, this)
+      _manager!.context.sessionContext.statusChanged.connect(
+        (_session, status) => {
+          if (status == 'restarting' || status === 'dead') {
+            delete Bokeh.embed.kernels[this._document_id!]
+          }
+        },
+        this
+      )
     } else if (metadata.server_id !== undefined) {
       // I'm a server document
       this._server_id = metadata.server_id as string
       const data = model.data[this._html_mimetype] as string
-      const d = document.createElement("div")
+      const d = document.createElement('div')
       d.innerHTML = data
       const script_attrs: NamedNodeMap = d.children[0].attributes
       for (const i in script_attrs) {
-        this._script_element.setAttribute(script_attrs[i].name, script_attrs[i].value)
+        this._script_element.setAttribute(
+          script_attrs[i].name,
+          script_attrs[i].value
+        )
       }
       this._script_element.textContent = d.textContent
     }
@@ -120,18 +130,20 @@ export class BokehJSExec extends Widget implements IRenderMime.IRenderer {
   }
 
   dispose(): void {
-    if (this.isDisposed)
+    if (this.isDisposed) {
       return
+    }
 
-    super.dispose();
+    super.dispose()
 
     if (this._server_id) {
-      const content: KernelMessage.IExecuteRequestMsg["content"] = {
-        code: `import bokeh.io.notebook as ion; ion.destroy_server("${this._server_id}")`,
+      const content: KernelMessage.IExecuteRequestMsg['content'] = {
+        code: `import bokeh.io.notebook as ion; ion.destroy_server("${this._server_id}")`
       }
       const kernel = this._manager!.context.sessionContext.session?.kernel
-      if (kernel != null)
+      if (kernel != null) {
         kernel.requestExecute(content, true)
+      }
       this._server_id = null
     } else if (this._document_id) {
       if (Bokeh.embed.kernels !== undefined) {