Initialize _events property #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
approved these changes
Feb 26, 2025
Contributor
philippjfr
left a comment
philippjfr
left a comment
There was a problem hiding this comment.
Thanks for tracking this down. Would be nice if we had some integration tests here.
Contributor
|
(To be clear I'm not asking you to add those) |
Member
|
@philippjfr do you want to merge this as-is with a follow-up issue for more tests, or do you want to wait for someone to add tests to this branch? |
mattpap
approved these changes
Mar 10, 2025
Contributor
mattpap
left a comment
mattpap
left a comment
There was a problem hiding this comment.
Logically makes sense. Regression tests would be good to have.
Contributor
|
@tfehlmann, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_eventsproperty is currently uninitialized which results in a runtime error in the_consume_patchfunction.