Merge pull request #7 from janek2012/scalar-argument-fix

Added checking if provided arguments are objects

Author: mariusz-bak-xsolve-pl

ModelFactoryCollection/ModelFactoryCollection.php

@@ -73,9 +73,16 @@ public function createModels($objects)
         foreach ($objects as $key => $object) {
             $modelFactory = $this->findSupportingModelFactoryForObject($object);
             if (!$modelFactory instanceof ModelFactoryInterface) {
+                if (is_object($object)) {
+                    throw new ModelFactoryCollectionException(sprintf(
+                        'Model factory for class %s not found.',
+                        get_class($object)
+                    ));
+                }
+                
                 throw new ModelFactoryCollectionException(sprintf(
-                    "Model factory for class '%s' not found.",
-                    get_class($object)
+                    'Model factory for type %s not found.',
+                    gettype($object)
                 ));
             }
             $models[$key] = $this->createModelAndSetDependencies($modelFactory, $object);

Tests/Functional/ModelFactoryCollectionTest.php

@@ -167,6 +167,7 @@ public function dataProvider_supportsObjects_onInvalidArgument()
             [3],
             [false],
             [new stdClass()],
+            [null],
         ];
     }
 
@@ -186,7 +187,7 @@ public function test_createModels_onInvalidArgument($invalidArgument)
                 new BarModelFactory()
             );
 
-        $modelFactoryCollection->createModels($invalidArgument);
+        $modelFactoryCollection->createModels([$invalidArgument]);
     }
 
     /**