Skip to content

Commit e543ca6

Browse files
authored
[mlir][vector][nfc] Add comments in tests (llvm#160106)
Small follow-up for llvm#158528, otherwise it's not clear what makes the updated tests "negative".
1 parent 718ef34 commit e543ca6

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

mlir/test/Dialect/Vector/canonicalize.mlir

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3377,6 +3377,9 @@ func.func @negative_from_elements_to_constant() -> vector<1x!llvm.ptr> {
33773377

33783378
// -----
33793379

3380+
// `foldFromElementsToConstant` does not support `ub.poison`, so it bails out.
3381+
// Instead, other folders apply here (e.g. `rewriteFromElementsAsBroadcast`).
3382+
33803383
// CHECK-LABEL: @negative_from_elements_poison
33813384
// CHECK: %[[VAL:.*]] = ub.poison : vector<2xf32>
33823385
// CHECK: return %[[VAL]] : vector<2xf32>
@@ -3388,6 +3391,9 @@ func.func @negative_from_elements_poison_f32() -> vector<2xf32> {
33883391

33893392
// -----
33903393

3394+
// `foldFromElementsToConstant` does not support `ub.poison`, so it bails out.
3395+
// Instead, other folders apply here (e.g. `rewriteFromElementsAsBroadcast`).
3396+
33913397
// CHECK-LABEL: @negative_from_elements_poison_i32
33923398
// CHECK: %[[VAL:.*]] = ub.poison : vector<2xi32>
33933399
// CHECK: return %[[VAL]] : vector<2xi32>
@@ -3399,6 +3405,9 @@ func.func @negative_from_elements_poison_i32() -> vector<2xi32> {
33993405

34003406
// -----
34013407

3408+
// `foldFromElementsToConstant` does not support `ub.poison`, so it bails out.
3409+
// Instead, other folders apply here (e.g. `rewriteFromElementsAsBroadcast`).
3410+
34023411
// CHECK-LABEL: @negative_from_elements_poison_constant_mix
34033412
// CHECK: %[[POISON:.*]] = ub.poison : f32
34043413
// CHECK: %[[CONST:.*]] = arith.constant 1.000000e+00 : f32

0 commit comments

Comments
 (0)