fix lint and address review comment

Author: bomanaps

apps/mcp-server/src/config/env-loader.ts

@@ -86,7 +86,9 @@ export class EnvLoader {
       if (validLevels.includes(env.LOG_LEVEL)) {
         config.logLevel = env.LOG_LEVEL as any;
       } else {
-        process.stderr.write(`Warning: Invalid LOG_LEVEL: ${env.LOG_LEVEL}. Using default 'info'.\n`);
+        process.stderr.write(
+          `Warning: Invalid LOG_LEVEL: ${env.LOG_LEVEL}. Using default 'info'.\n`,
+        );
       }
     }
 
@@ -96,7 +98,9 @@ export class EnvLoader {
       if (!isNaN(size) && size > 0) {
         config.maxStorageSize = size;
       } else {
-        process.stderr.write(`Warning: Invalid MAX_STORAGE_SIZE: ${env.MAX_STORAGE_SIZE}. Using default.\n`);
+        process.stderr.write(
+          `Warning: Invalid MAX_STORAGE_SIZE: ${env.MAX_STORAGE_SIZE}. Using default.\n`,
+        );
       }
     }
 
@@ -110,7 +114,9 @@ export class EnvLoader {
       if (!isNaN(interval) && interval > 0) {
         config.metricsInterval = interval;
       } else {
-        process.stderr.write(`Warning: Invalid METRICS_INTERVAL: ${env.METRICS_INTERVAL}. Using default.\n`);
+        process.stderr.write(
+          `Warning: Invalid METRICS_INTERVAL: ${env.METRICS_INTERVAL}. Using default.\n`,
+        );
       }
     }
 

apps/mcp-server/src/config/server-config.ts

@@ -45,9 +45,12 @@ export function getDefaultAuthConfig(): AuthConfig {
   };
 }
 
-// For backwards compatibility - but prefer using getDefaultAuthConfig()
+/**
+ * Default auth config - reads API key at module load time for backward compatibility.
+ * For runtime reading of env vars, use getDefaultAuthConfig() instead.
+ */
 export const DEFAULT_AUTH_CONFIG: AuthConfig = {
-  defaultApiKey: undefined, // Will be set at runtime via getDefaultAuthConfig()
+  defaultApiKey: process.env.LIGHTHOUSE_API_KEY,
   enablePerRequestAuth: true,
   requireAuthentication: true,
   keyValidationCache: {
@@ -131,15 +134,18 @@ export function getDefaultServerConfig(): ServerConfig {
   };
 }
 
-// For backwards compatibility - prefer using getDefaultServerConfig()
+/**
+ * Default server config - reads API key at module load time for backward compatibility.
+ * For runtime reading of env vars, use getDefaultServerConfig() instead.
+ */
 export const DEFAULT_SERVER_CONFIG: ServerConfig = {
   name: "lighthouse-storage",
   version: "0.1.0",
   logLevel: "info",
   maxStorageSize: 1024 * 1024 * 1024, // 1GB
   enableMetrics: true,
   metricsInterval: 60000, // 1 minute
-  lighthouseApiKey: undefined, // Will be set at runtime
+  lighthouseApiKey: process.env.LIGHTHOUSE_API_KEY,
   authentication: DEFAULT_AUTH_CONFIG,
   performance: DEFAULT_PERFORMANCE_CONFIG,
   multiTenancy: DEFAULT_MULTI_TENANCY_CONFIG,

apps/mcp-server/src/services/LighthouseService.ts

@@ -6,10 +6,7 @@ import { LighthouseAISDK, EnhancedAccessCondition } from "@lighthouse-tooling/sd
 import { UploadResult, DownloadResult, AccessCondition, Dataset } from "@lighthouse-tooling/types";
 import { Logger } from "@lighthouse-tooling/shared";
 import { ILighthouseService, StoredFile } from "./ILighthouseService.js";
-import {
-  IStorageService,
-  InMemoryStorageService,
-} from "../storage/InMemoryStorageService.js";
+import { IStorageService, InMemoryStorageService } from "../storage/InMemoryStorageService.js";
 import { createStorageService } from "../storage/StorageFactory.js";
 
 export class LighthouseService implements ILighthouseService {
@@ -53,6 +50,10 @@ export class LighthouseService implements ILighthouseService {
       if (!this.storageInitialized) {
         try {
           const newStorage = await createStorageService(this.dbPath);
+
+          // Migrate any data from in-memory storage to new storage
+          this.migrateStorage(this.storage, newStorage);
+
           // Close old in-memory storage
           this.storage.close();
           this.storage = newStorage;
@@ -73,6 +74,37 @@ export class LighthouseService implements ILighthouseService {
     }
   }
 
+  /**
+   * Migrate data from old storage to new storage
+   * This ensures no data is lost when upgrading from in-memory to SQLite
+   */
+  private migrateStorage(oldStorage: IStorageService, newStorage: IStorageService): void {
+    try {
+      // Migrate files
+      const files = oldStorage.listFiles();
+      for (const file of files) {
+        newStorage.saveFile(file);
+      }
+
+      // Migrate datasets
+      const { datasets } = oldStorage.listDatasets();
+      for (const dataset of datasets) {
+        newStorage.saveDataset(dataset);
+      }
+
+      if (files.length > 0 || datasets.length > 0) {
+        this.logger.info("Migrated data from in-memory to persistent storage", {
+          fileCount: files.length,
+          datasetCount: datasets.length,
+        });
+      }
+    } catch (error) {
+      this.logger.warn("Failed to migrate some data during storage upgrade", {
+        error: error instanceof Error ? error.message : String(error),
+      });
+    }
+  }
+
   /**
    * Set up event listeners for SDK events
    */

apps/mcp-server/src/storage/InMemoryStorageService.ts

@@ -65,7 +65,7 @@ export class InMemoryStorageService implements IStorageService {
    */
   listFiles(limit?: number, offset?: number): StoredFile[] {
     const allFiles = Array.from(this.files.values()).sort(
-      (a, b) => b.uploadedAt.getTime() - a.uploadedAt.getTime()
+      (a, b) => b.uploadedAt.getTime() - a.uploadedAt.getTime(),
     );
 
     const start = offset || 0;
@@ -119,13 +119,13 @@ export class InMemoryStorageService implements IStorageService {
    */
   listDatasets(
     limit?: number,
-    offset?: number
+    offset?: number,
   ): {
     datasets: Dataset[];
     total: number;
   } {
     const allDatasets = Array.from(this.datasets.values()).sort(
-      (a, b) => b.updatedAt.getTime() - a.updatedAt.getTime()
+      (a, b) => b.updatedAt.getTime() - a.updatedAt.getTime(),
     );
 
     const start = offset || 0;