test: add missing tests

Author: orochaa

packages/core/__tests__/utils/index.spec.ts

@@ -1,3 +1,4 @@
+import { platform } from 'node:os';
 import { stdin, stdout } from 'node:process';
 import * as readline from 'node:readline';
 import { cursor } from 'sisteransi';
@@ -30,6 +31,10 @@ jest.mock('node:process', () => ({
 	},
 }));
 
+jest.mock('node:os', () => ({
+	platform: jest.fn(() => 'linux'),
+}));
+
 describe('Utils', () => {
 	describe('isCancel()', () => {
 		it('should verify if is cancel symbol', () => {
@@ -136,7 +141,18 @@ describe('Utils', () => {
 
 			block()();
 
-			expect(stdin.setRawMode).toHaveBeenCalledWith(false);
+			expect(stdin.setRawMode).toHaveBeenCalledTimes(2);
+			expect(stdin.setRawMode).toHaveBeenNthCalledWith(2, false);
+		});
+
+		it('should not disable input raw mode on Windows', () => {
+			stdin.isTTY = true;
+			(platform as jest.Mock).mockReturnValueOnce('win32');
+
+			block()();
+
+			expect(stdin.setRawMode).toHaveBeenCalledTimes(1);
+			expect(stdin.setRawMode).toHaveBeenCalledWith(true);
 		});
 
 		it('should close readline interface', () => {

packages/core/src/utils/index.ts

@@ -1,12 +1,11 @@
+import { platform } from 'node:os';
 import { stdin, stdout } from 'node:process';
 import type { Key } from 'node:readline';
 import * as readline from 'node:readline';
 import { Readable } from 'node:stream';
 import { cursor } from 'sisteransi';
 import { hasAliasKey } from './aliases';
 
-const isWindows = globalThis.process.platform.startsWith('win');
-
 export * from './aliases';
 export * from './mock';
 export * from './string';
@@ -23,6 +22,10 @@ export function setRawMode(input: Readable, value: boolean) {
 	if (i.isTTY) i.setRawMode(value);
 }
 
+function isWindows(): boolean {
+	return platform().startsWith('win');
+}
+
 export function block({
 	input = stdin,
 	output = stdout,
@@ -61,7 +64,7 @@ export function block({
 		if (hideCursor) output.write(cursor.show);
 
 		// Prevent Windows specific issues: https://github.com/natemoo-re/clack/issues/176
-		if (input.isTTY && !isWindows) input.setRawMode(false);
+		if (input.isTTY && !isWindows()) input.setRawMode(false);
 
 		// @ts-expect-error fix for https://github.com/nodejs/node/issues/31762#issuecomment-1441223907
 		rl.terminal = false;

packages/prompts/__tests__/utils/format.spec.ts

@@ -4,11 +4,10 @@ import { formatPlaceholder, limitOptions } from '../../src/utils';
 
 describe('format', () => {
 	describe('limitOptions()', () => {
+		const options = Array.from(Array(40).keys()).map(String);
 		const limit = color.dim('...');
 
 		it('should not limit options', () => {
-			const options = Array.from(Array(10).keys()).map(String);
-
 			const result = limitOptions({
 				options,
 				maxItems: undefined,
@@ -22,7 +21,6 @@ describe('format', () => {
 		});
 
 		it('should limit bottom options', () => {
-			const options = Array.from(Array(10).keys()).map(String);
 			const maxItems = 5;
 
 			const result = limitOptions({
@@ -40,7 +38,6 @@ describe('format', () => {
 		});
 
 		it('should limit top options', () => {
-			const options = Array.from(Array(10).keys()).map(String);
 			const maxItems = 5;
 
 			const result = limitOptions({
@@ -58,7 +55,6 @@ describe('format', () => {
 		});
 
 		it('should limit top and bottom options', () => {
-			const options = Array.from(Array(10).keys()).map(String);
 			const maxItems = 5;
 			const middleOption = Math.floor(maxItems / 2);
 			const cursor = Math.floor(options.length / 2);
@@ -77,6 +73,24 @@ describe('format', () => {
 			expect(result[middleOption]).toBe(options[cursor]);
 			expect(result[result.length - 1]).toBe(limit);
 		});
+
+		it('should limit by terminal rows', () => {
+			const maxTerminalRows = 20;
+			process.stdout.rows = maxTerminalRows;
+
+			const result = limitOptions({
+				options,
+				maxItems: undefined,
+				cursor: 0,
+				style(option, active) {
+					return option;
+				},
+			});
+
+			expect(result).toHaveLength(maxTerminalRows - 4);
+			expect(result[0]).toBe(options[0]);
+			expect(result[result.length - 1]).toBe(limit);
+		});
 	});
 
 	describe('formatPlaceholder()', () => {

packages/prompts/src/utils/format.ts

@@ -10,8 +10,11 @@ export interface LimitOptionsParams<TOption> {
 export const limitOptions = <TOption>(params: LimitOptionsParams<TOption>): string[] => {
 	const { cursor, options, style } = params;
 
+	const paramMaxItems = params.maxItems ?? Infinity;
+	// During test `process.stdout.rows` is `undefined`, and it brakes `limitOptions` function.
+	const outputMaxItems = Math.max((process.stdout.rows ?? Infinity) - 4, 0);
 	// We clamp to minimum 5 because anything less doesn't make sense UX wise
-	const maxItems = params.maxItems === undefined ? Infinity : Math.max(params.maxItems, 5);
+	const maxItems = Math.min(outputMaxItems, Math.max(paramMaxItems, 5));
 	let slidingWindowLocation = 0;
 
 	if (cursor >= slidingWindowLocation + maxItems - 3) {