make pwsh path default beahvior

Author: AmirSa12

bin/package-manager-completion.ts

@@ -8,6 +8,8 @@ import { RootCommand } from '../src/t.js';
 const noop = () => {};
 
 const isTabDebug = Boolean(process.env.TAB_DEBUG);
+const isPowerShellEnv =
+  process.platform === 'win32' && Boolean(process.env.PSModulePath);
 
 function tabDebugLog(...args: unknown[]) {
   if (isTabDebug) {
@@ -38,6 +40,11 @@ function runCompletionCommand(
   const args = [...leadingArgs, 'complete', '--', ...safeCompletionArgs];
   tabDebugLog('spawn completion:', command, args);
 
+  // PowerShell: prefer invoking via powershell.exe so .ps1 shims are resolved.
+  if (isPowerShellEnv && path.extname(command) === '') {
+    return runCompletionViaPowerShell(command, args);
+  }
+
   const result = spawnSync(command, args, completionSpawnOptions);
 
   tabDebugLog('spawn result:', {
@@ -46,46 +53,13 @@ function runCompletionCommand(
     stdout: result.stdout,
   });
 
-  // Windows: npm may only produce a .ps1 shim; spawnSync won't resolve .ps1 via PATHEXT.
-  // Fallback: invoke through powershell so .ps1 shims (e.g. nuxt.ps1) are discoverable.
+  // If the direct spawn fails on Windows, retry via PowerShell as a safety net.
   if (
     getErrnoCode(result.error) === 'ENOENT' &&
-    process.platform === 'win32' &&
+    isPowerShellEnv &&
     path.extname(command) === ''
   ) {
-    const psArgs = args.map(powerShellQuote);
-    const psCommand = `& ${command} ${psArgs.join(' ')}`.trimEnd();
-
-    tabDebugLog('powershell fallback:', psCommand);
-
-    const psResult = spawnSync(
-      'powershell.exe',
-      [
-        '-NoLogo',
-        '-NoProfile',
-        '-ExecutionPolicy',
-        'Bypass',
-        '-Command',
-        psCommand,
-      ],
-      completionSpawnOptions
-    );
-
-    tabDebugLog('powershell fallback result:', {
-      status: psResult.status,
-      error: psResult.error?.message,
-      stdout: psResult.stdout,
-    });
-
-    if (psResult.error) {
-      throw psResult.error;
-    }
-    if (typeof psResult.status === 'number' && psResult.status !== 0) {
-      throw new Error(
-        `Completion command "${command}" (PowerShell fallback) exited with code ${psResult.status}`
-      );
-    }
-    return (psResult.stdout ?? '').trim();
+    return runCompletionViaPowerShell(command, args);
   }
 
   if (result.error) {
@@ -106,6 +80,42 @@ function powerShellQuote(value: string): string {
   return `'${value.replace(/'/g, "''")}'`;
 }
 
+function runCompletionViaPowerShell(command: string, args: string[]): string {
+  const psArgs = args.map(powerShellQuote);
+  const psCommand = `& ${command} ${psArgs.join(' ')}`.trimEnd();
+
+  tabDebugLog('powershell exec:', psCommand);
+
+  const psResult = spawnSync(
+    'powershell.exe',
+    [
+      '-NoLogo',
+      '-NoProfile',
+      '-ExecutionPolicy',
+      'Bypass',
+      '-Command',
+      psCommand,
+    ],
+    completionSpawnOptions
+  );
+
+  tabDebugLog('powershell exec result:', {
+    status: psResult.status,
+    error: psResult.error?.message,
+    stdout: psResult.stdout,
+  });
+
+  if (psResult.error) {
+    throw psResult.error;
+  }
+  if (typeof psResult.status === 'number' && psResult.status !== 0) {
+    throw new Error(
+      `Completion command "${command}" (PowerShell) exited with code ${psResult.status}`
+    );
+  }
+  return (psResult.stdout ?? '').trim();
+}
+
 function getErrnoCode(error: unknown): string | undefined {
   if (error && typeof error === 'object' && 'code' in error) {
     const candidate = (error as { code?: unknown }).code;