clean npm handler

Author: AmirSa12

bin/handlers/bun-handler.ts

@@ -9,57 +9,52 @@ import {
   safeExec,
   safeExecSync,
   // createLogLevelHandler,
-} from '../utils/package-manager-base.js';
+} from '../utils/shared.js';
 
-// regex patterns to avoid recompilation in loops
 const COMMANDS_SECTION_RE = /^Commands:\s*$/i;
 const FLAGS_SECTION_RE = /^Flags:\s*$/i;
 const SECTION_END_RE = /^(Examples|Full documentation|Learn more)/i;
 const COMMAND_VALIDATION_RE = /^[a-z][a-z0-9-]*$/;
 const BUN_OPTION_RE =
   /^\s*(?:-([a-zA-Z]),?\s*)?--([a-z][a-z0-9-]*)(?:=<[^>]+>)?\s+(.+)$/;
-// const NON_INDENTED_LINE_RE = /^\s/;
+const MAIN_COMMAND_RE = /^  ([a-z][a-z0-9-]*)\s+(.+)$/;
+const CONTINUATION_COMMAND_RE = /^\s{12,}([a-z][a-z0-9-]*)\s+(.+)$/;
+const EMPTY_LINE_FOLLOWED_BY_NON_COMMAND_RE = /^\s+[a-z]/;
+const DESCRIPTION_SPLIT_RE = /\s{2,}/;
+const CAPITAL_LETTER_START_RE = /^[A-Z]/;
 
-// bun-specific completion handlers
 const bunOptionHandlers: OptionHandlers = {
-  // Use common handlers
   ...commonOptionHandlers,
 
-  // bun doesn't have traditional log levels, but has verbose/silent
   silent: function (complete) {
     complete('true', 'Enable silent mode');
     complete('false', 'Disable silent mode');
   },
 
   backend: function (complete) {
-    // From bun help: "clonefile" (default), "hardlink", "symlink", "copyfile"
     complete('clonefile', 'Clone files (default, fastest)');
     complete('hardlink', 'Use hard links');
     complete('symlink', 'Use symbolic links');
     complete('copyfile', 'Copy files');
   },
 
   linker: function (complete) {
-    // From bun help: "isolated" or "hoisted"
     complete('isolated', 'Isolated linker strategy');
     complete('hoisted', 'Hoisted linker strategy');
   },
 
   omit: function (complete) {
-    // From bun help: 'dev', 'optional', or 'peer'
     complete('dev', 'Omit devDependencies');
     complete('optional', 'Omit optionalDependencies');
     complete('peer', 'Omit peerDependencies');
   },
 
   shell: function (complete) {
-    // From bun help: 'bun' or 'system'
     complete('bun', 'Use Bun shell');
     complete('system', 'Use system shell');
   },
 
   'unhandled-rejections': function (complete) {
-    // From bun help: "strict", "throw", "warn", "none", or "warn-with-error-code"
     complete('strict', 'Strict unhandled rejection handling');
     complete('throw', 'Throw on unhandled rejections');
     complete('warn', 'Warn on unhandled rejections');
@@ -68,11 +63,9 @@ const bunOptionHandlers: OptionHandlers = {
   },
 };
 
-// Parse bun help text to extract commands and their descriptions
 export function parseBunHelp(helpText: string): Record<string, string> {
   const helpLines = stripAnsiEscapes(helpText).split(/\r?\n/);
 
-  // Find "Commands:" section
   let startIndex = -1;
   for (let i = 0; i < helpLines.length; i++) {
     if (COMMANDS_SECTION_RE.test(helpLines[i].trim())) {
@@ -85,44 +78,35 @@ export function parseBunHelp(helpText: string): Record<string, string> {
 
   const commands: Record<string, string> = {};
 
-  // Parse bun's unique command format
+  // parse bun's unique command format
   for (let i = startIndex; i < helpLines.length; i++) {
     const line = helpLines[i];
 
-    // Stop when we hit Flags section or empty line followed by non-command content
+    // stop when we hit Flags section or empty line followed by non-command content
     if (
       FLAGS_SECTION_RE.test(line.trim()) ||
       (line.trim() === '' &&
         i + 1 < helpLines.length &&
-        !helpLines[i + 1].match(/^\s+[a-z]/))
+        !helpLines[i + 1].match(EMPTY_LINE_FOLLOWED_BY_NON_COMMAND_RE))
     )
       break;
 
     // Skip empty lines
     if (line.trim() === '') continue;
 
-    // Handle different bun command formats:
-    // Format 1: "  run       ./my-script.ts       Execute a file with Bun"
-    // Format 2: "            lint                 Run a package.json script" (continuation)
-    // Format 3: "  install                        Install dependencies for a package.json (bun i)"
-
-    // Try to match command at start of line (2 spaces)
-    const mainCommandMatch = line.match(/^  ([a-z][a-z0-9-]*)\s+(.+)$/);
+    const mainCommandMatch = line.match(MAIN_COMMAND_RE);
     if (mainCommandMatch) {
       const [, command, rest] = mainCommandMatch;
       if (COMMAND_VALIDATION_RE.test(command)) {
-        // Extract description - find the last part that looks like a description
-        // Split by multiple spaces and take the last part that contains letters
-        const parts = rest.split(/\s{2,}/);
+        const parts = rest.split(DESCRIPTION_SPLIT_RE);
         let description = parts[parts.length - 1];
 
-        // If the last part starts with a capital letter, it's likely the description
-        if (description && /^[A-Z]/.test(description)) {
+        // If the last part starts with  capital letter, it's likely the description
+        if (description && CAPITAL_LETTER_START_RE.test(description)) {
           commands[command] = description.trim();
         } else if (parts.length > 1) {
-          // Otherwise, look for the first part that starts with a capital
           for (const part of parts) {
-            if (/^[A-Z]/.test(part)) {
+            if (CAPITAL_LETTER_START_RE.test(part)) {
               commands[command] = part.trim();
               break;
             }
@@ -131,8 +115,7 @@ export function parseBunHelp(helpText: string): Record<string, string> {
       }
     }
 
-    // Handle continuation lines (12+ spaces)
-    const continuationMatch = line.match(/^\s{12,}([a-z][a-z0-9-]*)\s+(.+)$/);
+    const continuationMatch = line.match(CONTINUATION_COMMAND_RE);
     if (continuationMatch) {
       const [, command, description] = continuationMatch;
       if (COMMAND_VALIDATION_RE.test(command)) {
@@ -144,7 +127,6 @@ export function parseBunHelp(helpText: string): Record<string, string> {
   return commands;
 }
 
-// Get bun commands from the main help output
 export async function getBunCommandsFromMainHelp(): Promise<
   Record<string, string>
 > {
@@ -200,7 +182,7 @@ export function parseBunOptions(
   return optionsOut;
 }
 
-// Load dynamic options synchronously when requested
+// load dynamic options synchronously when requested
 function loadBunOptionsSync(cmd: LazyCommand, command: string): void {
   const output = safeExecSync(`bun ${command} --help`);
   if (!output) return;