update

Author: AmirSa12

src/cac.ts

@@ -85,25 +85,21 @@ export default async function tab(
         break;
       }
       default: {
-        try {
-          assertDoubleDashes(instance.name);
+        assertDoubleDashes(instance.name);
 
-          const args: string[] = extra['--'] || [];
-          instance.showHelpOnExit = false;
+        const args: string[] = extra['--'] || [];
+        instance.showHelpOnExit = false;
 
-          // Parse current command context
-          instance.unsetMatchedCommand();
-          instance.parse([execPath, processArgs[0], ...args], {
-            run: false,
-          });
+        // Parse current command context
+        instance.unsetMatchedCommand();
+        instance.parse([execPath, processArgs[0], ...args], {
+          run: false,
+        });
 
-          // const matchedCommand = instance.matchedCommand?.name || '';
-          // const potentialCommand = args.join(' ')
-          // console.log(potentialCommand)
-          return completion.parse(args);
-        } catch (error) {
-          return;
-        }
+        // const matchedCommand = instance.matchedCommand?.name || '';
+        // const potentialCommand = args.join(' ')
+        // console.log(potentialCommand)
+        return completion.parse(args);
       }
     }
   });

src/citty.ts

@@ -187,21 +187,17 @@ export default async function tab<TArgs extends ArgsDef>(
           break;
         }
         default: {
-          try {
-            assertDoubleDashes(name);
-
-            const extra = ctx.rawArgs.slice(ctx.rawArgs.indexOf('--') + 1);
-            // const args = (await resolve(instance.args))!;
-            // const parsed = parseArgs(extra, args);
-            // TODO: this is not ideal at all
-            // const matchedCommand = parsed._.join(' ').trim(); //TODO: this was passed to parse line 170
-            // TODO: `command lint i` does not work because `lint` and `i` are potential commands
-            // instead the potential command should only be `lint`
-            // and `i` is the to be completed part
-            return completion.parse(extra);
-          } catch (error) {
-            return;
-          }
+          assertDoubleDashes(name);
+
+          const extra = ctx.rawArgs.slice(ctx.rawArgs.indexOf('--') + 1);
+          // const args = (await resolve(instance.args))!;
+          // const parsed = parseArgs(extra, args);
+          // TODO: this is not ideal at all
+          // const matchedCommand = parsed._.join(' ').trim(); //TODO: this was passed to parse line 170
+          // TODO: `command lint i` does not work because `lint` and `i` are potential commands
+          // instead the potential command should only be `lint`
+          // and `i` is the to be completed part
+          return completion.parse(extra);
         }
       }
     },

src/commander.ts

@@ -80,14 +80,10 @@ export default function tab(instance: CommanderCommand): Completion {
           break;
         }
         default: {
-          try {
-            assertDoubleDashes(programName);
+          assertDoubleDashes(programName);
 
-            // Parse current command context for autocompletion
-            return completion.parse(extra);
-          } catch (error) {
-            return;
-          }
+          // Parse current command context for autocompletion
+          return completion.parse(extra);
         }
       }
     });

src/shared.ts

@@ -23,6 +23,6 @@ export function assertDoubleDashes(programName: string = 'cli'): void {
   if (dashDashIndex === -1) {
     const errorMessage = `Error: You need to use -- to separate completion arguments.\nExample: ${programName} complete -- <args>`;
     console.error(errorMessage);
-    throw new Error('Missing -- separator');
+    process.exit(1);
   }
 }