test faster

Author: AmirSa12

bin/package-manager-completion.ts

@@ -2,6 +2,7 @@ import {
   spawnSync,
   type SpawnSyncOptionsWithStringEncoding,
 } from 'child_process';
+import fs from 'node:fs';
 import path from 'node:path';
 import { RootCommand } from '../src/t.js';
 
@@ -27,14 +28,15 @@ function runCompletionCommand(
   leadingArgs: string[],
   completionArgs: string[]
 ): string {
+  const targetCommand = preferCmdShim(command);
   const args = [...leadingArgs, 'complete', '--', ...completionArgs];
 
   // PowerShell: prefer invoking via powershell.exe so .ps1 shims are resolved.
-  if (isPowerShellEnv && path.extname(command) === '') {
-    return runCompletionViaPowerShell(command, args);
+  if (isPowerShellEnv && path.extname(targetCommand) === '') {
+    return runCompletionViaPowerShell(targetCommand, args);
   }
 
-  const result = spawnSync(command, args, completionSpawnOptions);
+  const result = spawnSync(targetCommand, args, completionSpawnOptions);
 
   return (result.stdout ?? '').trim();
 }
@@ -64,25 +66,6 @@ function runCompletionViaPowerShell(command: string, args: string[]): string {
   return (psResult.stdout ?? '').trim();
 }
 
-async function checkCliHasCompletions(
-  cliName: string,
-  packageManager: string
-): Promise<boolean> {
-  try {
-    const result = runCompletionCommand(cliName, [], []);
-    if (result) return true;
-  } catch {
-    noop();
-  }
-
-  try {
-    const result = runCompletionCommand(packageManager, [cliName], []);
-    return !!result;
-  } catch {
-    return false;
-  }
-}
-
 async function getCliCompletions(
   cliName: string,
   packageManager: string,
@@ -148,39 +131,46 @@ export class PackageManagerCompletion extends RootCommand {
       const knownCommands = [...this.commands.keys()];
 
       if (!knownCommands.includes(potentialCliName)) {
-        const hasCompletions = await checkCliHasCompletions(
+        const cliArgs = normalizedArgs.slice(1);
+        const suggestions = await getCliCompletions(
           potentialCliName,
-          this.packageManager
+          this.packageManager,
+          cliArgs
         );
 
-        if (hasCompletions) {
-          const cliArgs = normalizedArgs.slice(1);
-          const suggestions = await getCliCompletions(
-            potentialCliName,
-            this.packageManager,
-            cliArgs
+        if (suggestions.length > 0) {
+          debugLog(
+            `Returning ${suggestions.length} completions for ${potentialCliName}`
           );
-
-          if (suggestions.length > 0) {
-            debugLog(
-              `Returning ${suggestions.length} completions for ${potentialCliName}`
-            );
-            for (const suggestion of suggestions) {
-              if (suggestion.startsWith(':')) continue;
-              if (suggestion.includes('\t')) {
-                const [value, description] = suggestion.split('\t');
-                console.log(`${value}\t${description}`);
-              } else {
-                console.log(suggestion);
-              }
+          for (const suggestion of suggestions) {
+            if (suggestion.startsWith(':')) continue;
+            if (suggestion.includes('\t')) {
+              const [value, description] = suggestion.split('\t');
+              console.log(`${value}\t${description}`);
+            } else {
+              console.log(suggestion);
             }
-            console.log(':4');
-            return;
           }
+          console.log(':4');
+          return;
         }
       }
     }
 
     return super.parse(args);
   }
 }
+
+function preferCmdShim(command: string): string {
+  if (process.platform !== 'win32') return command;
+  if (path.extname(command) !== '') return command;
+
+  const pathEntries = (process.env.PATH || '').split(path.delimiter);
+  for (const entry of pathEntries) {
+    const candidate = path.join(entry, `${command}.cmd`);
+    if (fs.existsSync(candidate)) {
+      return `${command}.cmd`;
+    }
+  }
+  return command;
+}