fix espace args

Author: AmirSa12

src/cac.ts

@@ -24,6 +24,10 @@ export default async function tab(
 ) {
   const completion = new Completion();
 
+  // a hidden flag to track if -- is there in the raw arguments? we might need a better way to do this?
+  const dashDashIndex = process.argv.indexOf('--');
+  const wasDashDashProvided = dashDashIndex !== -1;
+
   // Add all commands and their options
   for (const cmd of [instance.globalCommand, ...instance.commands]) {
     if (cmd.name === 'complete') continue; // Skip completion command
@@ -85,7 +89,13 @@ export default async function tab(
         break;
       }
       default: {
-        const args: string[] = extra['--'];
+        if (!wasDashDashProvided) {
+          console.error(
+            'Error: You need to use -- to separate completion arguments'
+          );
+          return;
+        }
+        const args: string[] = extra['--'] || [];
         instance.showHelpOnExit = false;
 
         // Parse current command context

src/citty.ts

@@ -98,6 +98,10 @@ export default async function tab<TArgs extends ArgsDef>(
 ) {
   const completion = new Completion();
 
+  // a hidden flag to track if -- is there in the raw arguments? we might need a better way to do this?
+  const dashDashIndex = process.argv.indexOf('--');
+  const wasDashDashProvided = dashDashIndex !== -1;
+
   const meta = await resolve(instance.meta);
 
   if (!meta) {
@@ -155,7 +159,6 @@ export default async function tab<TArgs extends ArgsDef>(
     },
     async run(ctx) {
       let shell: string | undefined = ctx.rawArgs[0];
-      const extra = ctx.rawArgs.slice(ctx.rawArgs.indexOf('--') + 1);
 
       if (shell === '--') {
         shell = undefined;
@@ -188,6 +191,15 @@ export default async function tab<TArgs extends ArgsDef>(
           break;
         }
         default: {
+          // check if -- separator was provided
+          if (!wasDashDashProvided) {
+            console.error(
+              'Error: You need to use -- to separate completion arguments'
+            );
+            return;
+          }
+
+          const extra = ctx.rawArgs.slice(ctx.rawArgs.indexOf('--') + 1);
           // const args = (await resolve(instance.args))!;
           // const parsed = parseArgs(extra, args);
           // TODO: this is not ideal at all

src/commander.ts

@@ -21,6 +21,10 @@ export default function tab(instance: CommanderCommand): Completion {
   const completion = new Completion();
   const programName = instance.name();
 
+  // a hidden flag to track if -- is there in the raw arguments? we might need a better way to do this?
+  const dashDashIndex = process.argv.indexOf('--');
+  const wasDashDashProvided = dashDashIndex !== -1;
+
   // Process the root command
   processRootCommand(completion, instance, programName);
 
@@ -79,6 +83,14 @@ export default function tab(instance: CommanderCommand): Completion {
           break;
         }
         default: {
+          // check if -- separator is provided
+          if (!wasDashDashProvided) {
+            console.error(
+              'Error: You need to use -- to separate completion arguments'
+            );
+            return;
+          }
+
           // Parse current command context for autocompletion
           return completion.parse(extra);
         }