Don't require hints when converting to schema

Author: bombsimon

README.md

@@ -17,7 +17,7 @@ See [examples] directory for runnable examples and how to infer JTD.
 ```go
 schema := NewInferrer(WithoutHints()).
     Infer("my-string").
-    IntoSchema(WithoutHints())
+    IntoSchema()
 // {
 //   "type": "string"
 // }
@@ -31,7 +31,7 @@ rows := []string{
     `{"name":"Joe", "age": 52, "something_optional": true, "something_nullable": 1.1}`,
     `{"name":"Jane", "age": 48, "something_nullable": null}`,
 }
-schema := InferStrings(rows, WithoutHints()).IntoSchema(WithoutHints())
+schema := InferStrings(rows, WithoutHints()).IntoSchema()
 // {
 //   "properties": {
 //     "age": {

examples/infer_multiple_string_rows.go

@@ -13,7 +13,7 @@ func main() {
 	}
 	schema := jtdinfer.
 		InferStrings(rows, jtdinfer.WithoutHints()).
-		IntoSchema(jtdinfer.WithoutHints())
+		IntoSchema()
 
 	j, _ := json.MarshalIndent(schema, "", "  ")
 	print(string(j))

examples/infer_simple_value.go

@@ -10,7 +10,7 @@ func main() {
 	schema := jtdinfer.
 		NewInferrer(jtdinfer.WithoutHints()).
 		Infer("my-string").
-		IntoSchema(jtdinfer.WithoutHints())
+		IntoSchema()
 
 	j, _ := json.MarshalIndent(schema, "", "  ")
 	print(string(j))

examples/infer_with_hints.go

@@ -30,7 +30,7 @@ func main() {
 		Discriminator:  jtdinfer.NewHintSet().Add([]string{"discriminator", "-", "type"}),
 	}
 
-	schema := jtdinfer.InferStrings(rows, hints).IntoSchema(hints)
+	schema := jtdinfer.InferStrings(rows, hints).IntoSchema()
 	j, _ := json.MarshalIndent(schema, "", "  ")
 	print(string(j))
 }

inferrer.go

@@ -28,8 +28,8 @@ func (i *Inferrer) Infer(value any) *Inferrer {
 }
 
 // IntoSchema will convert the `InferredSchema` into a final `Schema`.
-func (i *Inferrer) IntoSchema(hints Hints) Schema {
-	return i.Inference.IntoSchema(hints)
+func (i *Inferrer) IntoSchema() Schema {
+	return i.Inference.IntoSchema(i.Hints)
 }
 
 // InferStrings accepts a slice of strings and will convert them to either a

inferrer_test.go

@@ -20,7 +20,7 @@ func TestJTDInfer(t *testing.T) {
 			"hobbies": {Elements: &Schema{Type: jtd.TypeString}},
 		},
 	}
-	gotSchema := InferStrings(rows, Hints{}).IntoSchema(Hints{})
+	gotSchema := InferStrings(rows, WithoutHints()).IntoSchema()
 
 	assert.EqualValues(t, expectedSchema, gotSchema)
 }
@@ -48,10 +48,19 @@ func TestJTDInferrerWithEnumHints(t *testing.T) {
 			},
 		},
 	}
-	gotSchema := InferStrings(rows, hints).IntoSchema(hints)
+	gotSchema := InferStrings(rows, hints).IntoSchema()
 
 	// We check that we got the same elements in our enum first and then we
 	// delete it since the order is unreliable due to being a map.
+	require.ElementsMatch(
+		t,
+		expectedSchema.Properties["name"].Enum,
+		gotSchema.Properties["name"].Enum,
+	)
+
+	delete(expectedSchema.Properties, "name")
+	delete(gotSchema.Properties, "name")
+
 	require.ElementsMatch(
 		t,
 		expectedSchema.Properties["address"].Properties["city"].Enum,
@@ -81,7 +90,7 @@ func TestJTDInferWithValuesHints(t *testing.T) {
 			},
 		},
 	}
-	gotSchema := InferStrings(rows, hints).IntoSchema(hints)
+	gotSchema := InferStrings(rows, hints).IntoSchema()
 
 	assert.EqualValues(t, expectedSchema, gotSchema)
 }
@@ -112,7 +121,7 @@ func TestJTDInferWithDiscriminatorHints(t *testing.T) {
 			},
 		},
 	}
-	gotSchema := InferStrings(rows, hints).IntoSchema(hints)
+	gotSchema := InferStrings(rows, hints).IntoSchema()
 
 	assert.EqualValues(t, expectedSchema, gotSchema)
 }