Skip to content

Commit 4adce12

Browse files
committed
refactor: remove standalone validate CLI command
- Remove validate command implementation and tests - Remove command registration from CLI - Remove ValidateCommandArgs interface - Update documentation (README.md and ARCHITECTURE.md) Internal validation methods (engine.validate, loader.validate, config.validate) remain intact for use by other commands like run.
1 parent 61503b1 commit 4adce12

File tree

6 files changed

+2
-1058
lines changed

6 files changed

+2
-1058
lines changed

ARCHITECTURE.md

Lines changed: 2 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -621,33 +621,7 @@ private index: null | StorageIndex = null;
621621

622622
## 7. Rarely-Used Features: Removal Candidates
623623

624-
### 7.1 Validation Command
625-
626-
**Command**: `modestbench validate [patterns..]`
627-
**Location**: `src/cli/commands/validate.ts`
628-
629-
#### Opinion: 🤔 CONSIDER REMOVAL
630-
631-
**Current Features**:
632-
633-
- Validates benchmark files without running them
634-
- `--fix` flag for auto-fixing issues
635-
- `--strict` mode for treating warnings as errors
636-
637-
**Issues**:
638-
639-
1. **Redundant**: The `run` command validates files before execution anyway
640-
2. **Limited value**: Syntax validation is superficial (bracket counting)
641-
3. **No auto-fix implementation**: The `--fix` flag is defined but has no implementation
642-
4. **Low usage**: Validation is typically done during runs
643-
644-
**Alternative**: Keep validation as part of `run` command, remove standalone command
645-
646-
**Maintenance burden**: ~300 lines of code across command + implementation
647-
648-
---
649-
650-
### 7.2 Init Command Templates
624+
### 7.1 Init Command Templates
651625

652626
**Command**: `modestbench init [type]`
653627
**Location**: `src/cli/commands/init.ts`
@@ -1177,8 +1151,7 @@ Provides test helpers and fixtures
11771151
### Medium Priority
11781152

11791153
1. **🤔 Remove syntax validation** - Redundant, error-prone
1180-
2. **🤔 Consider removing standalone validate command** - Redundant with run validation
1181-
3. **🤔 Simplify init command** - Remove unused template variations
1154+
2. **🤔 Simplify init command** - Remove unused template variations
11821155

11831156
### Low Priority
11841157

README.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -162,16 +162,6 @@ modestbench init advanced --examples --config typescript
162162
# Note: Only JSON configs are currently loadable by the runtime
163163
```
164164

165-
### Validation
166-
167-
```bash
168-
# Validate benchmark files
169-
modestbench validate [patterns...]
170-
171-
# Strict validation with auto-fix
172-
modestbench validate --strict --fix
173-
```
174-
175165
### History Management
176166

177167
```bash

0 commit comments

Comments
 (0)