fix: resolve test failures and improve default behavior

Test fixes:
- Fix directory-paths test by changing default pattern to bench/**/*
- Fix init-command tests by restoring .gitignore creation/update functionality
- Fix symlink-install test by correcting ExitCodes constant references
- Update file-loader unit test to match new default pattern behavior

Default pattern improvements:
- Change default pattern from **/* to bench/**/* (recursive)
- Only search bench/ directory by default, not top-level files
- Update DEFAULT_CONFIG in config-manager to use bench/**/* pattern
- File-loader now uses bench/**/* when given empty pattern array

ExitCodes consolidation:
- Remove duplicate ExitCodes definition from cli/index.ts
- Import ExitCodes from types/cli.ts for consistency
- Fix incorrect constant references (RUNTIME_ERROR -> ExecutionError, etc.)
- Ensure all exit codes use camelCase naming convention

.gitignore functionality:
- Restore appendFile and readFile imports to init command
- Add createOrUpdateGitignore function to manage .gitignore files
- Create new .gitignore with modestbench entries when initializing
- Append .modestbench/ to existing .gitignore files (with --yes or --quiet)
- Avoid duplicate entries if .modestbench/ already exists

All tests now passing (812 pass, 0 fail, 5 skipped).

Author: boneskull

src/cli/commands/init.ts

@@ -5,7 +5,13 @@
  * structure, and optional example benchmark files.
  */
 
-import { access, mkdir, writeFile } from 'node:fs/promises';
+import {
+  access,
+  appendFile,
+  mkdir,
+  readFile,
+  writeFile,
+} from 'node:fs/promises';
 import { join, resolve } from 'node:path';
 import { createInterface } from 'node:readline';
 
@@ -297,7 +303,10 @@ export const handleInitCommand = async (
     }
 
     // Create additional files
-    await createAdditionalFiles(cwd);
+    await createAdditionalFiles(cwd, {
+      quiet: options.quiet,
+      yes: options.yes,
+    });
 
     if (!options.quiet) {
       console.log('✅ Project initialized successfully!');
@@ -358,7 +367,10 @@ const checkForConflicts = async (
 /**
  * Create additional project files
  */
-const createAdditionalFiles = async (cwd: string): Promise<void> => {
+const createAdditionalFiles = async (
+  cwd: string,
+  options?: { quiet?: boolean; yes?: boolean },
+): Promise<void> => {
   // Create README.md
   const readmeContent = `# Benchmark Project
 
@@ -397,6 +409,68 @@ Create new benchmark files in the \`benchmarks/\` directory. See the examples fo
     // Non-critical, just warn
     console.warn('Warning: Could not create README.md file');
   }
+
+  // Create or update .gitignore
+  await createOrUpdateGitignore(cwd, options);
+};
+
+/**
+ * Create or update .gitignore file to include ModestBench directories
+ */
+const createOrUpdateGitignore = async (
+  cwd: string,
+  options?: { quiet?: boolean; yes?: boolean },
+): Promise<void> => {
+  const gitignorePath = resolve(cwd, '.gitignore');
+  const modestbenchEntry = '.modestbench/';
+  const modestbenchSection = `\n# ModestBench history\n${modestbenchEntry}\n`;
+
+  try {
+    // Check if .gitignore exists
+    let existingContent = '';
+    try {
+      existingContent = await readFile(gitignorePath, 'utf8');
+    } catch {
+      // File doesn't exist, will create new one
+    }
+
+    if (existingContent) {
+      // File exists, check if .modestbench/ is already present
+      if (existingContent.includes(modestbenchEntry)) {
+        // Already present, nothing to do
+        return;
+      }
+
+      // Append .modestbench/ entry (--yes or --quiet means auto-accept)
+      if (options?.yes || options?.quiet) {
+        // Ensure content ends with newline
+        const contentToAppend = existingContent.endsWith('\n')
+          ? modestbenchSection
+          : `\n${modestbenchSection}`;
+        await appendFile(gitignorePath, contentToAppend, 'utf8');
+      }
+    } else {
+      // Create new .gitignore with common entries
+      const newContent = `# Dependencies
+node_modules/
+
+# Build output
+dist/
+build/
+*.log
+
+# Test coverage
+coverage/
+
+# Benchmark output
+benchmark-results/
+${modestbenchSection}`;
+      await writeFile(gitignorePath, newContent, 'utf8');
+    }
+  } catch {
+    // Non-critical, just warn
+    console.warn('Warning: Could not create/update .gitignore file');
+  }
 };
 
 /**

src/cli/index.ts

@@ -31,6 +31,7 @@ import {
   JsonReporter,
   SimpleReporter,
 } from '../reporters/index.js';
+import { ExitCodes } from '../types/cli.js';
 // Import commands
 import {
   handleAnalyzeCommand as handleBaselineAnalyzeCommand,
@@ -82,19 +83,6 @@ interface GlobalOptions {
   verbose?: boolean;
 }
 
-/**
- * Exit codes for the CLI
- */
-export const ExitCodes = {
-  BENCHMARK_FAILURES: 1,
-  CONFIG_ERROR: 2,
-  DISCOVERY_ERROR: 3,
-  RUNTIME_ERROR: 5,
-  SUCCESS: 0,
-  UNKNOWN_ERROR: 99,
-  VALIDATION_ERROR: 4,
-} as const;
-
 /**
  * Initialize and run the CLI
  */
@@ -103,7 +91,7 @@ export const cli = (argv?: string[]): void => {
   setupSignalHandlers(abortController);
   main(argv, abortController).catch((error) => {
     console.error('CLI error:', error);
-    process.exit(ExitCodes.UNKNOWN_ERROR);
+    process.exit(ExitCodes.GeneralError);
   });
 };
 
@@ -950,15 +938,15 @@ export const main = async (
           if (err.name === 'FileDiscoveryError') {
             console.error();
             yargsInstance.showHelp();
-            process.exit(ExitCodes.DISCOVERY_ERROR);
+            process.exit(ExitCodes.FileDiscoveryError);
           }
-          process.exit(ExitCodes.RUNTIME_ERROR);
+          process.exit(ExitCodes.ExecutionError);
         } else {
           // Show help for usage errors (unknown arguments, etc.)
           console.error(msg);
           console.error();
           yargsInstance.showHelp();
-          process.exit(ExitCodes.CONFIG_ERROR);
+          process.exit(ExitCodes.ConfigurationError);
         }
       })
       .parse();
@@ -970,7 +958,7 @@ export const main = async (
     if (process.env.DEBUG) {
       console.error(error);
     }
-    process.exit(ExitCodes.UNKNOWN_ERROR);
+    process.exit(ExitCodes.GeneralError);
   }
 };
 
@@ -1036,7 +1024,7 @@ const createCliContext = async (
       'Failed to initialize ModestBench:',
       error instanceof Error ? error.message : String(error),
     );
-    process.exit(ExitCodes.CONFIG_ERROR);
+    process.exit(ExitCodes.ConfigurationError);
   }
 };
 
@@ -1077,7 +1065,7 @@ const setupSignalHandlers = (abortController: AbortController): void => {
           { cause: error },
         );
     console.error(wrappedError.toString());
-    process.exit(ExitCodes.RUNTIME_ERROR);
+    process.exit(ExitCodes.ExecutionError);
   });
 
   process.once('unhandledRejection', (reason) => {
@@ -1089,7 +1077,7 @@ const setupSignalHandlers = (abortController: AbortController): void => {
           { cause: reason },
         );
     console.error(wrappedError.toString());
-    process.exit(ExitCodes.RUNTIME_ERROR);
+    process.exit(ExitCodes.ExecutionError);
   });
 };
 

src/services/config-manager.ts

@@ -56,7 +56,7 @@ const DEFAULT_CONFIG: ModestBenchConfig = {
   limitBy: 'iterations', // Default to limiting by iteration count
   metadata: {},
   outputDir: './benchmark-results',
-  pattern: '**/*.bench.{js,ts,mjs,cjs,mts,cts}',
+  pattern: 'bench/**/*.bench.{js,ts,mjs,cjs,mts,cts}', // Search bench/ directory recursively
   quiet: false,
   reporterConfig: {},
   reporters: [getDefaultReporter()],

src/services/file-loader.ts

@@ -64,8 +64,7 @@ export class BenchmarkFileLoader implements FileLoader {
       // Handle empty patterns - use sensible defaults
       if (patterns.length === 0) {
         patterns = [
-          `*${BENCHMARK_FILE_PATTERN}`, // top-level current directory
-          `bench/*${BENCHMARK_FILE_PATTERN}`, // top-level bench/ directory
+          `bench/**/*${BENCHMARK_FILE_PATTERN}`, // bench/ directory (recursive)
         ];
       }
 

test/unit/services/file-loader.test.ts

@@ -132,20 +132,20 @@ describe('BenchmarkFileLoader - path resolution', () => {
       try {
         const files = await loader.discover([]);
 
-        // Should find: top.bench.js and bench/inside.bench.js
-        // Should NOT find: bench/nested/deep.bench.js or other/other.bench.js
+        // Should find: bench/inside.bench.js and bench/nested/deep.bench.js (recursive bench/**)
+        // Should NOT find: top.bench.js (top-level) or other/other.bench.js (different directory)
         expect(files.length, 'to equal', 2);
         expect(
           files.some((f) => f.includes('top.bench.js')),
-          'to be truthy',
+          'to be falsy',
         );
         expect(
           files.some((f) => f.includes('inside.bench.js')),
           'to be truthy',
         );
         expect(
           files.some((f) => f.includes('deep.bench.js')),
-          'to be falsy',
+          'to be truthy',
         );
       } finally {
         process.chdir(originalCwd);