Fix logic to find success box in page objects

bonigarcia · bonigarcia · commit 9a86fcbdb93a · 2025-03-14T15:54:50.000+01:00
diff --git a/selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch07/page_objects/BasicLoginPage.java b/selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch07/page_objects/BasicLoginPage.java
@@ -47,7 +47,7 @@ public void with(String username, String password) {
     }
 
     public boolean successBoxPresent() {
-        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(10));
+        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(2));
         WebElement success = wait.until(
                 ExpectedConditions.visibilityOfElementLocated(successBox));
         return success.isDisplayed();
diff --git a/selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch07/page_objects/ExtendedLoginPage.java b/selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch07/page_objects/ExtendedLoginPage.java
@@ -19,6 +19,7 @@
 import java.time.Duration;
 
 import org.openqa.selenium.By;
+import org.openqa.selenium.TimeoutException;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.support.ui.ExpectedConditions;
 import org.openqa.selenium.support.ui.WebDriverWait;
@@ -47,10 +48,14 @@ public void with(String username, String password) {
     }
 
     public boolean successBoxPresent() {
-        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(10));
-        WebElement success = wait.until(
-                ExpectedConditions.visibilityOfElementLocated(successBox));
-        return success.isDisplayed();
+        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(2));
+        try {
+            WebElement success = wait.until(
+                    ExpectedConditions.visibilityOfElementLocated(successBox));
+            return success.isDisplayed();
+        } catch (TimeoutException e) {
+            return false;
+        }
     }
 
 }
diff --git a/selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch07/page_objects/FactoryLoginPage.java b/selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch07/page_objects/FactoryLoginPage.java
@@ -18,6 +18,7 @@
 
 import java.time.Duration;
 
+import org.openqa.selenium.TimeoutException;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.support.CacheLookup;
 import org.openqa.selenium.support.FindBy;
@@ -61,10 +62,14 @@ public void with(String username, String password) {
     }
 
     public boolean successBoxPresent() {
-        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(10));
-        WebElement success = wait
-                .until(ExpectedConditions.visibilityOf(successBox));
-        return success.isDisplayed();
+        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(2));
+        try {
+            WebElement success = wait
+                    .until(ExpectedConditions.visibilityOf(successBox));
+            return success.isDisplayed();
+        } catch (TimeoutException e) {
+            return false;
+        }
     }
 
 }
diff --git a/selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch07/page_objects/BasicLoginPage.java b/selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch07/page_objects/BasicLoginPage.java
@@ -47,7 +47,7 @@ public void with(String username, String password) {
     }
 
     public boolean successBoxPresent() {
-        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(10));
+        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(2));
         WebElement success = wait.until(
                 ExpectedConditions.visibilityOfElementLocated(successBox));
         return success.isDisplayed();
diff --git a/selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch07/page_objects/ExtendedLoginPage.java b/selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch07/page_objects/ExtendedLoginPage.java
@@ -19,6 +19,7 @@
 import java.time.Duration;
 
 import org.openqa.selenium.By;
+import org.openqa.selenium.TimeoutException;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.support.ui.ExpectedConditions;
 import org.openqa.selenium.support.ui.WebDriverWait;
@@ -47,10 +48,14 @@ public void with(String username, String password) {
     }
 
     public boolean successBoxPresent() {
-        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(10));
-        WebElement success = wait.until(
-                ExpectedConditions.visibilityOfElementLocated(successBox));
-        return success.isDisplayed();
+        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(2));
+        try {
+            WebElement success = wait.until(
+                    ExpectedConditions.visibilityOfElementLocated(successBox));
+            return success.isDisplayed();
+        } catch (TimeoutException e) {
+            return false;
+        }
     }
 
 }
diff --git a/selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch07/page_objects/FactoryLoginPage.java b/selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch07/page_objects/FactoryLoginPage.java
@@ -18,6 +18,7 @@
 
 import java.time.Duration;
 
+import org.openqa.selenium.TimeoutException;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.support.CacheLookup;
 import org.openqa.selenium.support.FindBy;
@@ -61,10 +62,14 @@ public void with(String username, String password) {
     }
 
     public boolean successBoxPresent() {
-        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(10));
-        WebElement success = wait
-                .until(ExpectedConditions.visibilityOf(successBox));
-        return success.isDisplayed();
+        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(2));
+        try {
+            WebElement success = wait
+                    .until(ExpectedConditions.visibilityOf(successBox));
+            return success.isDisplayed();
+        } catch (TimeoutException e) {
+            return false;
+        }
     }
 
 }
diff --git a/selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch07/page_objects/BasicLoginPage.java b/selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch07/page_objects/BasicLoginPage.java
@@ -47,7 +47,7 @@ public void with(String username, String password) {
     }
 
     public boolean successBoxPresent() {
-        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(10));
+        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(2));
         WebElement success = wait.until(
                 ExpectedConditions.visibilityOfElementLocated(successBox));
         return success.isDisplayed();
diff --git a/selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch07/page_objects/ExtendedLoginPage.java b/selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch07/page_objects/ExtendedLoginPage.java
@@ -19,6 +19,7 @@
 import java.time.Duration;
 
 import org.openqa.selenium.By;
+import org.openqa.selenium.TimeoutException;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.support.ui.ExpectedConditions;
 import org.openqa.selenium.support.ui.WebDriverWait;
@@ -47,10 +48,14 @@ public void with(String username, String password) {
     }
 
     public boolean successBoxPresent() {
-        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(10));
-        WebElement success = wait.until(
-                ExpectedConditions.visibilityOfElementLocated(successBox));
-        return success.isDisplayed();
+        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(2));
+        try {
+            WebElement success = wait.until(
+                    ExpectedConditions.visibilityOfElementLocated(successBox));
+            return success.isDisplayed();
+        } catch (TimeoutException e) {
+            return false;
+        }
     }
 
 }
diff --git a/selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch07/page_objects/FactoryLoginPage.java b/selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch07/page_objects/FactoryLoginPage.java
@@ -18,6 +18,7 @@
 
 import java.time.Duration;
 
+import org.openqa.selenium.TimeoutException;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.support.CacheLookup;
 import org.openqa.selenium.support.FindBy;
@@ -61,10 +62,14 @@ public void with(String username, String password) {
     }
 
     public boolean successBoxPresent() {
-        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(10));
-        WebElement success = wait
-                .until(ExpectedConditions.visibilityOf(successBox));
-        return success.isDisplayed();
+        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(2));
+        try {
+            WebElement success = wait
+                    .until(ExpectedConditions.visibilityOf(successBox));
+            return success.isDisplayed();
+        } catch (TimeoutException e) {
+            return false;
+        }
     }
 
 }
diff --git a/selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch07/page_objects/BasicLoginPage.java b/selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch07/page_objects/BasicLoginPage.java
@@ -47,7 +47,7 @@ public void with(String username, String password) {
     }
 
     public boolean successBoxPresent() {
-        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(10));
+        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(2));
         WebElement success = wait.until(
                 ExpectedConditions.visibilityOfElementLocated(successBox));
         return success.isDisplayed();
diff --git a/selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch07/page_objects/ExtendedLoginPage.java b/selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch07/page_objects/ExtendedLoginPage.java
@@ -19,6 +19,7 @@
 import java.time.Duration;
 
 import org.openqa.selenium.By;
+import org.openqa.selenium.TimeoutException;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.support.ui.ExpectedConditions;
 import org.openqa.selenium.support.ui.WebDriverWait;
@@ -47,10 +48,14 @@ public void with(String username, String password) {
     }
 
     public boolean successBoxPresent() {
-        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(10));
-        WebElement success = wait.until(
-                ExpectedConditions.visibilityOfElementLocated(successBox));
-        return success.isDisplayed();
+        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(2));
+        try {
+            WebElement success = wait.until(
+                    ExpectedConditions.visibilityOfElementLocated(successBox));
+            return success.isDisplayed();
+        } catch (TimeoutException e) {
+            return false;
+        }
     }
 
 }
diff --git a/selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch07/page_objects/FactoryLoginPage.java b/selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch07/page_objects/FactoryLoginPage.java
@@ -18,6 +18,7 @@
 
 import java.time.Duration;
 
+import org.openqa.selenium.TimeoutException;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.support.CacheLookup;
 import org.openqa.selenium.support.FindBy;
@@ -61,10 +62,14 @@ public void with(String username, String password) {
     }
 
     public boolean successBoxPresent() {
-        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(10));
-        WebElement success = wait
-                .until(ExpectedConditions.visibilityOf(successBox));
-        return success.isDisplayed();
+        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(2));
+        try {
+            WebElement success = wait
+                    .until(ExpectedConditions.visibilityOf(successBox));
+            return success.isDisplayed();
+        } catch (TimeoutException e) {
+            return false;
+        }
     }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public void with(String username, String password) {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`public boolean successBoxPresent() {`
`50`		`- WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(10));`
	`50`	`+ WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(2));`
`51`	`51`	`WebElement success = wait.until(`
`52`	`52`	`ExpectedConditions.visibilityOfElementLocated(successBox));`
`53`	`53`	`return success.isDisplayed();`