Skip to content

Commit fbf9baa

Browse files
committed
Update browser binary tests using latest features of WDM and Sel-Jup 6
1 parent f259151 commit fbf9baa

File tree

4 files changed

+10
-13
lines changed

4 files changed

+10
-13
lines changed

selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch05/caps/binary/BinaryChromeJUnit4Test.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ public void setup() {
4242

4343
ChromeOptions options = new ChromeOptions();
4444
options.setBinary(browserBinary.toFile());
45-
driver = WebDriverManager.chromedriver().capabilities(options).create();
45+
driver = WebDriverManager.chromedriver().capabilities(options)
46+
.browserBinary(browserBinary.toString()).create();
4647
}
4748

4849
@After

selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch05/caps/binary/BinaryChromeSelJupTest.java

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,34 +19,28 @@
1919
import static org.assertj.core.api.Assertions.assertThat;
2020
import static org.assertj.core.api.Assumptions.assumeThat;
2121

22-
import java.nio.file.Path;
2322
import java.nio.file.Paths;
2423

2524
import org.junit.jupiter.api.BeforeEach;
2625
import org.junit.jupiter.api.Test;
2726
import org.junit.jupiter.api.extension.ExtendWith;
2827
import org.openqa.selenium.chrome.ChromeDriver;
29-
import org.openqa.selenium.chrome.ChromeOptions;
3028

31-
import io.github.bonigarcia.seljup.Options;
29+
import io.github.bonigarcia.seljup.Binary;
3230
import io.github.bonigarcia.seljup.SeleniumJupiter;
3331

3432
@ExtendWith(SeleniumJupiter.class)
3533
class BinaryChromeSelJupTest {
3634

37-
@Options
38-
ChromeOptions options = new ChromeOptions();
35+
static final String BROWSER_BINARY = "/usr/bin/google-chrome-beta";
3936

4037
@BeforeEach
4138
void setup() {
42-
Path browserBinary = Paths.get("/usr/bin/google-chrome-beta");
43-
assumeThat(browserBinary).exists();
44-
45-
options.setBinary(browserBinary.toFile());
39+
assumeThat(Paths.get(BROWSER_BINARY)).exists();
4640
}
4741

4842
@Test
49-
void testBinary(ChromeDriver driver) {
43+
void testBinary(@Binary(BROWSER_BINARY) ChromeDriver driver) {
5044
driver.get("https://bonigarcia.dev/selenium-webdriver-java/");
5145
assertThat(driver.getTitle()).contains("Selenium WebDriver");
5246
}

selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch05/caps/binary/BinaryChromeJupiterTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ void setup() {
4242

4343
ChromeOptions options = new ChromeOptions();
4444
options.setBinary(browserBinary.toFile());
45-
driver = WebDriverManager.chromedriver().capabilities(options).create();
45+
driver = WebDriverManager.chromedriver().capabilities(options)
46+
.browserBinary(browserBinary.toString()).create();
4647
}
4748

4849
@AfterEach

selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch05/caps/binary/BinaryChromeNGTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ public void setup() {
4242

4343
ChromeOptions options = new ChromeOptions();
4444
options.setBinary(browserBinary.toFile());
45-
driver = WebDriverManager.chromedriver().capabilities(options).create();
45+
driver = WebDriverManager.chromedriver().capabilities(options)
46+
.browserBinary(browserBinary.toString()).create();
4647
}
4748

4849
@AfterMethod

0 commit comments

Comments
 (0)