move initShaka, update docs

Author: bonswouar

README.md

@@ -9,37 +9,42 @@ Make a youtube playlist, collaboratively.
 
 This is a forked version. There are quite a few fixes and new features, including:
 
-- Basic Youtube search support
+- Basic Youtube search support (including Youtube Music)
 - Sync the playback on all clients *(experimental)*
-- Use piped instead of native youtube for everything - no call is ever made directly on youtube's server
+- Use Piped instead of native Youtube for everything: no call is ever made on Youtube's server
 - Implement Shaka Player
-- DASH+xml conversion from streams (apparently youtube's HLS are kinda broken)
+- DASH+xml conversion from streams (apparently Youtube's HLS are kinda broken)
 - Update packages.json, remove reprecated
-- Dockerized
+- Dockerized for easier installation
 
-You can take a look at TODO.md for details about potential future features.
+You can take a look at [TODO](./TODO.md) for details about potential future features.
 
 ## Requirements
 
-- [node.js](https://nodejs.org/en/)
+- docker
 
 
 ## Installation
 
-    npm install
+    docker build -t poolparty .
 
 ## Run
 
-    npm start
+    docker-compose up -d
 
 
 When the server is running, everyone in the party can acces to
-server_ip:8080/  and add songs.
+`http://server_ip:5468` and add songs.
 
-One person will visit server_ip:8080/play in order to reproduce the
-playlist.
+One or more persons can then visit `http://server_ip:5468/play` in order to play the playlist in sync.
 
-## Authors
+
+## Warning
+
+This is a work in progress. Don't use it in production environment, or do it at your own risks.
+
+
+## Thanks to original Authors
 
 - [@carlos4rias](https://github.com/carlos4rias)
 - [@jhonber](https://github.com/jhonber)

TODO.md

@@ -1,5 +1,18 @@
+# TODO
+
+## SOON
+
+- Clean code, improve security
 - Use Piped configurable instance url
-- Search & add YT playlists
-- Better playlist management (remove any video)
+- Fine tune playback sync, add client options to force sync (one time action) and unsync ("soft" to prevent seeking, and "hard" to prevent song removing & seeking)
+
+## LATER
+
+- Search & add YT Playlists
+
+## MAYBE
+
 - Permissions & rooms
+- Better playlist management (remove, change order, etc)
 - Better design, & mobile app (?)
+- Implement other sources (local? spotify? deezer?)

browser/main.js

@@ -143,11 +143,13 @@ document.addEventListener('DOMContentLoaded', function() {
     window.socket = socket;
 
     socket.on('start', function(data) {
+      // NOTE: doesn't seem to be triggered the first time the page is loaded on chrome (need refresh)
       for (var i = 0, f; f = data.playlist[i]; ++i) {
         if (parseAddress(f.url))
           window.data.push(f.url);
       }
       if (window.data.length > 0) {
+        initShaka();
         loadVideo(window.data.shift());
       }
     });

views/play.ejs

@@ -47,23 +47,16 @@
   }
 
   function initShaka() {
-    // Install built-in polyfills to patch browser incompatibilities.
     shaka.polyfill.installAll();
-
-    // Check to see if the browser supports the basic APIs Shaka needs.
     if (shaka.Player.isBrowserSupported()) {
-      // Everything looks good!
       if (window.data.length > 0) {
         loadVideo(window.data.shift());
       }
     } else {
-      // This browser does not have the minimum set of APIs we need.
       console.error('Browser not supported!');
     }
   }
 
-  document.addEventListener('DOMContentLoaded', initShaka);
-
   function loadVideo(url) {
     window.currentVideoUrl = url;
     var youtubeId = window.getParseAddress(url);