Skip to content

Dynamic require with safe_require prints a warning in Webpack 5ย #117

@amannn

Description

@amannn

Hi! ๐Ÿ‘‹

Firstly, thanks for your work on this project! ๐Ÿ™‚

Today I used patch-package to patch casual@1.6.2 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/casual/src/casual.js b/node_modules/casual/src/casual.js
index 9179af1..0706dca 100644
--- a/node_modules/casual/src/casual.js
+++ b/node_modules/casual/src/casual.js
@@ -1,12 +1,6 @@
 var helpers = require('./helpers');
 var exists = require('fs').existsSync;
-
-var safe_require = function(filename) {
-	if (exists(filename + '.js')) {
-		return require(filename);
-	}
-	return {};
-};
+var path = require('path');
 
 var build_casual = function() {
 	var casual = helpers.extend({}, helpers);
@@ -40,9 +34,16 @@ var build_casual = function() {
 			var casual = build_casual();
 
 			providers.forEach(function(provider) {
+				let localeProvider = {};
+				try {
+					localeProvider = require(__dirname + '/providers/' + locale + '/' + provider)
+				} catch (e) {
+					// Nothing to do
+				}
+
 				casual.register_provider(helpers.extend(
 					require('./providers/' + provider),
-					safe_require(__dirname + '/providers/' + locale + '/' + provider)
+					localeProvider
 				));
 			});
 

This issue body was partially generated by patch-package.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions