Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 87ea971

Browse files
committed
Update go version, dependencies, ping golangci-lint
1 parent 282e330 commit 87ea971

File tree

11 files changed

+44
-75
lines changed

11 files changed

+44
-75
lines changed

.github/workflows/ci-build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ jobs:
1313
runs-on: ubuntu-latest
1414

1515
steps:
16-
- uses: actions/checkout@v3
16+
- uses: actions/checkout@v4
1717

1818
- name: set up QEMU
19-
uses: docker/setup-qemu-action@v2
19+
uses: docker/setup-qemu-action@v3
2020

2121
- name: set up Docker Buildx
2222
id: buildx
23-
uses: docker/setup-buildx-action@v2
23+
uses: docker/setup-buildx-action@v3
2424

2525
- name: available platforms
2626
run: echo ${{ steps.buildx.outputs.platforms }}

.github/workflows/ci-run.yml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,17 @@ jobs:
1212
runs-on: ubuntu-latest
1313

1414
steps:
15-
- uses: actions/checkout@v3
15+
- uses: actions/checkout@v4
1616

1717
- name: install go
18-
uses: actions/setup-go@v3
18+
uses: actions/setup-go@v5
1919
with:
20-
go-version: 1.18
20+
go-version: 1.22
2121

2222
- name: build and test
2323
run: go test -timeout=60s -covermode=count -coverprofile=$GITHUB_WORKSPACE/profile.cov ./...
2424

25-
- name: install golangci-lint
26-
run: curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $GITHUB_WORKSPACE v1.50.1
27-
28-
- name: run linters
29-
run: $GITHUB_WORKSPACE/golangci-lint run ./... ;
30-
25+
- name: golangci-lint
26+
uses: golangci/golangci-lint-action@v4
27+
with:
28+
version: v1.64

.golangci.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
linters:
22
enable:
33
- bodyclose
4-
- depguard
54
- dogsled
65
- dupl
76
- errcheck
@@ -21,7 +20,7 @@ linters:
2120
- misspell
2221
- nakedret
2322
- rowserrcheck
24-
- exportloopref
23+
- copyloopvar
2524
- staticcheck
2625
- stylecheck
2726
- typecheck

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ LABEL org.opencontainers.image.authors="Dmitry Verkhoturov <paskal.07@gmail.com>
1515
org.opencontainers.image.description="AWS Security Connectors" \
1616
org.opencontainers.image.documentation="https://github.com/bookingcom/aws-security-connectors" \
1717
org.opencontainers.image.licenses="Apache 2.0" \
18-
org.opencontainers.image.source="https://github.com/bookingcom/aws-security-connectors.git" \
18+
org.opencontainers.image.source="https://github.com/bookingcom/aws-security-connectors" \
1919
org.opencontainers.image.title="aws-security-connectors" \
2020
org.opencontainers.image.vendor="Booking.com"
2121

connectors/detective_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,6 @@ func TestDetectiveInviter_AddMember(t *testing.T) {
9898

9999
masterSess, memberSess := NewMasterMemberSess("us-west-2", "", "")
100100
for i, x := range testAPIRequestsDataset {
101-
i := i
102-
x := x
103101
t.Run(x.description, func(t *testing.T) {
104102
master := &mockDMasterClient{
105103
t: t,

connectors/guardduty_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,6 @@ func TestGuardDutyInviter_AddMember(t *testing.T) {
123123

124124
masterSess, memberSess := NewMasterMemberSess("us-west-2", "", "")
125125
for i, x := range testAPIRequestsDataset {
126-
i := i
127-
x := x
128126
t.Run(x.description, func(t *testing.T) {
129127
master := &mockGDMasterClient{
130128
email: &testEmail,

connectors/prisma_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,6 @@ func TestPrisma_AddAWSAccount(t *testing.T) {
8484
}
8585

8686
for i, x := range testAPIRequestsDataset {
87-
i := i
88-
x := x
8987
t.Run(x.description, func(t *testing.T) {
9088
m := &mockClient{t: t, requests: x.requests}
9189
p := NewPrisma("", "", "")

connectors/security_hub_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,6 @@ func TestSecurityHubInviter_AddMember(t *testing.T) {
8686

8787
masterSess, memberSess := NewMasterMemberSess("us-west-2", "", "")
8888
for i, x := range testAPIRequestsDataset {
89-
i := i
90-
x := x
9189
t.Run(x.description, func(t *testing.T) {
9290
master := &mockSHMasterClient{
9391
t: t,

docker-compose.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
version: '2'
21
services:
32

43
aws-security-connectors:
54
build: .
6-
image: paskal/aws-security-connectors:latest
5+
image: ghcr.io/bookingcom/aws-security-connectors:latest
76
environment:
87
- DEBUG
98
- AWS_ACCOUNT_ID

go.mod

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,21 @@
11
module github.com/bookingcom/aws-security-connectors
22

3-
go 1.14
3+
go 1.22
44

55
require (
6-
github.com/aws/aws-sdk-go v1.44.209
6+
github.com/aws/aws-sdk-go v1.55.6
77
github.com/hashicorp/go-multierror v1.1.1
8-
github.com/jessevdk/go-flags v1.5.0
9-
github.com/paskal/go-prisma v1.0.0
10-
github.com/sirupsen/logrus v1.9.0
11-
github.com/stretchr/testify v1.8.2
8+
github.com/jessevdk/go-flags v1.6.1
9+
github.com/paskal/go-prisma v1.0.1
10+
github.com/sirupsen/logrus v1.9.3
11+
github.com/stretchr/testify v1.10.0
12+
)
13+
14+
require (
15+
github.com/davecgh/go-spew v1.1.1 // indirect
16+
github.com/hashicorp/errwrap v1.1.0 // indirect
17+
github.com/jmespath/go-jmespath v0.4.0 // indirect
18+
github.com/pmezard/go-difflib v1.0.0 // indirect
19+
golang.org/x/sys v0.30.0 // indirect
20+
gopkg.in/yaml.v3 v3.0.1 // indirect
1221
)

0 commit comments

Comments
 (0)