Skip to content

Commit 3f94d8a

Browse files
authored
Merge pull request #1718 from booklore-app/develop
Merge develop into master for release
2 parents 3052b07 + 4da832c commit 3f94d8a

File tree

7 files changed

+20
-13
lines changed

7 files changed

+20
-13
lines changed

booklore-ui/src/app/features/book/components/book-browser/book-card/book-card.component.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,3 +234,7 @@
234234
::ng-deep .custom-button-padding .p-button {
235235
padding-block: 0.25rem !important;
236236
}
237+
238+
::ng-deep .book-details-dialog .p-dialog-header {
239+
padding: 1rem 1.25rem !important;
240+
}

booklore-ui/src/app/features/book/components/book-browser/book-card/book-card.component.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -495,11 +495,16 @@ export class BookCardComponent implements OnInit, OnChanges, OnDestroy {
495495
});
496496
} else {
497497
this.dialogService.open(BookMetadataCenterComponent, {
498-
width: '85%',
498+
width: '90%',
499499
data: {bookId: book.id},
500500
modal: true,
501-
dismissableMask: true,
502-
showHeader: false
501+
dismissableMask: false,
502+
showHeader: true,
503+
closable: true,
504+
closeOnEscape: true,
505+
maximizable: true,
506+
header: 'Book Details',
507+
styleClass: 'book-details-dialog'
503508
});
504509
}
505510
}

booklore-ui/src/app/features/book/components/book-browser/book-filter/book-filter.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,11 @@ function getRatingRangeFilters10(rating?: number): { id: string; name: string; s
8989
return idx ? [{id: idx.id, name: idx.label, sortIndex: idx.sortIndex}] : [];
9090
}
9191

92-
function extractPublishedYearFilter(book: Book): { id: number; name: string }[] {
92+
function extractPublishedYearFilter(book: Book): { id: string; name: string }[] {
9393
const date = book.metadata?.publishedDate;
9494
if (!date) return [];
9595
const year = new Date(date).getFullYear();
96-
return [{id: year, name: year.toString()}];
96+
return [{id: year.toString(), name: year.toString()}];
9797
}
9898

9999
function getShelfStatusFilter(book: Book): { id: string; name: string }[] {

booklore-ui/src/app/features/book/components/book-browser/filter-label.helper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export class FilterLabelHelper {
1414
publisher: 'Publisher',
1515
readStatus: 'Read Status',
1616
personalRating: 'Personal Rating',
17-
publishedYear: 'Year Published',
17+
publishedDate: 'Year Published',
1818
matchScore: 'Metadata Match Score',
1919
language: 'Language',
2020
bookType: 'Book Type',

booklore-ui/src/app/features/book/components/book-browser/filters/SidebarFilter.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,11 @@ export class SideBarFilter implements BookFilter {
9393
return filterValues.some(range => isRatingInRange(book.metadata?.hardcoverRating, range));
9494
case 'personalRating':
9595
return filterValues.some(range => isRatingInRange10(book.metadata?.personalRating, range));
96-
case 'publishedYear':
96+
case 'publishedDate':
9797
const bookYear = book.metadata?.publishedDate
98-
? new Date(book.metadata.publishedDate).getFullYear().toString()
98+
? new Date(book.metadata.publishedDate).getFullYear()
9999
: null;
100-
return bookYear ? filterValues.includes(bookYear) : false;
101-
case 'publishedDate':
102-
return filterValues.includes(new Date(book.metadata?.publishedDate || '').getFullYear());
100+
return bookYear ? filterValues.some(val => val == bookYear || val == bookYear.toString()) : false;
103101
case 'fileSize':
104102
return filterValues.some(range => isFileSizeInRange(book.fileSizeKb, range));
105103
case 'shelfStatus':

booklore-ui/src/app/features/metadata/component/book-metadata-center/metadata-viewer/metadata-viewer.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,7 @@ export class MetadataViewerComponent implements OnInit, OnChanges {
587587
goToPublishedYear(publishedDate: string): void {
588588
const year = this.extractYear(publishedDate);
589589
if (year) {
590-
this.handleMetadataClick('publishedYear', year);
590+
this.handleMetadataClick('publishedDate', year);
591591
}
592592
}
593593

dev.docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
services:
22
backend:
3-
image: gradle:9-jdk25-alpine
3+
image: gradle:8-jdk21-alpine
44
command: sh -c "cd /booklore-api && ./gradlew bootRun"
55
ports:
66
- "${BACKEND_PORT:-8080}:8080"

0 commit comments

Comments
 (0)