Fix showstopper bugs in v1.18.0 (#2399)

- Fix issue with hardcover toggle not being selectable
- Resolve syncing problem with Booklore toggle
- Address CSS warnings for cleaner styling

Co-authored-by: acx10 <acx10@users.noreply.github.com>

Author: acx10

.github/workflows/draft-release.yml

@@ -12,4 +12,5 @@ public class KoreaderUser {
     private String password;
     private String passwordMD5;
     private boolean syncEnabled;
+    private boolean syncWithBookloreReader;
 }

booklore-api/src/main/java/com/adityachandel/booklore/model/dto/KoreaderUser.java

@@ -4,14 +4,18 @@
 import com.adityachandel.booklore.service.koreader.KoreaderUserService;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
-import org.mockito.*;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
 
 import java.util.Map;
 
-import static org.junit.jupiter.api.Assertions.*;
-import static org.mockito.Mockito.*;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.mockito.Mockito.doNothing;
+import static org.mockito.Mockito.when;
 
 class KoreaderUserControllerTest {
 
@@ -26,7 +30,7 @@ class KoreaderUserControllerTest {
     @BeforeEach
     void setUp() {
         try (AutoCloseable mocks = MockitoAnnotations.openMocks(this)) {
-            user = new KoreaderUser(1L, "testuser", "pass", "md5", true);
+            user = new KoreaderUser(1L, "testuser", "pass", "md5", true, true);
         } catch (Exception e) {
             throw new RuntimeException(e);
         }

booklore-api/src/test/java/com/adityachandel/booklore/controller/KoreaderUserControllerTest.java

@@ -53,7 +53,7 @@ void init() {
         entity.setBookLoreUser(ownerEntity);
         entity.setUsername("kvUser");
 
-        dto = new KoreaderUser(10L, "kvUser", null, null, false);
+        dto = new KoreaderUser(10L, "kvUser", null, null, false, true);
         when(koreaderUserMapper.toDto(any(KoreaderUserEntity.class))).thenReturn(dto);
     }
 
@@ -69,7 +69,7 @@ void upsertUser_createsNew_whenAbsent() {
 
         when(koreaderUserMapper.toDto(any(KoreaderUserEntity.class))).thenAnswer(invocation -> {
             KoreaderUserEntity u = invocation.getArgument(0);
-            return new KoreaderUser(u.getId(), u.getUsername(), u.getPassword(), u.getPasswordMD5(), u.isSyncEnabled());
+            return new KoreaderUser(u.getId(), u.getUsername(), u.getPassword(), u.getPasswordMD5(), u.isSyncEnabled(), u.isSyncWithBookloreReader());
         });
 
         KoreaderUser result = service.upsertUser("userA", "passA");

booklore-api/src/test/java/com/adityachandel/booklore/service/KoreaderUserServiceTest.java

@@ -1,3 +1,5 @@
+@use 'sass:color';
+
 // Variables
 $footer-bg: #1a1a1a;
 $text-primary: rgba(255, 255, 255, 0.95);
@@ -95,7 +97,7 @@ $transition-fast: 150ms ease;
     }
 
     &:hover:not(:disabled) {
-      background: darken($active-color, 10%);
+      background: color.adjust($active-color, $lightness: -10%);
     }
 
     &:disabled {
@@ -289,7 +291,7 @@ $transition-fast: 150ms ease;
     transition: all 0.2s ease;
 
     &:hover:not(:disabled) {
-      background: darken($active-color, 10%);
+      background: color.adjust($active-color, $lightness: -10%);
     }
 
     &:disabled {

booklore-ui/src/app/features/readers/cbx-reader/layout/footer/cbx-footer.component.scss

@@ -1,3 +1,5 @@
+@use 'sass:color';
+
 // Variables
 $panel-bg: #1a1a1a;
 $text-primary: rgba(255, 255, 255, 0.95);
@@ -134,7 +136,7 @@ $transition-normal: 200ms ease;
     background: rgba(255, 255, 255, 0.2);
 
     &.active {
-      background: lighten($active-color, 5%);
+      background: color.adjust($active-color, $lightness: 5%);
     }
   }
 }

booklore-ui/src/app/features/readers/cbx-reader/layout/quick-settings/cbx-quick-settings.component.scss

@@ -77,23 +77,21 @@ <h4 class="provider-group-title">Providers with Configuration</h4>
               </p-toggleswitch>
               <label class="setting-label">Hardcover</label>
             </div>
-            @if (hardcoverEnabled) {
-              <div class="setting-options">
-                <div class="config-field">
-                  <div class="config-label-row">
-                    <label class="config-label">API Token</label>
-                    <app-external-doc-link docType="hardcover"></app-external-doc-link>
-                  </div>
-                  <input
-                    type="text"
-                    pInputText
-                    placeholder="Enter Hardcover API token"
-                    [(ngModel)]="hardcoverToken"
-                    (ngModelChange)="onTokenChange($event)"
-                    class="config-input"/>
+            <div class="setting-options">
+              <div class="config-field">
+                <div class="config-label-row">
+                  <label class="config-label">API Token</label>
+                  <app-external-doc-link docType="hardcover"></app-external-doc-link>
                 </div>
+                <input
+                  type="text"
+                  pInputText
+                  placeholder="Enter Hardcover API token"
+                  [(ngModel)]="hardcoverToken"
+                  (ngModelChange)="onTokenChange($event)"
+                  class="config-input"/>
               </div>
-            }
+            </div>
           </div>
 
           <div class="setting-item">

booklore-ui/src/app/features/settings/global-preferences/metadata-provider-settings/metadata-provider-settings.component.html

@@ -1,4 +1,4 @@
-@import '../../../_chart-shared';
+@use '../../../_chart-shared';
 
 .author-universe-container {
   width: 100%;

booklore-ui/src/app/features/stats/component/library-stats/charts/author-universe-chart/author-universe-chart.component.scss

@@ -1,4 +1,4 @@
-@import '../../../_chart-shared';
+@use '../../../_chart-shared';
 
 .book-formats-container {
   width: 100%;

booklore-ui/src/app/features/stats/component/library-stats/charts/book-formats-chart/book-formats-chart.component.scss

@@ -1,4 +1,4 @@
-@import '../../../_chart-shared';
+@use '../../../_chart-shared';
 
 .language-chart-container {
   width: 100%;