Skip to content

Commit aea9da3

Browse files
committed
fix: subengine id to call spock engine
1 parent 47f7ebe commit aea9da3

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

jdoc-spock/src/main/java/org/bool/jdoc/spock/SpockEngineService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public SpockEngineService() {
4040
public JdocSpockEngineDescriptor discover(SpockEngine spockEngine, EngineDiscoveryRequest request, UniqueId uniqueId) {
4141
try (SpecClassMapper mapper = specClassMapperFactory.createMapper(request.getConfigurationParameters())) {
4242
EngineDiscoveryRequest discoveryRequest = requestMapper.toSpockDiscoveryRequest(request, mapper);
43-
TestDescriptor testDescriptor = spockEngine.discover(discoveryRequest, UniqueId.forEngine(spockEngine.getId()));
43+
TestDescriptor testDescriptor = spockEngine.discover(discoveryRequest, uniqueId.appendEngine(spockEngine.getId()));
4444
return createEngineDescriptor(uniqueId, testDescriptor);
4545
}
4646
}

jdoc-spock/src/test/java/org/bool/jdoc/spock/SpockEngineServiceTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,17 +35,18 @@ void testDiscover(@Mock SpockEngine spockEngine, @Mock ConfigurationParameters p
3535
@Mock TestDescriptor spockTestDescriptor) {
3636
var jdocDiscoveryRequest = DiscoveryRequest.builder().params(params).selectors(List.of()).build();
3737
var spockDiscoveryRequest = DiscoveryRequest.builder().params(params).selectors(List.of()).build();
38+
var uniqueId = UniqueId.forEngine("jdoc-spock");
3839

3940
given(spockEngine.getId())
4041
.willReturn("spock-engine");
4142
given(specClassMapperFactory.createMapper(params))
4243
.willReturn(specClassMapper);
4344
given(requestMapper.toSpockDiscoveryRequest(jdocDiscoveryRequest, specClassMapper))
4445
.willReturn(spockDiscoveryRequest);
45-
given(spockEngine.discover(spockDiscoveryRequest, UniqueId.forEngine("spock-engine")))
46+
given(spockEngine.discover(spockDiscoveryRequest, uniqueId.appendEngine("spock-engine")))
4647
.willReturn(spockTestDescriptor);
4748

48-
assertThat(service.discover(spockEngine, jdocDiscoveryRequest, UniqueId.forEngine("jdoc-spock")))
49+
assertThat(service.discover(spockEngine, jdocDiscoveryRequest, uniqueId))
4950
.extracting(JdocSpockEngineDescriptor::getChildren).asInstanceOf(InstanceOfAssertFactories.COLLECTION)
5051
.containsOnly(spockTestDescriptor)
5152
;

0 commit comments

Comments
 (0)