Revert "[lldb][NFC] Mark ValueObject library with NO_PLUGIN_DEPENDENCIES" (llvm#167886)

kparzysz · web-flow · commit 7129d76fe56e · 2025-11-13T09:06:13.000-06:00
Reverts llvm#167794 This breaks a build with BUILD_SHARED_LIBS=ON: /usr/bin/ld: lib/liblldbCommands.a(CommandObjectTarget.cpp.o): undefined reference to symbol '_ZN5clang22PCHContainerOperationsC1Ev Fixing that issue leads to similar failures due to different symbols.
diff --git a/lldb/source/Commands/CMakeLists.txt b/lldb/source/Commands/CMakeLists.txt
@@ -58,8 +58,6 @@ add_lldb_library(lldbCommands NO_PLUGIN_DEPENDENCIES
     lldbUtility
     lldbValueObject
     lldbVersion
-  CLANG_LIBS
-    clangFrontend
   )
 
 add_dependencies(lldbCommands LLDBOptionsGen)
diff --git a/lldb/source/ValueObject/CMakeLists.txt b/lldb/source/ValueObject/CMakeLists.txt
@@ -1,4 +1,4 @@
-add_lldb_library(lldbValueObject NO_PLUGIN_DEPENDENCIES
+add_lldb_library(lldbValueObject
   DILAST.cpp
   DILEval.cpp
   DILLexer.cpp
@@ -34,4 +34,6 @@ add_lldb_library(lldbValueObject NO_PLUGIN_DEPENDENCIES
     lldbSymbol
     lldbTarget
     lldbUtility
+    lldbPluginCPlusPlusLanguage
+    lldbPluginObjCLanguage
   )

Original file line number	Diff line number	Diff line change
`@@ -58,8 +58,6 @@ add_lldb_library(lldbCommands NO_PLUGIN_DEPENDENCIES`
`58`	`58`	`lldbUtility`
`59`	`59`	`lldbValueObject`
`60`	`60`	`lldbVersion`
`61`		`- CLANG_LIBS`
`62`		`- clangFrontend`
`63`	`61`	`)`
`64`	`62`
`65`	`63`	`add_dependencies(lldbCommands LLDBOptionsGen)`