Skip to content

Commit 85db9e0

Browse files
[compiler-rt] Default to Lit's Internal Shell
All of the tests should work with the internal shell now, at least on x86 Linux. Enable it by default for the performance/debuggability advantages. Pull Request: llvm#165148
1 parent b6b2226 commit 85db9e0

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

compiler-rt/test/lit.common.cfg.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,13 +112,17 @@ def push_dynamic_library_lookup_path(config, new_path):
112112
)
113113
config.environment[dynamic_library_lookup_var] = new_ld_library_path_64
114114

115-
115+
# TODO: Consolidate the logic for turning on the internal shell by default for all LLVM test suites.
116+
# See https://github.com/llvm/llvm-project/issues/106636 for more details.
117+
#
116118
# Choose between lit's internal shell pipeline runner and a real shell. If
117119
# LIT_USE_INTERNAL_SHELL is in the environment, we use that as an override.
118-
use_lit_shell = os.environ.get("LIT_USE_INTERNAL_SHELL")
120+
use_lit_shell = True
121+
lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL")
122+
if lit_shell_env:
123+
use_lit_shell = lit.util.pythonize_bool(lit_shell_env)
119124
if use_lit_shell:
120-
# 0 is external, "" is default, and everything else is internal.
121-
execute_external = use_lit_shell == "0"
125+
execute_external = True
122126
else:
123127
# Otherwise we default to internal on Windows and external elsewhere, as
124128
# bash on Windows is usually very slow.

0 commit comments

Comments
 (0)