🔀 #54 from boostcampwm-2022/feat/duplicateCheckGroupName

peter-j0y · web-flow · commit 2ca3d88b09a0 · 2022-11-30T21:26:43.000+09:00
그룹 생성 및 수정 시 그룹 이름 중복확인 기능 추가, FinishNotifiacation관련 수정
diff --git a/data/src/main/java/com/whyranoid/data/Post/PostDataSource.kt b/data/src/main/java/com/whyranoid/data/Post/PostDataSource.kt
@@ -1,6 +1,7 @@
 package com.whyranoid.data.Post
 
 import com.google.firebase.firestore.FirebaseFirestore
+import com.google.firebase.firestore.Query
 import com.whyranoid.data.constant.CollectionId
 import com.whyranoid.data.model.GroupInfoResponse
 import com.whyranoid.data.model.RecruitPostResponse
@@ -26,6 +27,7 @@ class PostDataSource @Inject constructor(
     fun getAllPostFlow(): Flow<List<Post>> =
         callbackFlow {
             db.collection(CollectionId.POST_COLLECTION)
+                .orderBy("updatedAt", Query.Direction.DESCENDING)
                 .addSnapshotListener { snapshot, _ ->
                     val recruitPostList = mutableListOf<Post>()
                     snapshot?.forEach { docuemnt ->
diff --git a/data/src/main/java/com/whyranoid/data/constant/CollectionId.kt b/data/src/main/java/com/whyranoid/data/constant/CollectionId.kt
@@ -9,4 +9,5 @@ object CollectionId {
     const val START_NOTIFICATION = "start"
     const val FINISH_NOTIFICATION = "finish"
     const val POST_COLLECTION = "Posts"
+    const val RUNNING_HISTORY_COLLECTION = "RunningHistory"
 }
diff --git a/data/src/main/java/com/whyranoid/data/group/GroupDataSource.kt b/data/src/main/java/com/whyranoid/data/group/GroupDataSource.kt
@@ -20,6 +20,7 @@ import kotlinx.coroutines.channels.awaitClose
 import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.callbackFlow
 import kotlinx.coroutines.suspendCancellableCoroutine
+import kotlinx.coroutines.tasks.await
 import java.util.UUID
 import javax.inject.Inject
 import kotlin.coroutines.resume
@@ -152,4 +153,13 @@ class GroupDataSource @Inject constructor(
             }
         awaitClose()
     }
+
+    suspend fun isDuplicatedGroupName(groupName: String): Boolean {
+        return db.collection(GROUPS_COLLECTION)
+            .whereEqualTo(GROUP_NAME, groupName)
+            .get()
+            .await()
+            .isEmpty
+            .not()
+    }
 }
diff --git a/data/src/main/java/com/whyranoid/data/group/GroupRepositoryImpl.kt b/data/src/main/java/com/whyranoid/data/group/GroupRepositoryImpl.kt
@@ -58,4 +58,8 @@ class GroupRepositoryImpl @Inject constructor(
     ): Boolean {
         return groupDataSource.createGroup(groupName, introduce, rules, uid)
     }
+
+    override suspend fun isDuplicatedGroupName(groupName: String): Boolean {
+        return groupDataSource.isDuplicatedGroupName(groupName)
+    }
 }
diff --git a/data/src/main/java/com/whyranoid/data/groupnotification/GroupNotificationDataSource.kt b/data/src/main/java/com/whyranoid/data/groupnotification/GroupNotificationDataSource.kt
@@ -3,12 +3,14 @@ package com.whyranoid.data.groupnotification
 import com.google.firebase.firestore.FirebaseFirestore
 import com.whyranoid.data.constant.CollectionId.FINISH_NOTIFICATION
 import com.whyranoid.data.constant.CollectionId.GROUP_NOTIFICATIONS_COLLECTION
+import com.whyranoid.data.constant.CollectionId.RUNNING_HISTORY_COLLECTION
 import com.whyranoid.data.constant.CollectionId.START_NOTIFICATION
 import com.whyranoid.data.model.FinishNotificationResponse
 import com.whyranoid.data.model.StartNotificationResponse
-import com.whyranoid.data.model.toFinishNotification
 import com.whyranoid.data.model.toStartNotification
+import com.whyranoid.domain.model.FinishNotification
 import com.whyranoid.domain.model.GroupNotification
+import com.whyranoid.domain.model.RunningHistory
 import com.whyranoid.domain.model.StartNotification
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.FlowPreview
@@ -79,11 +81,28 @@ class GroupNotificationDataSource @Inject constructor(
                 .addSnapshotListener { snapshot, error ->
                     val finishNotificationList = mutableListOf<GroupNotification>()
                     snapshot?.forEach { document ->
-                        val finishNotification =
+                        val finishNotificationResponse =
                             document.toObject(FinishNotificationResponse::class.java)
-                        finishNotificationList.add(finishNotification.toFinishNotification())
+
+                        finishNotificationResponse.let { finishNotificationResponse ->
+                            db.collection(RUNNING_HISTORY_COLLECTION)
+                                .document(finishNotificationResponse.historyId)
+                                .get()
+                                .addOnSuccessListener {
+                                    val runningHistory = it.toObject(RunningHistory::class.java)
+
+                                    runningHistory?.let {
+                                        finishNotificationList.add(
+                                            FinishNotification(
+                                                uid = finishNotificationResponse.uid,
+                                                runningHistory = runningHistory
+                                            )
+                                        )
+                                    }
+                                    trySend(finishNotificationList)
+                                }
+                        }
                     }
-                    trySend(finishNotificationList)
                 }
 
             awaitClose()
diff --git a/data/src/main/java/com/whyranoid/data/model/GroupNotificationResponse.kt b/data/src/main/java/com/whyranoid/data/model/GroupNotificationResponse.kt
@@ -1,7 +1,5 @@
 package com.whyranoid.data.model
 
-import com.whyranoid.domain.model.FinishNotification
-import com.whyranoid.domain.model.RunningHistory
 import com.whyranoid.domain.model.StartNotification
 
 sealed interface GroupNotificationResponse {
@@ -18,29 +16,11 @@ data class StartNotificationResponse(
 data class FinishNotificationResponse(
     override val type: String = "",
     override val uid: String = "",
-    val finishedAt: Long = 0L,
-    val historyId: String = "",
-    val pace: Double = 0.0,
-    val startedAt: Long = 0L,
-    val totalDistance: Double = 0.0,
-    val totalRunningTime: Int = 0
+    val historyId: String = ""
 ) : GroupNotificationResponse
 
 fun StartNotificationResponse.toStartNotification() =
     StartNotification(
         uid = this.uid,
         startedAt = this.startedAt
     )
-
-fun FinishNotificationResponse.toFinishNotification() =
-    FinishNotification(
-        uid = this.uid,
-        runningHistory = RunningHistory(
-            historyId = this.historyId,
-            startedAt = this.startedAt,
-            finishedAt = this.finishedAt,
-            totalRunningTime = this.totalRunningTime,
-            pace = this.pace,
-            totalDistance = this.totalDistance
-        )
-    )
diff --git a/domain/src/main/java/com/whyranoid/domain/model/RunningHistory.kt b/domain/src/main/java/com/whyranoid/domain/model/RunningHistory.kt
@@ -1,10 +1,10 @@
 package com.whyranoid.domain.model
 
 data class RunningHistory(
-    val historyId: String,
-    val startedAt: Long,
-    val finishedAt: Long,
-    val totalRunningTime: Int,
-    val pace: Double,
-    val totalDistance: Double
+    val historyId: String = "",
+    val startedAt: Long = 0L,
+    val finishedAt: Long = 0L,
+    val totalRunningTime: Int = 0,
+    val pace: Double = 0.0,
+    val totalDistance: Double = 0.0
 )
diff --git a/domain/src/main/java/com/whyranoid/domain/repository/GroupRepository.kt b/domain/src/main/java/com/whyranoid/domain/repository/GroupRepository.kt
@@ -40,4 +40,6 @@ interface GroupRepository {
         rules: List<String>,
         uid: String
     ): Boolean
+
+    suspend fun isDuplicatedGroupName(groupName: String): Boolean
 }
diff --git a/domain/src/main/java/com/whyranoid/domain/usecase/CheckIsDuplicatedGroupNameUseCase.kt b/domain/src/main/java/com/whyranoid/domain/usecase/CheckIsDuplicatedGroupNameUseCase.kt
@@ -0,0 +1,13 @@
+package com.whyranoid.domain.usecase
+
+import com.whyranoid.domain.repository.GroupRepository
+import javax.inject.Inject
+
+class CheckIsDuplicatedGroupNameUseCase @Inject constructor(
+    private val groupRepository: GroupRepository
+) {
+
+    suspend operator fun invoke(groupName: String): Boolean {
+        return groupRepository.isDuplicatedGroupName(groupName)
+    }
+}
diff --git a/presentation/src/main/java/com/whyranoid/presentation/community/group/create/CreateGroupFragment.kt b/presentation/src/main/java/com/whyranoid/presentation/community/group/create/CreateGroupFragment.kt
@@ -34,12 +34,6 @@ internal class CreateGroupFragment :
                 handleEvent(event)
             }
         }
-
-        viewLifecycleOwner.repeatWhenUiStarted {
-            viewModel.rules.collect {
-                println("테스트 $it")
-            }
-        }
     }
 
     private fun handleEvent(event: Event) {
@@ -60,6 +54,22 @@ internal class CreateGroupFragment :
                     ).show()
                 }
             }
+            is Event.DuplicateCheckButtonClick -> {
+                if (event.isDuplicatedGroupName) {
+                    Snackbar.make(
+                        binding.root,
+                        getString(R.string.text_duplicated_group_name),
+                        Snackbar.LENGTH_SHORT
+                    ).show()
+                } else {
+                    Snackbar.make(
+                        binding.root,
+                        getString(R.string.text_un_duplicated_group_name),
+                        Snackbar.LENGTH_SHORT
+                    ).show()
+                    binding.etGroupName.isEnabled = false
+                }
+            }
             is Event.WarningButtonClick -> {
                 Snackbar.make(
                     binding.root,
@@ -106,7 +116,7 @@ internal class CreateGroupFragment :
         }
 
         viewLifecycleOwner.repeatWhenUiStarted {
-            viewModel.isButtonEnable.collect { isEnable ->
+            viewModel.isGroupCreateButtonEnable.collect { isEnable ->
                 if (isEnable) {
                     binding.topAppBar.menu.setGroupVisible(R.id.ready_to_create, true)
                     binding.topAppBar.menu.setGroupVisible(R.id.not_ready_to_create, false)
diff --git a/presentation/src/main/java/com/whyranoid/presentation/community/group/create/CreateGroupViewModel.kt b/presentation/src/main/java/com/whyranoid/presentation/community/group/create/CreateGroupViewModel.kt
@@ -2,6 +2,7 @@ package com.whyranoid.presentation.community.group.create
 
 import androidx.lifecycle.ViewModel
 import androidx.lifecycle.viewModelScope
+import com.whyranoid.domain.usecase.CheckIsDuplicatedGroupNameUseCase
 import com.whyranoid.domain.usecase.CreateGroupUseCase
 import dagger.hilt.android.lifecycle.HiltViewModel
 import kotlinx.coroutines.flow.MutableSharedFlow
@@ -17,7 +18,8 @@ import javax.inject.Inject
 
 @HiltViewModel
 class CreateGroupViewModel @Inject constructor(
-    private val createGroupUseCase: CreateGroupUseCase
+    private val createGroupUseCase: CreateGroupUseCase,
+    private val checkIsDuplicatedGroupNameUseCase: CheckIsDuplicatedGroupNameUseCase
 ) : ViewModel() {
 
     val groupName = MutableStateFlow<String?>(null)
@@ -30,6 +32,8 @@ class CreateGroupViewModel @Inject constructor(
     private val _eventFlow = MutableSharedFlow<Event>()
     val eventFlow = _eventFlow.asSharedFlow()
 
+    private val isNotDuplicate = MutableStateFlow(false)
+
     fun onOpenDialogClicked() {
         _showDialog.value = true
     }
@@ -43,7 +47,7 @@ class CreateGroupViewModel @Inject constructor(
         _showDialog.value = false
     }
 
-    val isButtonEnable: StateFlow<Boolean>
+    val isDoubleCheckButtonEnable: StateFlow<Boolean>
         get() = groupName.combine(groupIntroduce) { name, introduce ->
             name?.trim()?.isNotEmpty() ?: false && introduce?.trim()?.isNotEmpty() ?: false
         }.stateIn(
@@ -52,8 +56,25 @@ class CreateGroupViewModel @Inject constructor(
             started = SharingStarted.WhileSubscribed(5000)
         )
 
-    // TODO 그룹명 중복확인 로직
+    val isGroupCreateButtonEnable: StateFlow<Boolean>
+        get() = combine(
+            isDoubleCheckButtonEnable,
+            isNotDuplicate
+        ) { isDoubleCheckButtonEnable, isNotDuplicate ->
+            isDoubleCheckButtonEnable && isNotDuplicate
+        }.stateIn(
+            scope = viewModelScope,
+            initialValue = false,
+            started = SharingStarted.WhileSubscribed(5000)
+        )
+
     fun onDuplicateCheckButtonClicked() {
+        viewModelScope.launch {
+            val isDuplicatedGroupName =
+                checkIsDuplicatedGroupNameUseCase(groupName.value ?: "")
+            emitEvent(Event.DuplicateCheckButtonClick(isDuplicatedGroupName))
+            isNotDuplicate.value = isDuplicatedGroupName.not()
+        }
     }
 
     fun onAddRuleButtonClicked() {
@@ -75,6 +96,13 @@ class CreateGroupViewModel @Inject constructor(
                         _eventFlow.emit(event.copy(isSuccess = false))
                     }
                 }
+                is Event.DuplicateCheckButtonClick -> {
+                    if (event.isDuplicatedGroupName) {
+                        _eventFlow.emit(event.copy(isDuplicatedGroupName = true))
+                    } else {
+                        _eventFlow.emit(event)
+                    }
+                }
                 is Event.WarningButtonClick -> {
                     _eventFlow.emit(event)
                 }
diff --git a/presentation/src/main/java/com/whyranoid/presentation/community/group/create/Event.kt b/presentation/src/main/java/com/whyranoid/presentation/community/group/create/Event.kt
@@ -4,4 +4,5 @@ sealed class Event {
     data class CreateGroupButtonClick(val isSuccess: Boolean = true) : Event()
     object WarningButtonClick : Event()
     object AddRuleButtonClick : Event()
+    data class DuplicateCheckButtonClick(val isDuplicatedGroupName: Boolean = false) : Event()
 }
diff --git a/presentation/src/main/java/com/whyranoid/presentation/community/group/edit/EditGroupFragment.kt b/presentation/src/main/java/com/whyranoid/presentation/community/group/edit/EditGroupFragment.kt
@@ -51,6 +51,22 @@ internal class EditGroupFragment :
                     ).show()
                 }
             }
+            is Event.DuplicateCheckButtonClick -> {
+                if (event.isDuplicatedGroupName) {
+                    Snackbar.make(
+                        binding.root,
+                        getString(R.string.text_duplicated_group_name),
+                        Snackbar.LENGTH_SHORT
+                    ).show()
+                } else {
+                    Snackbar.make(
+                        binding.root,
+                        getString(R.string.text_un_duplicated_group_name),
+                        Snackbar.LENGTH_SHORT
+                    ).show()
+                    binding.etGroupName.isEnabled = false
+                }
+            }
             is Event.WarningButtonClick -> {
                 Snackbar.make(
                     binding.root,
@@ -69,7 +85,7 @@ internal class EditGroupFragment :
         }
 
         viewLifecycleOwner.repeatWhenUiStarted {
-            viewModel.isButtonEnable.collect { isEnable ->
+            viewModel.isGroupCreateButtonEnable.collect { isEnable ->
                 if (isEnable) {
                     binding.topAppBar.menu.setGroupVisible(R.id.ready_to_create, true)
                     binding.topAppBar.menu.setGroupVisible(R.id.not_ready_to_create, false)
diff --git a/presentation/src/main/java/com/whyranoid/presentation/community/group/edit/EditGroupViewModel.kt b/presentation/src/main/java/com/whyranoid/presentation/community/group/edit/EditGroupViewModel.kt
diff --git a/presentation/src/main/java/com/whyranoid/presentation/community/group/edit/Event.kt b/presentation/src/main/java/com/whyranoid/presentation/community/group/edit/Event.kt
diff --git a/presentation/src/main/res/layout/fragment_create_group.xml b/presentation/src/main/res/layout/fragment_create_group.xml
diff --git a/presentation/src/main/res/layout/fragment_edit_group.xml b/presentation/src/main/res/layout/fragment_edit_group.xml
diff --git a/presentation/src/main/res/values/strings.xml b/presentation/src/main/res/values/strings.xml

Original file line number	Diff line number	Diff line change
`@@ -9,4 +9,5 @@ object CollectionId {`
`9`	`9`	`const val START_NOTIFICATION = "start"`
`10`	`10`	`const val FINISH_NOTIFICATION = "finish"`
`11`	`11`	`const val POST_COLLECTION = "Posts"`
	`12`	`+ const val RUNNING_HISTORY_COLLECTION = "RunningHistory"`
`12`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -58,4 +58,8 @@ class GroupRepositoryImpl @Inject constructor(`
`58`	`58`	`): Boolean {`
`59`	`59`	`return groupDataSource.createGroup(groupName, introduce, rules, uid)`
`60`	`60`	`}`
	`61`	`+`
	`62`	`+ override suspend fun isDuplicatedGroupName(groupName: String): Boolean {`
	`63`	`+ return groupDataSource.isDuplicatedGroupName(groupName)`
	`64`	`+ }`
`61`	`65`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,4 +40,6 @@ interface GroupRepository {`
`40`	`40`	`rules: List<String>,`
`41`	`41`	`uid: String`
`42`	`42`	`): Boolean`
	`43`	`+`
	`44`	`+ suspend fun isDuplicatedGroupName(groupName: String): Boolean`
`43`	`45`	`}`