🚚 코드리뷰 받은 변수명, 공백 수정

Author: peter-j0y

presentation/build.gradle

@@ -76,6 +76,5 @@ dependencies {
     implementation "androidx.viewpager2:viewpager2:$viewPager2Version"
 
     // Calendar Library
-
     implementation "com.github.kizitonwose:CalendarView:$calendarVersion"
 }

signin/src/main/java/com/whyranoid/SaveLogInUserInfoUseCase.kt

@@ -5,7 +5,7 @@ import javax.inject.Inject
 class SaveLogInUserInfoUseCase @Inject constructor(
     private val signInRepository: SignInRepository
 ) {
-    suspend operator fun invoke(userInfo: User): Boolean {
+    suspend operator fun invoke(userInfo: SignInUserInfo): Boolean {
         return signInRepository.saveLogInUserInfo(userInfo)
     }
 }

signin/src/main/java/com/whyranoid/SignInDataSource.kt

@@ -1,5 +1,5 @@
 package com.whyranoid
 
 interface SignInDataSource {
-    suspend fun saveLogInUserInfo(userInfo: User): Boolean
+    suspend fun saveLogInUserInfo(userInfo: SignInUserInfo): Boolean
 }

signin/src/main/java/com/whyranoid/SignInDataSourceImpl.kt

@@ -17,12 +17,12 @@ class SignInDataSourceImpl @Inject constructor(
         val profileImgUrl = stringPreferencesKey(PROFILE_IMG_URI)
     }
 
-    override suspend fun saveLogInUserInfo(userInfo: User): Boolean {
+    override suspend fun saveLogInUserInfo(userInfo: SignInUserInfo): Boolean {
         dataStoreDb.edit { preferences ->
             preferences[PreferenceKeys.uid] = userInfo.uid
-            preferences[PreferenceKeys.email] = userInfo.email ?: ""
-            preferences[PreferenceKeys.nickName] = userInfo.nickName ?: ""
-            preferences[PreferenceKeys.profileImgUrl] = userInfo.profileImgUri ?: ""
+            preferences[PreferenceKeys.email] = userInfo.email ?: EMPTY_STRING
+            preferences[PreferenceKeys.nickName] = userInfo.nickName ?: EMPTY_STRING
+            preferences[PreferenceKeys.profileImgUrl] = userInfo.profileImgUri ?: EMPTY_STRING
         }
         return true
     }
@@ -32,5 +32,6 @@ class SignInDataSourceImpl @Inject constructor(
         private const val EMAIL_KEY = "email"
         private const val NICK_NAME_KEY = "nick_name"
         private const val PROFILE_IMG_URI = "profile_img_uri"
+        private const val EMPTY_STRING = ""
     }
 }

signin/src/main/java/com/whyranoid/SignInModule.kt

@@ -12,9 +12,9 @@ abstract class SignInModule {
 
     @Binds
     @Singleton
-    abstract fun bindSignInRepository(impl: SignInRepositoryImpl): SignInRepository
+    abstract fun bindSignInRepository(signInRepositoryImpl: SignInRepositoryImpl): SignInRepository
 
     @Binds
     @Singleton
-    abstract fun bindSignInDataSource(impl: SignInDataSourceImpl): SignInDataSource
+    abstract fun bindSignInDataSource(signInDataSourceImpl: SignInDataSourceImpl): SignInDataSource
 }

signin/src/main/java/com/whyranoid/SignInRepository.kt

@@ -1,5 +1,5 @@
 package com.whyranoid
 
 interface SignInRepository {
-    suspend fun saveLogInUserInfo(userInfo: User): Boolean
+    suspend fun saveLogInUserInfo(userInfo: SignInUserInfo): Boolean
 }

signin/src/main/java/com/whyranoid/SignInRepositoryImpl.kt

@@ -5,7 +5,7 @@ import javax.inject.Inject
 class SignInRepositoryImpl @Inject constructor(private val signInDataSource: SignInDataSource) :
     SignInRepository {
 
-    override suspend fun saveLogInUserInfo(userInfo: User): Boolean {
+    override suspend fun saveLogInUserInfo(userInfo: SignInUserInfo): Boolean {
         return signInDataSource.saveLogInUserInfo(userInfo)
     }
 }

signin/src/main/java/com/whyranoid/User.kt renamed to signin/src/main/java/com/whyranoid/SignInUserInfo.kt

@@ -1,6 +1,6 @@
 package com.whyranoid
 
-data class User(
+data class SignInUserInfo(
     val uid: String,
     val email: String?,
     val nickName: String?,

signin/src/main/java/com/whyranoid/SignInViewModel.kt

@@ -8,7 +8,7 @@ import javax.inject.Inject
 class SignInViewModel @Inject constructor(
     private val saveLogInUserInfoUseCase: SaveLogInUserInfoUseCase
 ) : ViewModel() {
-    suspend fun saveUserInfo(userInfo: User) {
+    suspend fun saveUserInfo(userInfo: SignInUserInfo) {
         saveLogInUserInfoUseCase(userInfo)
     }
 }

signin/src/main/java/com/whyranoid/signin/SignInActivity.kt

@@ -19,8 +19,8 @@ import com.google.firebase.auth.FirebaseAuth
 import com.google.firebase.auth.GoogleAuthProvider
 import com.google.firebase.auth.ktx.auth
 import com.google.firebase.ktx.Firebase
+import com.whyranoid.SignInUserInfo
 import com.whyranoid.SignInViewModel
-import com.whyranoid.User
 import com.whyranoid.presentation.MainActivity
 import com.whyranoid.signin.databinding.ActivitySignInBinding
 import dagger.hilt.android.AndroidEntryPoint
@@ -125,7 +125,7 @@ class SignInActivity : AppCompatActivity() {
                 uid = auth.uid
                 lifecycleScope.launch {
                     uid?.let { uid ->
-                        viewModel.saveUserInfo(User(uid, email, nickName, profileImgUri))
+                        viewModel.saveUserInfo(SignInUserInfo(uid, email, nickName, profileImgUri))
                     }
                 }