Skip to content

Commit c1be73c

Browse files
committed
♻️ 중복된 코드 제거 및 공백 제거
1 parent d3f1530 commit c1be73c

File tree

2 files changed

+19
-19
lines changed

2 files changed

+19
-19
lines changed

presentation/src/main/java/com/whyranoid/presentation/community/group/CreateGroupFragment.kt

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ internal class CreateGroupFragment :
2525
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
2626
super.onViewCreated(view, savedInstanceState)
2727

28-
binding.lifecycleOwner = viewLifecycleOwner
2928
binding.viewModel = viewModel
3029

3130
setupMenu()
@@ -86,7 +85,25 @@ internal class CreateGroupFragment :
8685
}
8786

8887
private fun setupMenu() {
89-
binding.topAppBar.inflateMenu(R.menu.create_group_menu)
88+
with(binding.topAppBar) {
89+
inflateMenu(R.menu.create_group_menu)
90+
91+
setOnMenuItemClickListener { menuItem ->
92+
when (menuItem.itemId) {
93+
R.id.create_group_button -> {
94+
viewModel.emitEvent(Event.CreateGroupButtonClick())
95+
true
96+
}
97+
R.id.warning_about_create_group_button -> {
98+
viewModel.emitEvent(Event.WarningButtonClick)
99+
true
100+
}
101+
else -> {
102+
false
103+
}
104+
}
105+
}
106+
}
90107

91108
repeatWhenUiStarted {
92109
viewModel.isButtonEnable.collect { isEnable ->
@@ -99,21 +116,5 @@ internal class CreateGroupFragment :
99116
}
100117
}
101118
}
102-
103-
binding.topAppBar.setOnMenuItemClickListener { menuItem ->
104-
when (menuItem.itemId) {
105-
R.id.create_group_button -> {
106-
viewModel.emitEvent(Event.CreateGroupButtonClick())
107-
true
108-
}
109-
R.id.warning_about_create_group_button -> {
110-
viewModel.emitEvent(Event.WarningButtonClick)
111-
true
112-
}
113-
else -> {
114-
false
115-
}
116-
}
117-
}
118119
}
119120
}

presentation/src/main/res/menu/create_group_menu.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
<menu xmlns:android="http://schemas.android.com/apk/res/android"
33
xmlns:app="http://schemas.android.com/apk/res-auto">
44

5-
65
<group
76
android:id="@+id/not_ready_to_create"
87
android:visible="false">

0 commit comments

Comments
 (0)