fix : 시간 오버시 미션 종료 버그 수정

- broadcast Receiver를 destroy 해주니 해결됨
- intent도 removeExtra해줘서 미션이 끝나면 더이상 intent 하지 않도록 구현
- 처음에 null을 반환해서 문제였음 -> null이 아닐 때 라는 if문 추가

Author: jeeminimini

presentation/src/main/java/com/stop/ui/mission/MissionFragment.kt

@@ -54,15 +54,18 @@ class MissionFragment : Fragment(), MissionHandler {
 
     private lateinit var backPressedCallback: OnBackPressedCallback
 
+    private lateinit var userInfoReceiver: BroadcastReceiver
+    private lateinit var timeReceiver: BroadcastReceiver
+
     var personCurrentLocation = Location(37.553836, 126.969652)
     var firstTime = 0
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
 
         setMissionService()
-        setBroadcastReceiver()
-        //setTimeOverBroadcastReceiver()
+        setUserInfoBroadcastReceiver()
+        setTimeOverBroadcastReceiver()
         missionViewModel.missionStatus.value = MissionStatus.ONGOING
     }
 
@@ -103,9 +106,12 @@ class MissionFragment : Fragment(), MissionHandler {
     }
 
     override fun onDestroy() {
-        super.onDestroy()
-
         tMap.onDestroy()
+
+        requireActivity().unregisterReceiver(userInfoReceiver)
+        requireActivity().unregisterReceiver(timeReceiver)
+
+        super.onDestroy()
     }
 
     private fun setMissionService() {
@@ -117,28 +123,28 @@ class MissionFragment : Fragment(), MissionHandler {
         }
     }
 
-    private fun setBroadcastReceiver() {
+    private fun setUserInfoBroadcastReceiver() {
         val intentFilter = IntentFilter().apply {
             addAction(MissionService.MISSION_USER_INFO)
         }
 
-        val receiver = object : BroadcastReceiver() {
+        userInfoReceiver = object : BroadcastReceiver() {
             override fun onReceive(context: Context?, intent: Intent?) {
                 missionViewModel.lastTime.value = intent?.getStringExtra(MISSION_LAST_TIME)
                 missionViewModel.userLocations.value =
                     intent?.getParcelableArrayListExtra<Location>(MISSION_LOCATIONS) as ArrayList<Location>
             }
         }
 
-        requireActivity().registerReceiver(receiver, intentFilter)
+        requireActivity().registerReceiver(userInfoReceiver, intentFilter)
     }
 
     private fun setTimeOverBroadcastReceiver() {
         val intentFilter = IntentFilter().apply {
             addAction(MISSION_TIME_OVER)
         }
 
-        val receiver = object : BroadcastReceiver() {
+        timeReceiver = object : BroadcastReceiver() {
             override fun onReceive(context: Context?, intent: Intent?) {
                 if (intent?.getBooleanExtra(MISSION_TIME_OVER, false) == true) {
                     Snackbar.make(
@@ -151,7 +157,7 @@ class MissionFragment : Fragment(), MissionHandler {
 
             }
         }
-        requireActivity().registerReceiver(receiver, intentFilter)
+        requireActivity().registerReceiver(timeReceiver, intentFilter)
     }
 
     private fun setTimer() {
@@ -161,6 +167,8 @@ class MissionFragment : Fragment(), MissionHandler {
         } else {
             requireActivity().startService(missionServiceIntent)
         }
+
+        missionServiceIntent.removeExtra(MISSION_LAST_TIME)
     }
 
     private fun setDataBinding() {
@@ -338,7 +346,7 @@ class MissionFragment : Fragment(), MissionHandler {
     }
 
     private fun setSuccessAnimation() {
-        with (binding.lottieSuccess) {
+        with(binding.lottieSuccess) {
             playAnimation()
             addAnimatorListener(object : Animator.AnimatorListener {
                 override fun onAnimationStart(animation: Animator) {
@@ -358,7 +366,7 @@ class MissionFragment : Fragment(), MissionHandler {
     }
 
     private fun setFailAnimation() {
-        with (binding.lottieFail) {
+        with(binding.lottieFail) {
             visibility = View.VISIBLE
             playAnimation()
             addAnimatorListener(object : Animator.AnimatorListener {

presentation/src/main/java/com/stop/ui/mission/MissionService.kt

@@ -140,19 +140,19 @@ class MissionService : LifecycleService() {
 
     private fun getTimer(intent: Intent?) {
         val lastTimeString = intent?.getStringExtra(MISSION_LAST_TIME)
-        val lastTimeMillis = makeFullTime(lastTimeString ?: "").timeInMillis
-        val nowTimeMillis = System.currentTimeMillis()
-        var diffTimeMillis = if (lastTimeMillis > nowTimeMillis) lastTimeMillis - nowTimeMillis else 0L
-
-        timer.cancel()
-        timer = lifecycleScope.launch(Dispatchers.IO) {
-            while (diffTimeMillis > 0L) {
-                lastTime = convertTimeMillisToString(diffTimeMillis)
-                sendUserInfo()
-                diffTimeMillis -= 1_000L
-                delay(1_000L)
-            }
-            if (diffTimeMillis == 0L) {
+        if (lastTimeString != null) {
+            val lastTimeMillis = makeFullTime(lastTimeString).timeInMillis
+            val nowTimeMillis = System.currentTimeMillis()
+            var diffTimeMillis = if (lastTimeMillis > nowTimeMillis) lastTimeMillis - nowTimeMillis else 0L
+
+            timer.cancel()
+            timer = lifecycleScope.launch(Dispatchers.IO) {
+                while (diffTimeMillis > 0L) {
+                    lastTime = convertTimeMillisToString(diffTimeMillis)
+                    sendUserInfo()
+                    diffTimeMillis -= 1_000L
+                    delay(1_000L)
+                }
                 sendMissionOver()
             }
         }