refactor: RouteDetailFragment 리팩토링

khcho226 · khcho226 · commit c6b56a1915db · 2022-12-07T21:18:56.000+09:00
diff --git a/presentation/src/main/java/com/stop/ui/routedetail/RouteDetailAdapter.kt b/presentation/src/main/java/com/stop/ui/routedetail/RouteDetailAdapter.kt
@@ -20,6 +20,7 @@ class RouteDetailAdapter(
     ) : RecyclerView.ViewHolder(binding.root) {
         fun bind(routeItem: RouteItem) {
             binding.routeItem = routeItem
+            binding.executePendingBindings()
         }
     }
 
@@ -28,6 +29,7 @@ class RouteDetailAdapter(
     ) : RecyclerView.ViewHolder(binding.root) {
         fun bind(routeItem: RouteItem) {
             binding.routeItem = routeItem
+            binding.executePendingBindings()
         }
     }
 
@@ -36,6 +38,7 @@ class RouteDetailAdapter(
     ) : RecyclerView.ViewHolder(binding.root) {
         fun bind(routeItem: RouteItem) {
             binding.routeItem = routeItem
+            binding.executePendingBindings()
         }
     }
 
diff --git a/presentation/src/main/java/com/stop/ui/routedetail/RouteDetailFragment.kt b/presentation/src/main/java/com/stop/ui/routedetail/RouteDetailFragment.kt
@@ -69,7 +69,7 @@ class RouteDetailFragment : Fragment(), RouteDetailHandler {
         }
 
         binding.routeDetailDrawer.viewAlarm.setOnClickListener {
-            binding.root.findNavController().navigate(R.id.action_routeDetailFragment_to_alarmSetting)
+            findNavController().navigate(R.id.action_routeDetailFragment_to_alarmSetting)
         }
 
         binding.imageViewClose.setOnClickListener {
diff --git a/presentation/src/main/res/layout/fragment_route_detail.xml b/presentation/src/main/res/layout/fragment_route_detail.xml
@@ -63,7 +63,7 @@
                     android:layout_marginEnd="5dp"
                     android:maxLines="1"
                     android:ellipsize="end"
-                    android:gravity="center_vertical|center_horizontal"
+                    android:gravity="center"
                     android:text="@{routeResultViewModel.origin.name}"
                     android:textSize="17sp"
                     android:textColor="@color/main_light_grey"
@@ -90,7 +90,7 @@
                     android:layout_marginEnd="10dp"
                     android:maxLines="1"
                     android:ellipsize="end"
-                    android:gravity="center_vertical|center_horizontal"
+                    android:gravity="center"
                     android:text="@{routeResultViewModel.destination.name}"
                     android:textSize="17sp"
                     android:textColor="@color/main_light_grey"
diff --git a/presentation/src/main/res/layout/route_first_item.xml b/presentation/src/main/res/layout/route_first_item.xml
@@ -84,9 +84,9 @@
             android:layout_width="15dp"
             android:layout_height="15dp"
             android:background="@drawable/ic_star_white"
-            app:layout_constraintStart_toStartOf="@+id/image_view_current_line"
-            app:layout_constraintEnd_toEndOf="@+id/image_view_current_line"
-            app:layout_constraintTop_toTopOf="@+id/image_view_current_line"
-            app:layout_constraintBottom_toBottomOf="@+id/image_view_current_line" />
+            app:layout_constraintStart_toStartOf="@id/image_view_current_line"
+            app:layout_constraintEnd_toEndOf="@id/image_view_current_line"
+            app:layout_constraintTop_toTopOf="@id/image_view_current_line"
+            app:layout_constraintBottom_toBottomOf="@id/image_view_current_line" />
     </androidx.constraintlayout.widget.ConstraintLayout>
 </layout>
diff --git a/presentation/src/main/res/layout/route_last_item.xml b/presentation/src/main/res/layout/route_last_item.xml
@@ -84,10 +84,10 @@
             android:layout_width="15dp"
             android:layout_height="15dp"
             android:background="@drawable/ic_star_white"
-            app:layout_constraintStart_toStartOf="@+id/image_view_current_line"
-            app:layout_constraintEnd_toEndOf="@+id/image_view_current_line"
-            app:layout_constraintTop_toTopOf="@+id/image_view_current_line"
-            app:layout_constraintBottom_toBottomOf="@+id/image_view_current_line" />
+            app:layout_constraintStart_toStartOf="@id/image_view_current_line"
+            app:layout_constraintEnd_toEndOf="@id/image_view_current_line"
+            app:layout_constraintTop_toTopOf="@id/image_view_current_line"
+            app:layout_constraintBottom_toBottomOf="@id/image_view_current_line" />
 
         <View
             android:id="@+id/view_line"
diff --git a/presentation/src/main/res/layout/route_path_item.xml b/presentation/src/main/res/layout/route_path_item.xml
@@ -124,10 +124,10 @@
         <ImageView
             android:layout_width="15dp"
             android:layout_height="15dp"
-            app:layout_constraintStart_toStartOf="@+id/image_view_current_line"
-            app:layout_constraintEnd_toEndOf="@+id/image_view_current_line"
-            app:layout_constraintTop_toTopOf="@+id/image_view_current_line"
-            app:layout_constraintBottom_toBottomOf="@+id/image_view_current_line"
+            app:layout_constraintStart_toStartOf="@id/image_view_current_line"
+            app:layout_constraintEnd_toEndOf="@id/image_view_current_line"
+            app:layout_constraintTop_toTopOf="@id/image_view_current_line"
+            app:layout_constraintBottom_toBottomOf="@id/image_view_current_line"
             app:imageResource="@{routeItem.mode}"
             tools:src="@drawable/ic_walk_white" />
 
diff --git a/presentation/src/main/res/navigation/nav_graph.xml b/presentation/src/main/res/navigation/nav_graph.xml
@@ -37,31 +37,6 @@
             app:destination="@id/mapFragment" />
     </fragment>
 
-    <fragment
-        android:id="@+id/routeDetailFragment"
-        android:name="com.stop.ui.routedetail.RouteDetailFragment"
-        android:label="RouteDetailFragment" >
-
-        <action
-            android:id="@+id/action_routeDetailFragment_to_alarmSetting"
-            app:destination="@id/alarmSetting" />
-
-        <action
-            android:id="@+id/action_routeDetailFragment_to_mapFragment"
-            app:destination="@id/mapFragment" />
-    </fragment>
-
-    <fragment
-        android:id="@+id/alarmSetting"
-        android:name="com.stop.ui.alarmsetting.AlarmSettingFragment"
-        android:label="fragment_alarm_setting"
-        tools:layout="@layout/fragment_alarm_setting" >
-
-        <action
-            android:id="@+id/action_alarmSetting_to_mapFragment"
-            app:destination="@id/mapFragment" />
-    </fragment>
-
     <fragment
         android:id="@+id/alarmStartFragment"
         android:name="com.stop.ui.alarmstart.AlarmStartFragment"

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ class RouteDetailAdapter(`
`20`	`20`	`) : RecyclerView.ViewHolder(binding.root) {`
`21`	`21`	`fun bind(routeItem: RouteItem) {`
`22`	`22`	`binding.routeItem = routeItem`
	`23`	`+ binding.executePendingBindings()`
`23`	`24`	`}`
`24`	`25`	`}`
`25`	`26`
`@@ -28,6 +29,7 @@ class RouteDetailAdapter(`
`28`	`29`	`) : RecyclerView.ViewHolder(binding.root) {`
`29`	`30`	`fun bind(routeItem: RouteItem) {`
`30`	`31`	`binding.routeItem = routeItem`
	`32`	`+ binding.executePendingBindings()`
`31`	`33`	`}`
`32`	`34`	`}`
`33`	`35`
`@@ -36,6 +38,7 @@ class RouteDetailAdapter(`
`36`	`38`	`) : RecyclerView.ViewHolder(binding.root) {`
`37`	`39`	`fun bind(routeItem: RouteItem) {`
`38`	`40`	`binding.routeItem = routeItem`
	`41`	`+ binding.executePendingBindings()`
`39`	`42`	`}`
`40`	`43`	`}`
`41`	`44`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ class RouteDetailFragment : Fragment(), RouteDetailHandler {`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`binding.routeDetailDrawer.viewAlarm.setOnClickListener {`
`72`		`- binding.root.findNavController().navigate(R.id.action_routeDetailFragment_to_alarmSetting)`
	`72`	`+ findNavController().navigate(R.id.action_routeDetailFragment_to_alarmSetting)`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`binding.imageViewClose.setOnClickListener {`